On Tue, 12 Mar 2024 21:52:31 GMT, Elif Aslan wrote:
> This change enables to run JspawnhelperProtocol.java on MacOS.
>
> In addition to GHA , the test has been run on macos and linux.
>
>
> Test report is stored in
>
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
Marked as reviewed by gli (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/18173#pullrequestreview-1926166255
On Fri, 8 Mar 2024 02:54:49 GMT, Alex Menkov wrote:
> RecordComponent class has _attributes_count field.
> The only user of the field is JvmtiClassFileReconstituter. Incorrect value of
> the field causes producing incorrect data for Record attribute.
> Parsing Record attribute ClassFileParser
On Thu, 7 Mar 2024 07:20:15 GMT, David Holmes wrote:
> Oracle requests/requires that the Oracle copyright always be updated when a
> file is modified.
Got it. Thanks for your explanation.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1515672685
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Korov has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin
On Wed, 6 Mar 2024 18:26:16 GMT, Korov wrote:
> When the specified key did not associated with a value, should check the
> `key` and `value` type.
Good caught. A trivial suggestion.
test/jdk/java/util/Collections/CheckedMapBash.java line 192:
> 190: Map m =
On Wed, 6 Mar 2024 16:30:23 GMT, Matthias Baesken wrote:
>> We define the RESTARTABLE macro again and again at a lot of places in the
>> JDK native codebase. This could be centralized to avoid repeating it again
>> and again !
>
> Matthias Baesken has updated the pull request incrementally
On Wed, 6 Mar 2024 09:26:25 GMT, Matthias Baesken wrote:
> We define the RESTARTABLE macro again and again at a lot of places in the JDK
> native codebase. This could be centralized to avoid repeating it again and
> again !
Looks good. Nice refactor.
-
Marked as reviewed by gli
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote:
> Fixing test cases. For bad test cases, only the first case was run, and the
> rest were ignored.
Looks good.
Only a trivial suggestion.
test/jdk/java/lang/Double/ParseDouble.java line 564:
> 562: check(input[i]);
> 563:
On Mon, 4 Mar 2024 13:55:15 GMT, Claes Redestad wrote:
> [JDK-8325340](https://bugs.openjdk.org/browse/JDK-8325340) accidentally
> removed `final` from the `static final DataInputStream.readUTF` method. This
> has a minor compatibility impact (allows hiding the method in a subclass,
> while
On Tue, 5 Mar 2024 00:15:10 GMT, Justin Lu wrote:
> For clarification, this is entirely a bug with DecimalFormat, not
> StringBuilder. An empty String pattern DecimalFormat sets the maximum
> fraction digits to Integer.MAX_VALUE. When toPattern() is invoked, the local
> StringBuilder will
On Sat, 2 Mar 2024 00:34:32 GMT, Justin Lu wrote:
> When toPattern() is invoked, StringBuilder internally doubles capacity
> attempting to append Integer.MAX_VALUE digits until OOME occurs.
It seems a bug in `toPattern` or `StringBuilder`? May be better to investigate
more about it.
On Thu, 29 Feb 2024 00:16:28 GMT, Kim Barrett wrote:
>> Please review this change that renames some test .h files to .hpp. These
>> files contain C++ code and should be named accordingly. Some of them contain
>> uses of NULL, which we change to nullptr.
>>
>> The renamed files are:
>>
>>
On Mon, 26 Feb 2024 15:10:55 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-widen test
>
> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 328:
>
>> 326: *
On Tue, 27 Feb 2024 16:15:06 GMT, Lance Andersen wrote:
>> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
>> module summary so that it is consistent with the use of "ZIP".
>>
>> In addition,
>> open/src/java.base/share/classes/java/util/zip/package-info.java has
On Tue, 27 Feb 2024 16:15:06 GMT, Lance Andersen wrote:
>> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
>> module summary so that it is consistent with the use of "ZIP".
>>
>> In addition,
>> open/src/java.base/share/classes/java/util/zip/package-info.java has
On Wed, 28 Feb 2024 01:18:50 GMT, Kim Barrett wrote:
> Please review this change that renames some test .h files to .hpp. These
> files contain C++ code and should be named accordingly. Some of them contain
> uses of NULL, which we change to nullptr.
>
> The renamed files are:
>
>
On Fri, 12 Jan 2024 13:41:39 GMT, kerr wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 10 additional commits
>> since the
On Mon, 11 Dec 2023 02:36:30 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch fixes the building failure introduced by
> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version
> (linux & GCC 7.5.0 locally).
>
> Thanks for the review.
>
&g
On Tue, 19 Dec 2023 23:23:28 GMT, Kim Barrett wrote:
>>> @lgxbslgx We would like to keep GCC 8.4.0 as the minimum.
>>
>> Why? That's likely going to be in conflict with
>> https://github.com/openjdk/jdk/pull/14988.
>
>> @kimbarrett I meant to say that since the libsimdsort works with GCC
On Sun, 17 Dec 2023 13:25:00 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> This patch fixes the building failure introduced by
>> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC
>> version (linux & GCC 7.5.0 locally).
>>
>&g
On Fri, 15 Dec 2023 08:48:59 GMT, Kim Barrett wrote:
>> Hi all,
>>
>> This patch fixes the building failure introduced by
>> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC
>> version (linux & GCC 7.5.0 locally).
>>
>> Thanks for the review.
>>
>> Best Regards,
>> --
> Hi all,
>
> This patch fixes the building failure introduced by
> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version
> (linux & GCC 7.5.0 locally).
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has u
On Tue, 12 Dec 2023 15:40:19 GMT, Magnus Ihse Bursie wrote:
> Somehow the JDK compiled with 7.5 for the author of that patch, but fails for
> the author of this patch. I don't understand how this both can be true.
I noticed my previous build is `slowdebug`. Today, I tested the `release` and
Hi all,
This patch fixes the building failure introduced by
[JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version
(linux & GCC 7.5.0 locally).
Thanks for the review.
Best Regards,
-- Guoxiong
-
Commit messages:
- JDK-8321688
Changes:
25 matches
Mail list logo
