Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v11]

> The testcase requires root permissions. > > Designed by Severin Gehwolf, implemented by Jan Kratochvil. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 74 commits: - . - . - Merge branch 'jdk-83315

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v9]

On Wed, 8 May 2024 02:56:10 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. >> >> Designed by Severin Gehwolf, implemented by Jan Kratochvil. > > Jan Kratochvil has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v10]

> The testcase requires root permissions. > > Designed by Severin Gehwolf, implemented by Jan Kratochvil. Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: whitespace fix - Changes: - all: https://git.op

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v9]

> The testcase requires root permissions. > > Designed by Severin Gehwolf, implemented by Jan Kratochvil. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 49 commits: - centos7 compat - 64a5feb6:

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v8]

On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. >> >> Designed by Severin Gehwolf, implemented by Jan Kratochvil. > > Jan Kratochvil has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v8]

On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. >> >> Designed by Severin Gehwolf, implemented by Jan Kratochvil. > > Jan Kratochvil has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v8]

On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. >> >> Designed by Severin Gehwolf, implemented by Jan Kratochvil. > > Jan Kratochvil has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v8]

On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. >> >> Designed by Severin Gehwolf, implemented by Jan Kratochvil. > > Jan Kratochvil has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container

On Fri, 19 Apr 2024 05:18:51 GMT, Laurence Cable wrote: > I think (I am agreeing with you Severin) that the goal of the heuristic is to > inform the JVM (and any associated serviceability tools) that the JVM is in a > resource constrained/managed execution context... "resource constrained"

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v2]

On Thu, 11 Apr 2024 12:08:02 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >>

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v2]

On Tue, 16 Apr 2024 15:17:33 GMT, Severin Gehwolf wrote: > The idea here is to use this property to tune OpenJDK for in-container, > specifically k8s, use. In such a setup it's custom to run a single process > within set resource constraints. The in-container tuning means to use all the

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v2]

On Thu, 11 Apr 2024 12:08:02 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >>

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v7]

On Wed, 21 Feb 2024 14:02:12 GMT, Severin Gehwolf wrote: > I'm surprised that the hierarchical memory limit look-up wouldn't see it for > v1. Either way, using the traversal approach you'd see that `foo/bar` has `2 > GB`, when traversing up the hierarchy you'd see `1 GB` for `foo` and use that

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v7]

On Wed, 21 Feb 2024 13:20:20 GMT, Severin Gehwolf wrote: > One goal of this patch would be to unify how this works for cgroup v1 and > cgroup v2. That is not much possible anyway as currently cgroup2 has to traverse the directories while after the kernel patch gets accepted it will be faster

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v7]

On Tue, 20 Feb 2024 15:15:09 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. >> >> Designed by Severin Gehwolf, implemented by Jan Kratochvil. > > Jan Kratochvil has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v8]

> The testcase requires root permissions. > > Designed by Severin Gehwolf, implemented by Jan Kratochvil. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 35 commits: - Fix whitespace - Merge branc

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2]

On Wed, 31 Jan 2024 15:33:01 GMT, Jan Kratochvil wrote: >> It looks like this patch needs a bit more discussion. Generally, it would be >> good to have the functionality, but I'm unsure about the proposed >> implementation. >> >> Walking the directory hier

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v7]

> The testcase requires root permissions. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits: - Disable cgroup.subtree_control testcase on cgroup1 - Extend the testcase - Implement cgroup.subtree_cont

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v6]

> The testcase requires root permissions. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revis

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2]

On Fri, 12 Jan 2024 17:12:37 GMT, Severin Gehwolf wrote: > Walking the directory hierarchy (**and** interface files) on every call of > `physical_memory()` (or `active_processor_count()` for CPU) seems concerning. I have therefore implemented a hierarchical `memory.stat` extension for cgroup2

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v5]

> The testcase requires root permissions. Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: Remove unneeded jdk.test.lib.helpers.ClassFileInstaller - Changes: - all: https://git.openjdk.org/jdk/pull/17198/fi

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2]

On Fri, 12 Jan 2024 16:26:58 GMT, Severin Gehwolf wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix gtest testcases compilation errors > > test/hotspot/jtreg/containers/cg

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4]

> The testcase requires root permissions. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the l

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v3]

> The testcase requires root permissions. Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the l

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2]

On Thu, 28 Dec 2023 15:19:23 GMT, Jan Kratochvil wrote: >> The testcase requires root permissions. > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Fix gtest testcases compilation errors ping, ar

Re: RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2]

> The testcase requires root permissions. Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: Fix gtest testcases compilation errors - Changes: - all: https://git.openjdk.org/jdk/pull/17198/files - new: ht

RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected

The testcase requires root permissions. - Commit messages: - 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected - 4c556a78: Changes: https://git.openjdk.org/jdk/pull/17198/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17198=00 Issue: