On Thu, 2 Nov 2023 11:58:23 GMT, Jim Laskey wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove .orig files
>
> Re .orig. Thank you Alan.
@JimLaskey , please "/issue add JDK-8319133" to include the annotation
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
This pull request has now been integrated.
Changeset: 9dc40ba4
Author: Joe
On Thu, 2 Nov 2023 02:11:19 GMT, Jie Fu wrote:
> LGTM
>
> If tier2 is unchanged after this patch, it would be good to change the JBS
> title. Thanks.
Good point; bug and PR titles updated accordingly. Thanks.
-
PR Comment:
On Wed, 1 Nov 2023 20:36:38 GMT, Joe Darcy wrote:
>> I would suggest to determine the set of tests which run "at most 10 seconds
>> total" and run only them in tier1.
>> Also taking into account API coverage.
>
>> I would suggest to determine the set o
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review fe
On Wed, 1 Nov 2023 14:52:23 GMT, Raffaello Giulietti
wrote:
>> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
>> improving guarantees of internal invariants.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the
On Wed, 1 Nov 2023 19:11:28 GMT, Vladimir Kozlov wrote:
> I would suggest to determine the set of tests which run "at most 10 seconds
> total" and run only them in tier1. Also taking into account API coverage.
Okay; I think preserving a handful of tests to check for a dead-on-arrival
vector
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
> May I ask how long it will take to run jdk_vector_sanity?
>
> My
Due to their longer-than-typical running time and because the vector API is not
(yet) in the base module, move the vector API tests in tier 1 to tier 2.
-
Commit messages:
- JDK-8319195: Move tier 1 vector API regression tests to tier 2
Changes:
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
As a check on the semantics of the change, `jtreg -l ...` output for tier 1 and
On Fri, 20 Oct 2023 21:26:51 GMT, Doug Lea wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>>
On Fri, 6 Oct 2023 18:07:37 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630)
>> which makes the implications of overriding _ChoiceFormat::applyPattern_ and
>> _MessageFormat::applyPattern_ apparent by adding a implSpec tag to the
>> method.
On Sat, 21 Oct 2023 00:56:21 GMT, Joe Darcy wrote:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
This pull request has now been integrated.
Changeset: 1b150117
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Re-flow paragraph.
- Fix a typo.
-
Changes:
- all: https://git.openjdk.o
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback, fix typos.
-
Changes:
- all: https://git.openj
On Mon, 23 Oct 2023 20:07:07 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo.
>
> src/java.base/share/classes/java/math/BigInteger.java line 137:
On Mon, 23 Oct 2023 20:05:50 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 302:
&g
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
>
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16298/files
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jd
On Sun, 22 Oct 2023 11:22:27 GMT, Raffaello Giulietti
wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> src/java.base/share/classes/java/math/BigInteger.java line 152:
>
>> 150: * time of operations can screen out {@code BigInteger} values
Add informative notes to BigInteger and BigDecimal about possible running
times, etc.
-
Commit messages:
- Appease jcheck.
- JDK-8318476: Add resource consumption note to BigInteger and BigDecimal
Changes: https://git.openjdk.org/jdk/pull/16298/files
Webrev:
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZi
On Fri, 22 Sep 2023 15:27:51 GMT, Raffaello Giulietti
wrote:
>> A new paper
>>
>> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
>> Quadruple Precision"
>> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
>>
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZi
A new paper
"Accuracy of Mathematical Functions in Single, Double, Double Extended, and
Quadruple Precision"
by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
https://members.loria.fr/PZimmermann/papers/accuracy.pdf
details the inputs with generate the worst-case observed errors in
On Thu, 27 Apr 2023 23:42:54 GMT, Joe Darcy wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix assuming match without MethodParameters for type annotations, move
&
On Thu, 28 Sep 2023 20:39:29 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
>> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
>> related classes.
>>
>> The current spec for most of these methods is either
On Mon, 25 Sep 2023 08:11:48 GMT, Per Minborg wrote:
> This PR proposes to add the @sealedGraph tag to
> `java.lang.reflect.Executable`.
Please update the copyright year before pushing.
-
Marked as reviewed by darcy (Reviewer).
PR Review:
On Fri, 22 Sep 2023 15:27:51 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo found in code review.
>
> test/jdk/java/lang/Math/WorstCaseTests.jav
nputs with generate the worst-case observed errors in different
> math library implementations. The FDLIBM-related worst cases should be added
> to the test suite.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo found in code
nputs with generate the worst-case observed errors in different
> math library implementations. The FDLIBM-related worst cases should be added
> to the test suite.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add stated error bounds.
On Thu, 21 Sep 2023 19:19:34 GMT, Joe Darcy wrote:
> The Math.hypot method claims its error bound is one ulp.
>
> The paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double
> Extended, and Quadruple Precision"
> Brian Gladman, Vincenzo Innocente
A new paper
"Accuracy of Mathematical Functions in Single, Double, Double Extended, and
Quadruple Precision"
by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
https://members.loria.fr/PZimmermann/papers/accuracy.pdf
details the inputs with generate the worst-case observed errors in
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZi
The Math.hypot method claims its error bound is one ulp.
The paper
"Accuracy of Mathematical Functions in Single, Double, Double
Extended, and Quadruple Precision"
Brian Gladman, Vincenzo Innocente and Paul Zimmermann
September 21, 2023
https://members.loria.fr/PZimmermann/papers/accuracy.pdf
On Thu, 21 Sep 2023 19:19:34 GMT, Joe Darcy wrote:
> The Math.hypot method claims its error bound is one ulp.
>
> The paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double
> Extended, and Quadruple Precision"
> Brian Gladman, Vincenzo Innocente
On Fri, 8 Sep 2023 21:11:11 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the
>> `java.text.ChoiceFormat` specification regarding its pattern.
>>
>> `j.text.ChoiceFormat` provides an example pattern in the
On Wed, 6 Sep 2023 03:34:04 GMT, 温绍锦 wrote:
>> BigDecimal is a commonly used class in business development, It is often
>> necessary to perform toString or toPlainString operations on BigDecimal.
>>
>> The current version uses StringBuilder resulting in multiple memory
>> allocations, I made
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Mon, 28 Aug 2023 21:24:18 GMT, Justin Lu wrote:
> Please review this PR which refines the spec of `equals()` and `hashCode()`
> in `java.text.Format` related classes.
>
> The current spec for most of these methods is either "_Overrides
> _" or are incomplete/wrong (i.e. see
On Mon, 21 Aug 2023 16:57:57 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/ObjectStreamClass.java line 1670:
>>
>>> 1668: ObjectStreamField[] serialPersistentFields = null;
>>> 1669: try {
>>> 1670: Field f = getDeclaredField(cl,
On Tue, 22 Aug 2023 06:57:23 GMT, Andrey Turbanov wrote:
> Field is unused since
> [JDK-8004698](https://bugs.openjdk.org/browse/JDK-8004698) -
> https://github.com/openjdk/jdk/commit/b29b4794613a2aca125c2a6e9f8ed1d0f01a4ce2#diff-2b6035b7134d61a89cfee1ad7bdc1bf21ce37421358375d6399de950c17c0c8e
On Thu, 17 Aug 2023 04:52:59 GMT, Joe Darcy wrote:
> Use of javadoc search index feature; I'll re-flow paragraphs before pushing
> once the wording is agreed to.
This pull request has now been integrated.
Changeset: 3bb8afba
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/
> Use of javadoc search index feature; I'll re-flow paragraphs before pushing
> once the wording is agreed to.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Reflow-paragraphs.
-
Changes:
- all: https://git.openj
On Thu, 17 Aug 2023 08:32:26 GMT, Alan Bateman wrote:
> This looks okay to me. You might want to move the "For a" on L58 to the next
> line to avoid L58 stick out too much, up to you.
Sure; I usually prefer to re-flow the paragraphs after the text changes are
agreed to so the difference is
> Use of javadoc search index feature; I'll re-flow paragraphs before pushing
> once the wording is agreed to.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all:
On Thu, 17 Aug 2023 13:00:40 GMT, Raffaello Giulietti
wrote:
> What about `semi-monotonic` on L.80? Does it deserve to be tagged as
> `` and indexed?
Good idea; added. The term "IEEE 754" is already index from various section
titles so I didn't add an index item for that explicitly.
Use of javadoc search index feature; I'll re-flow paragraphs before pushing
once the wording is agreed to.
-
Commit messages:
- JDK-8314489: Add javadoc index entries for java.lang.Math terms
Changes: https://git.openjdk.org/jdk/pull/15322/files
Webrev:
On Thu, 13 Jul 2023 17:57:16 GMT, Andrey Turbanov wrote:
> Couple of static fields in Math could be declared `final`.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14875#pullrequestreview-1565476822
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
> select platforms.
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Tue, 18 Jul 2023 04:42:31 GMT, Joe Darcy wrote:
> Change one overload of java.lang.reflect.Array.newInstance to have an
> `@implSpec` of calling the other method.
>
> I choose not to use a snippet tag here is this code is semantically only one
> line and doesn't need to be
On Tue, 18 Jul 2023 05:05:24 GMT, Chen Liang wrote:
>> Change one overload of java.lang.reflect.Array.newInstance to have an
>> `@implSpec` of calling the other method.
>>
>> I choose not to use a snippet tag here is this code is semantically only one
>> line and doesn't need to be
On Tue, 18 Jul 2023 16:25:17 GMT, Mandy Chung wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b4dce0d6](https://github.com/openjdk/jdk/commit/b4dce0d62479c2494c02570a60319cb1a5932940)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
Change one overload of java.lang.reflect.Array.newInstance to have an
`@implSpec` of calling the other method.
I choose not to use a snippet tag here is this code is semantically only one
line and doesn't need to be cut-and-pasted.
As adding an `@implSpec` is technically a (small)
On Wed, 31 May 2023 11:57:19 GMT, Raffaello Giulietti
wrote:
>> The `default` method `nextDouble(double origin, double bound)` in
>> `java.util.random.RandomGenerator` aims at generating a uniformly and
>> spatially equidistributed random `double` in the left-closed and right-open
>> range
On Mon, 17 Jul 2023 19:40:42 GMT, Joe Darcy wrote:
> Update to conform to accepted syntax.
This pull request has now been integrated.
Changeset: 295ae119
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/295ae1190dfb6ac3d00d3cf2d8c8c131f5c319b5
Stats: 2 lines in 2 fi
Update to conform to accepted syntax.
-
Commit messages:
- JDK-8312195: Changes in JDK-8284493 use wrong copyright synta
Changes: https://git.openjdk.org/jdk/pull/14908/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14908=00
Issue:
On Fri, 14 Jul 2023 03:27:07 GMT, Chris Hennick wrote:
>> Chris Hennick has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 20 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into patch-1
>> - Merge remote-tracking
On Mon, 15 May 2023 15:51:02 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote:
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
This pull request has now been integrated.
Changeset: 19691fab
Author: Joe Darcy
URL:
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Expand test as recommended in code review co
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Clarify docs based on review fe
On Fri, 14 Jul 2023 16:55:44 GMT, Mandy Chung wrote:
> The example above of a primitive type is `I` (the descriptor string) versus
> `forPrimitiveType` takes the primitive type name. It may need some
> clarification.
Add some clarification that argument like "int" and "long" are expected for
On Fri, 14 Jul 2023 02:54:59 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request with a new target base due to a me
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes b
On Mon, 10 Jul 2023 20:24:30 GMT, Joe Darcy wrote:
>> Going over some old issues and found this RFE, posting without any tests or
>> a CSR first to get some feedback on the overall API.
>
> Joe Darcy has updated the pull request with a new target base due to a me
On Tue, 11 Jul 2023 17:21:13 GMT, Alan Bateman wrote:
> Clean backport of https://git.openjdk.org/jdk/pull/14679
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/113#pullrequestreview-1524813830
On Fri, 30 Jun 2023 23:46:48 GMT, Chen Liang wrote:
> The main downside of throwing an exception is that exception stack trace
> filling is very costly. If this API is used to process unsanitized strings
> like users inputs, throwing might impose performance costs for handling bad
> inputs.
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes b
On Sat, 1 Jul 2023 01:32:48 GMT, Mandy Chung wrote:
> The descriptor string "I", "J", etc possible but not for "int", "long",
> "byte" etc which are keywords and can't be used as identifiers to name a
> class.
For users, I think it is reasonable for there to be an API accepting the
On Fri, 7 Jul 2023 15:56:13 GMT, Brian Burkhalter wrote:
>> Add a default method `java.io.Closeable::closeUnchecked` which is equivalent
>> to `Closeable::close` except that it instead throws
>> `java.io.UncheckedIOException`.
>
> Brian Burkhalter has updated the pull request incrementally
On Thu, 29 Jun 2023 15:50:33 GMT, Roger Riggs wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote:
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Besides whether or not the method itself is worth adding, I think the main
design question if on
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote:
> Going over some old issues and found this RFE, posting without any tests or a
> CSR first to get some feedback on the overall API.
Not present in the PR as written, but it would be possible to introduce a
sealed interface Primiti
Going over some old issues and found this RFE, posting without any tests or a
CSR first to get some feedback on the overall API.
-
Commit messages:
- JDK-6361826: (reflect) provide method for mapping strings to class object
for primitive types
Changes:
On Fri, 30 Jun 2023 18:12:18 GMT, Mandy Chung wrote:
>> The spec of `ClassLoader::getClassLoadingLock` is unclear that this method
>> is intended for parallel-capable class loader implementations to provide an
>> alternate implementation. For non-parallel-capable class loaders, this
>>
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote:
> Please review this IDE-assisted typo hunt, which I plan to backport to jdk21.
Looks fine, but please give some time for others reviewers before pushing.
-
Marked as reviewed by darcy (Reviewer).
PR Review:
On Thu, 29 Jun 2023 20:37:09 GMT, Joe Darcy wrote:
> Make the docs in JDK 21 better too.
This pull request has now been integrated.
Changeset: 60db329e
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk21/commit/60db329e4cd2a9fe7f7f23e0ddde3356bab8ba51
Stats: 2 lines in 1 f
Make the docs in JDK 21 better too.
-
Commit messages:
- Backport d97966266e343671693825d2211a34fa45dd271d
Changes: https://git.openjdk.org/jdk21/pull/82/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21=82=00
Issue: https://bugs.openjdk.org/browse/JDK-835
Stats: 2
On Thu, 29 Jun 2023 20:14:10 GMT, Joe Darcy wrote:
> Typo fix; running a spell check over the comments and strings in the file,
> didn't notice any other problems.
This pull request has now been integrated.
Changeset: d9796626
Author: Joe Darcy
URL:
https://git.openjdk.o
Typo fix; running a spell check over the comments and strings in the file,
didn't notice any other problems.
-
Commit messages:
- JDK-835: Type in java.lang.reflect.AccessFlag.METHOD_PARAMETER
Changes: https://git.openjdk.org/jdk/pull/14717/files
Webrev:
On Wed, 21 Jun 2023 16:29:40 GMT, Roger Riggs wrote:
>> In java.time packages, clarify timeline order javadoc to mention "before"
>> and "after" in the value of the `compareTo` method return values.
>> Add javadoc @see tags to isBefore and isAfter methods
>>
>> Replace use of "negative" and
Doc-only typo fix.
-
Commit messages:
- Backport 4bce38c6d7792596879a6e1081140b698b899471
Changes: https://git.openjdk.org/jdk21/pull/73/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21=73=00
Issue: https://bugs.openjdk.org/browse/JDK-8310830
Stats: 1 line in 1 file
On Tue, 27 Jun 2023 19:06:26 GMT, Joe Darcy wrote:
> Typo fix. I didn't see any other instances of similar typos in the class.
This pull request has now been integrated.
Changeset: 4bce38c6
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/com
On Tue, 27 Jun 2023 18:56:53 GMT, Jim Laskey wrote:
> The nested class is incorrectly marked as protected.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/72#pullrequestreview-1501665796
Typo fix. I didn't see any other instances of similar typos in the class.
-
Commit messages:
- JDK-8310830: typo in the parameter name in @throws of ClassDesc::ofDescriptor
Changes: https://git.openjdk.org/jdk/pull/14683/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14683=00
On Tue, 20 Jun 2023 20:54:43 GMT, Jens Lidestrom wrote:
> > A positive number is any number that is greater than 0. **Unlike positive
> > integers**, which include 0
>
> math.net seems pretty alone in this. I find the notion bizarre. There seems
> to be an overwhelming majority of sources
On Tue, 27 Jun 2023 16:11:43 GMT, Jim Laskey wrote:
> The nested class is incorrectly marked as protected.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14681#pullrequestreview-1501391798
On Tue, 27 Jun 2023 03:39:30 GMT, Naoto Sato wrote:
>> Replacing the ambiguous `dash` with `hyphen-minus` for more clarity. There
>> are other locations than `ISO_LOCAL_DATE` that have the same description.
>> Those are corrected too.
>
> Naoto Sato has updated the pull request incrementally
On Mon, 26 Jun 2023 13:51:25 GMT, Chen Liang wrote:
>> This patch touches java.lang.reflect and java.lang.invoke packages. It
>> replaces instanceof + cast with pattern matching and updates
>> Array.newInstance().getClass() patterns with arrayType() for obtaining array
>> types of a class.
>
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499215438
On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which adds the `@since` javadoc tag to the
> various ` java.sql `and `java.sql.rowset` packages.
>
> Best
> Lance
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Thu, 22 Jun 2023 00:19:03 GMT, Joe Darcy wrote:
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
This pull request has now been integrated.
Changeset: 0db63ec7
Autho
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the
On Wed, 21 Jun 2023 00:00:54 GMT, Joe Darcy wrote:
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
This pull request has now been integrated.
Changeset: 0314292c
Author: Joe Darcy
URL:
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix another typo and reflow para
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all:
On Fri, 23 Jun 2023 11:58:00 GMT, Pavel Rappo wrote:
>> Thanks for the links, @pavelrappo.
>>
>> I understand the point you're making; however, there is still ambiguous
>> wording in the documentation for this method.
>>
>> The method is called `isPrimitive`, and it returns `true` for
>>
201 - 300 of 754 matches
Mail list logo
