> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes b
On Thu, 22 Jun 2023 10:45:02 GMT, Alan Bateman wrote:
> 8309853: StructuredTaskScope.join description improvements
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/55#pullrequestreview-1493621677
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added t
Small cleanup, minor differences in the wording of portions of toString(Object,
String), nonNull(Object), requireNonNullElse, and requireNonNullElseGet.
-
Commit messages:
- JDK-8310571: Use inline @return tag on java.util.Objects
Changes:
On Wed, 21 Jun 2023 13:00:38 GMT, Alan Bateman wrote:
>> That is, a clear connection to what's being described by that `@implSpec`.
>
> This method has an existing apiNote and implSpec. I suspect Joe meant to add
> this sentence to the apiNote, not the implSpec.
I did mean to add the
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote:
> StructuredTaskScope's class description introduces the join method as waiting
> for all subtasks to finish but the API docs for join/joinUntil are phrased in
> terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil
>
On Wed, 21 Jun 2023 00:13:24 GMT, Chen Liang wrote:
>> Correct misstatement that the Class object for a primitive type can only be
>> be access via fields like java.lang.Integer.TYPE.
>
> src/java.base/share/classes/java/lang/Class.java line 818:
>
>> 816: * they represent, namely {@code
Correct misstatement that the Class object for a primitive type can only be be
access via fields like java.lang.Integer.TYPE.
-
Commit messages:
- Fix whitespace.
- JDK-8310267: Javadoc for Class#isPrimitive() is incorrect regarding Class
objects for primitives
Changes:
I had occasion to read over the javadoc sources in java.lang.Object recently
and noticed a few items that could be updated.
There are some new or expanded API notes referring to methods in
java.util.Objects. I added these references as apiNote items rather than, say,
`@see` tags since `@see`
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote:
> Make `putMode` be a transient field.
I skimmed the JDK-8266571: "Sequenced Collections" and didn't see any similar
instances, but it would benefit from another look.
-
Marked as reviewed by darcy (Reviewer).
PR Review:
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote:
> Time to get JDK 22 underway...
This pull request has now been integrated.
Changeset: 5a706fb4
Author: Joe Darcy
Committer: Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/5a706fb403df0768ecef5b0ce14a3ca389a51efd
St
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 39 commits:
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Update wording to be consistent with
On Wed, 7 Jun 2023 02:45:53 GMT, Joe Darcy wrote:
> Add some basic core reflections tests for unnamed classes.
This pull request has now been integrated.
Changeset: 4ffc8cc2
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/4ffc8cc2169c6b34ce5d9cf0ce98125520c4495a
St
> Add some basic core reflections tests for unnamed classes.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains three additional commits si
Add some basic core reflections tests for unnamed classes.
-
Commit messages:
- JDK-8309574: Improve core reflection tests for JEP 445
Changes: https://git.openjdk.org/jdk/pull/14345/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14345=00
Issue:
On Mon, 5 Jun 2023 01:11:54 GMT, Joe Darcy wrote:
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
This pull request has now been integrated.
Changeset: d82436e4
Author:Joe Darcy
URL:
https://git.openjdk.org/j
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase.
On Tue, 6 Jun 2023 08:41:28 GMT, Alan Bateman wrote:
> > "Latest Java class file format version recognized by the Java runtime as
> > "MAJOR.MINOR" where MAJOR and MINOR are both formatted as decimal integers"
>
> Okay, and linking to ClassFileFormatVersion.latest() is good.
>
> Again, just
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and
> adjust implementations to match.
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Mon, 5 Jun 2023 21:39:49 GMT, Iris Clark wrote:
> The decimal integer should be unsigned and without leading zeros. A regex
> similar to that provided by Runtime.Version would make things clear. I think
> that Mandy's suggestion would be a reasonable alternative as the Java class
> file
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- a
On Fri, 26 May 2023 02:06:55 GMT, Joe Darcy wrote:
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/14165
On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update refle
On Mon, 5 Jun 2023 06:05:14 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two
> Document existing behavior.
>
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase.
Document existing behavior.
Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
-
Commit messages:
- JDK-8309415: Spec Clarification : ClassFileFormatVersion: System property
java.class.version | Java class format version number
Changes:
On Fri, 2 Jun 2023 22:10:44 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the specification for
On Fri, 2 Jun 2023 22:10:44 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the specification for
On Fri, 2 Jun 2023 22:10:44 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the specification for
On Fri, 2 Jun 2023 22:10:44 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the specification for
On Fri, 2 Jun 2023 23:46:57 GMT, Chen Liang wrote:
> Will this accidentally return `true` for classes from other JVM programming
> languages?
That is a potential concern. Future iteration of this work will likely use a
different idiom to determine is-unnamed that would be more robust against
On Fri, 2 Jun 2023 16:44:35 GMT, Mandy Chung wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Cl
On Fri, 26 May 2023 20:37:39 GMT, Joe Darcy wrote:
> > > Looks fine. This version matches the current implementation where
> > > `getCanonicalName` returns non-null. When the implementation of
> > > `getCanonicalName` is updated to return null, the spec s
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update reflective support.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14165/fi
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 29 commits:
- Update symbol files for JDK 21 build 25.
- Merge branch 'master' into JDK-8306584
- Refactor a few more enums.
- Resp
On Wed, 31 May 2023 18:02:09 GMT, Jan Lahoda wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 24 commits:
>>
>> - Merge branch 'master' into JDK-8306584
>> - Merge branch 'master
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 26 commits:
- Respond to review comments.
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Merge bra
On Wed, 31 May 2023 16:40:54 GMT, Daniel D. Daugherty
wrote:
> A couple of trivial ProblemListings:
> [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList
> jdk/incubator/vector/Float64VectorTests.java on aarch64
> [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231)
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 24 commits:
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306
On Tue, 30 May 2023 20:14:59 GMT, Joe Darcy wrote:
>> Ah, when new non-preview language structures are added. With two new
>> language features in JDK 21, looks like it is time for me to add another
>> one; thanks.
>
> Better to fix this omission in JDK 21; please s
On Tue, 23 May 2023 20:49:43 GMT, Joe Darcy wrote:
>> test/langtools/tools/javac/versions/Versions.java line 93:
>>
>>> 91: TWENTY(false,"64.0", "20", Versions::checksrc20),
>>> 92: TWENTY_ONE(false,"65.0", "2
> Time to get JDK 22 underway...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 23 commits:
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Sync in symbol changes for JDK 21 build
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains se
On Sat, 27 May 2023 21:04:51 GMT, Joe Darcy wrote:
> Straightforward doc refactoring to use snippets.
This pull request has now been integrated.
Changeset: 1b8e6bf3
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/1b8e6bf31ccc0eb2db3c26ed2fac2c406eda53be
Stats: 28 li
On Sun, 28 May 2023 18:50:45 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/Class.java line 42
> Straightforward doc refactoring to use snippets.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14194/files
- new: ht
Straightforward doc refactoring to use snippets.
-
Commit messages:
- JDK-8308987: Update java.lang.Class to use javadoc snippets
Changes: https://git.openjdk.org/jdk/pull/14194/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14194=00
Issue:
On Fri, 26 May 2023 13:22:59 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove trailing whitespace
In case I
On Fri, 26 May 2023 17:18:42 GMT, Mandy Chung wrote:
> Looks fine. This version matches the current implementation where
> `getCanonicalName` returns non-null. When the implementation of
> `getCanonicalName` is updated to return null, the spec should be updated.
>
> Nit: `` is needed assuming
On Fri, 26 May 2023 02:06:55 GMT, Joe Darcy wrote:
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
> > Looks fine. This version matches the current implementation where
> > `getCanonicalName` returns non-null. When the implementation of
> &
Explain in java.lang.Class how unnamed classes are modeled in core reflection.
-
Commit messages:
- Cleanup and edit text.
- Respond to review comments.
- Appease jcheck.
- JDK-8308913: Update core reflection for JEP 445 (preview)
Changes:
On Thu, 25 May 2023 14:32:44 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improving error recovery in presence of less
On Wed, 17 May 2023 19:14:20 GMT, Jim Laskey wrote:
> As reported by Marc Hoffman of javaalmanac.io, in a recent JDK 21 build there
> are new public types nested in non-public interfaces:
>
> java.lang.runtime.ReferenceKey.SoftKey
> java.lang.runtime.ReferenceKey.StrongKey
>
On Wed, 24 May 2023 18:36:39 GMT, Justin Lu wrote:
> > I just wonder if it is ok to reverse the rounding/truncation only in this
> > special case. If the truncation always comes first, then 0.00 would be
> > correct (then 1.01 may be something wrong). Looks to me that the original
> > comment
On Tue, 23 May 2023 23:16:01 GMT, Justin Lu wrote:
> Please review this PR, which addresses a case where Decimal Format would
> violate certain RoundingMode contracts given the right pattern and double.
>
> For example,
>
>
> DecimalFormat df = new DecimalFormat();
>
On Tue, 23 May 2023 20:38:34 GMT, Jonathan Gibbons wrote:
>> Time to get JDK 22 underway...
>
> test/langtools/tools/javac/versions/Versions.java line 93:
>
>> 91: TWENTY(false,"64.0", "20", Versions::checksrc20),
>> 92: TWENTY_ONE(false,"65.0", "21", Versions::checksrc20),
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote:
> Time to get JDK 22 underway...
Typical start-of-JDK-next changes. As usual, the bulk of the PR is the symbol
file information to support "javac --release 21".
-
PR Comment: https://git.openjdk.org/jdk/pull/13567
Time to get JDK 22 underway...
-
Commit messages:
- Merge branch 'master' into JDK-8306584
- Merge branch 'master' into JDK-8306584
- Minor test fixes.
- Merge branch 'master' into JDK-8306584
- Update symbol files to JDK 21 b23.
- Merge branch 'JDK-8306584' of
On Mon, 22 May 2023 10:22:16 GMT, Volker Simonis wrote:
>> Since JDK13, executing commands in a sub-process defaults to the so called
>> `POSIX_SPAWN` launching mechanism (i.e.
>> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
>> using `posix_spawn(3)` to firstly
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All redundant use of
On Wed, 17 May 2023 14:42:45 GMT, Roger Riggs wrote:
> > Should this issue have a CSR for any behavioral changes?
>
> Well, you can certainly argue that every bug fix is a behavioral changes,
> right :)
>
> But seriously, I don't see how this PR could require a CSR. The only
> behavioral
On 5/17/2023 7:07 AM, Ethan McCue wrote:
> if they have setup their projects correctly.
Can you be more clear about what "setup their projects correctly"
means? If you are referring to usage of --release, you seem to be
making a pretty strong argument that this will not be the case.
Use
On Tue, 16 May 2023 21:35:14 GMT, Joe Darcy wrote:
> Tightening up accessibility of a few nested classes. There is no practical
> impact on source compatibility -- source uses within the package still work,
> but by default the ability to reflectively call methods on thes
Tightening up accessibility of a few nested classes. There is no practical
impact on source compatibility -- source uses within the package still work,
but by default the ability to reflectively call methods on these classes is
disabled.
-
Commit messages:
- JDK-8308239: Tighten
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize
On Sun, 14 May 2023 23:00:14 GMT, Joe Darcy wrote:
> Make the nested classes inside FdLibm.java consistently package-access,
> static and final.
This pull request has now been integrated.
Changeset: 7b0b9b57
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start
Make the nested classes inside FdLibm.java consistently package-access, static
and final.
-
Commit messages:
- JDK-8308049: Refactor nested class declarations in FdLibm.java
Changes: https://git.openjdk.org/jdk/pull/13972/files
Webrev:
On Tue, 9 May 2023 12:58:27 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Thu, 27 Apr 2023 17:21:23 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Thu, 27 Apr 2023 17:21:23 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote:
> Trivial fixes to ProblemList a few tests:
> - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList
> jdk/incubator/vector/LoadJsvmlTest.java on windows-x64
> -
in this patch)
>>
>> `ParameterMappingTest` covers these scenarios with class files that have
>> `MethodParameters` or `Signature` attributes stripped or preserved to ensure
>> the new Reflection API implementation works for both class files generated
>> b
On Wed, 26 Apr 2023 08:30:07 GMT, Raffaello Giulietti
wrote:
> No, that would not be correct. It would be subject to [double
> rounding](https://en.wikipedia.org/wiki/Rounding#Double_rounding), against
> the spec.
>
> For example, `BigDecimal` 1.00059604644775390626 should round to
On Thu, 27 Apr 2023 13:17:58 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> PreviewFeatures.isEnabled()
I assume future
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
src/java.base/share/classes/java/math/BigDecimal.java line 308:
>
On Sat, 25 Mar 2023 05:52:44 GMT, Chen Liang wrote:
> In `AnnotatedTypeBaseImpl`, a `decl` field is declared, referring to the
> declaration that the AnnotatedType is from. However, this field is not used
> anywhere except passing to constructors of other implementations; it's not
> used in
On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy wrote:
> Minor refactoring of FdLibm.java; will consider future refactorings with more
> substantive code changes in the future.
This pull request has now been integrated.
Changeset: d819deba
Author: Joe Darcy
URL:
https://git.openj
On Mon, 24 Apr 2023 19:28:41 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in
> Xcomp.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13627#pullrequestreview-1398673003
On Mon, 24 Apr 2023 12:00:58 GMT, Raffaello Giulietti
wrote:
>> Minor refactoring of FdLibm.java; will consider future refactorings with
>> more substantive code changes in the future.
>
> src/java.base/share/classes/java/lang/FdLibm.java line 76:
>
>> 74: private static final int
Minor refactoring of FdLibm.java; will consider future refactorings with more
substantive code changes in the future.
-
Commit messages:
- JDK-8304423: Refactor Fdlibm.java
Changes: https://git.openjdk.org/jdk/pull/13604/files
Webrev:
On Wed, 19 Apr 2023 17:04:07 GMT, Joe Darcy wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length
On Wed, 19 Apr 2023 16:47:33 GMT, Volker Simonis wrote:
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream.
On Tue, 18 Apr 2023 07:27:47 GMT, Doug Simon wrote:
>> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for
>> accessing annotations. The main differences from
>> `java.lang.reflect.AnnotatedElement` are:
>> * All methods in the `Annotated` interface explicitly specify requested
On Mon, 17 Apr 2023 20:46:36 GMT, Doug Simon wrote:
> > From the long-term perspective, it is likely that the set of kinds of
> > elements that can occur in an annotation will be expanded, for example,
> > method references are a repeated request. Easing future maintenance to
> > gives more
On Mon, 17 Apr 2023 20:33:30 GMT, Doug Simon wrote:
>> src/java.base/share/classes/jdk/internal/vm/VMSupport.java line 234:
>>
>>> 232: * Encodes a list of annotations to a byte array. The byte array
>>> can be decoded with {@link #decodeAnnotations(byte[], AnnotationDecoder)}.
>>> 233:
On Fri, 17 Mar 2023 15:38:49 GMT, Doug Simon wrote:
>> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for
>> accessing annotations. The main differences from
>> `java.lang.reflect.AnnotatedElement` are:
>> * All methods in the `Annotated` interface explicitly specify requested
On Fri, 17 Mar 2023 15:38:49 GMT, Doug Simon wrote:
>> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for
>> accessing annotations. The main differences from
>> `java.lang.reflect.AnnotatedElement` are:
>> * All methods in the `Annotated` interface explicitly specify requested
On Fri, 17 Mar 2023 15:38:49 GMT, Doug Simon wrote:
>> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for
>> accessing annotations. The main differences from
>> `java.lang.reflect.AnnotatedElement` are:
>> * All methods in the `Annotated` interface explicitly specify requested
On Fri, 17 Mar 2023 15:38:49 GMT, Doug Simon wrote:
>> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for
>> accessing annotations. The main differences from
>> `java.lang.reflect.AnnotatedElement` are:
>> * All methods in the `Annotated` interface explicitly specify requested
On Tue, 4 Apr 2023 13:25:44 GMT, Raffaello Giulietti
wrote:
> A fix for the issue and additional specific tests.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13326#pullrequestreview-1371418773
On Sat, 1 Apr 2023 18:08:44 GMT, Joe Darcy wrote:
> This PR is a redo of JDK-8302801: Remove fdlibm C sources. The problem with
> JDK-8302801 was that it neglected (mea culpa) to include a Java
> implementation of IEEEremainder before the FDLIBM C implementation was
On Sat, 1 Apr 2023 17:34:37 GMT, Joe Darcy wrote:
> The StringBuilder and StringBuffer classes are Appendable by virtue of from
> subclasses their non-public superclass AbstractStringBuilder.
>
> It is slightly clearer to declare StringBuilder and StringBuffer to directly
On Sun, 2 Apr 2023 07:45:23 GMT, Sergey Tsypanov wrote:
>> The StringBuilder and StringBuffer classes are Appendable by virtue of from
>> subclasses their non-public superclass AbstractStringBuilder.
>>
>> It is slightly clearer to declare StringBuilder and StringBuffer to directly
>>
The StringBuilder and StringBuffer classes are Appendable by virtue of from
subclasses their non-public superclass AbstractStringBuilder.
It is slightly clearer to declare StringBuilder and StringBuffer to directly
implement Appendable, as they already directly implement the CharSequence
This PR is a redo of JDK-8302801: Remove fdlibm C sources. The problem with
JDK-8302801 was that it neglected (mea culpa) to include a Java implementation
of IEEEremainder before the FDLIBM C implementation was deleted. Such an
implementation has been successfully provided under JDK-8304028:
On Sun, 2 Apr 2023 06:45:30 GMT, Alan Bateman wrote:
> Right now, the javadoc for SB lists Appendable in the "All Implemented
> Interfaces" list. With this change it will be shown in the class declaration
> in the list of "implements" list. Make sense.
Correct; after the change, the
On Tue, 21 Mar 2023 06:11:57 GMT, Joe Darcy wrote:
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to
> write some more implementation-specific tests around decision points in the
> FDLIBM algorithm, but I wanted to get the bulk of the changes out f
ugh 3 were successful (other than an unrelated
> test failure that was problem listed) and the exhaustive test was locally run
> and passed with "16, 16" to increase the testing density.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The
301 - 400 of 754 matches
Mail list logo
