On Fri, 24 May 2024 16:36:32 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from
On Thu, 16 May 2024 18:53:40 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from
On Wed, 1 May 2024 20:35:10 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 20:12:33 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 75:
>
>> 73: } catch
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 16:10:06 GMT, Justin Lu wrote:
> Please review this PR which converts _TestEncodingDecodingLength.java_ into a
> whitebox test which allows for testing to be done without memory usage issues.
>
> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
>
On Fri, 26 Apr 2024 20:33:33 GMT, Archie Cobbs wrote:
> > Is there any chance of backporting this to java 17 or 21? What's involved
> > in doing that?
>
> It's a straightforward process but I'm not sure I'm one to judge whether it
> would be appropriate.
>
> @jaikiran and/or @LanceAndersen -
On Tue, 23 Apr 2024 09:32:40 GMT, Jin Kwon wrote:
>> Fix typos within the `DatabaseMetaData.java`.
>
> Jin Kwon has updated the pull request incrementally with one additional
> commit since the last revision:
>
> [JDK-8330686] Update copyright year
Marked as reviewed by lancea (Reviewer).
On Tue, 23 Apr 2024 18:57:44 GMT, Sean Mullan wrote:
> A few other comments/questions:
>
> Does this need a CSR since you are adding new property files?
Not sure it does, but Joe will follow up with Joe Darcy
>
> Are there any tests to ensure the property files are working correctly?
There
On Fri, 19 Apr 2024 21:55:09 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>> jaxp-compat.properties: used to regain compatibility from any
On Fri, 19 Apr 2024 17:39:30 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>> jaxp-compat.properties: used to regain compatibility from any
On Wed, 17 Apr 2024 23:24:06 GMT, Joe Wang wrote:
> Add two sample configuration files:
>
> jaxp-strict.properties: used to set strict configuration, stricter than
> jaxp.properties in previous versions such as JDK 22
>
> jaxp-compat.properties: used to regain compatibility from any more
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1983860994
#pminborg
[2]
https://github.com/openjdk/jdk/commit/cbccc4c8172797ea2f1b7c301d00add3f517546d
[3]
https://github.com/search?q=repo%3Aopenjdk%2Fjdk+author%3Aminborg=commits
[4] https://openjdk.org/census#core-libs
[5] https://openjdk.org/groups/#member-vote
[oracle_sig_logo.gif]
Lance Andersen
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote:
> A simple doc update to include a leap day example in the `Calendar` class.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18158#pullrequestreview-1923575615
On Sat, 3 Feb 2024 17:28:29 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
>> to `ZipEntry.externalAttributes`.
>>
>> This field was introduced in
>> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
>> the
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote:
>> Fixing test cases. For bad test cases, only the first case was run, and the
>> rest were ignored.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflects review
On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which suggests we remove the package-private,
> unused and deprecated method `java.util.jar.Manifest.make72Safe`.
>
> This method was marked deprecated after a cleanup/refactoring in
>
On Sat, 2 Mar 2024 18:51:16 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes that we officially deprecate the
>> following four methods in the `java.util.zip` package:
>>
>> * `Inflater.getTotalIn()`
>> * `Inflater.getTotalOut()`
>> * `Deflater.getTotalIn()`
>> *
On Fri, 1 Mar 2024 18:02:24 GMT, Joe Wang wrote:
>> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve
>> property. Also slightly improved the error msg with the catalog name.
>>
>> Test: new test added
>> existing test CatalogSupport5 would fail without the
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote:
> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve
> property. Also slightly improved the error msg with the catalog name.
>
> Test: new test added
> existing test CatalogSupport5 would fail without the Null
s?
(a) Do nothing
(b) Just fix the tag @deprecation -> @deprecated
(c) Fix the tag, add forRemoval=true
(d) Just delete the method altogether (it's internal after all).
Cheers,
Eirik.
[oracle_sig_logo.gif]
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037
Oracle Java
On Mon, 26 Feb 2024 19:55:47 GMT, Lance Andersen wrote:
> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
> module summary so that it is consistent with the use of "ZIP".
>
> In addition, open/src/java.base/share/classes/java/util/zip/package
On Wed, 28 Feb 2024 14:03:58 GMT, Jaikiran Pai wrote:
> GitHub doesn't allow me to comment on unchanged lines in the PR, but while
> reviewing this I noticed 2 things:
>
> * It looks like http://www.pkware.com/documents/casestudies/APPNOTE.TXT is
> now auto redirecting to
>
On Wed, 28 Feb 2024 13:58:01 GMT, Jaikiran Pai wrote:
> Hello Lance, this doc-only change looks good to me.
>
> These changes are merely changing the case of `zip` and aren't changing any
> specification of the APIs and that looks fine to me.
>
> I had imagined that we would be changing only
On Wed, 28 Feb 2024 14:13:57 GMT, Guoxiong Li wrote:
> I search the package `java.util.zip` and find several `zip64` in the file
>
On Tue, 16 Jan 2024 16:38:34 GMT, Glavo wrote:
>> Using `ByteArrayLittleEndian` is simpler and faster.
>>
>> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>>
>>
>> Benchmark (size) Mode Cnt Score Error
>> Units
>> - ZipFileOpen.openCloseZipFile
On Wed, 28 Feb 2024 09:19:20 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes that we officially deprecate the
>> following four methods in the `java.util.zip` package:
>>
>> * `Inflater.getTotalIn()`
>> * `Inflater.getTotalOut()`
>> * `Deflater.getTotalIn()`
>> *
On Tue, 27 Feb 2024 20:01:30 GMT, Eirik Bjørsnøs wrote:
> After some offline discussion about the redundant text, we decided to keep to
> the new method description text, but reduce the `@deprecated` note to simply
> refer to the replacement method:
>
> ```
> /**
> * Returns the total number
el location of the PKWARE
> APPNOTE.TXT has PKWare recently changed the direct path the the latest
> version of the spec.
>
> It is also worth noting that error messages were not updated as part of the
> PR and will be updated separately to keep the javadoc changes separate
Lan
On Tue, 27 Feb 2024 16:12:03 GMT, Lance Andersen wrote:
>> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
>> module summary so that it is consistent with the use of "ZIP".
>>
>> In addition,
>> open/src/java.base/share/cla
On Tue, 27 Feb 2024 15:08:11 GMT, Eirik Bjørsnøs wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address initial feedback for JDK-8326687
>
> src/java.base/share/classes/java/util
This PR updates the javadoc and comments within java.util.zip/jar and zipfs
module summary so that it is consistent with the use of "ZIP".
In addition, open/src/java.base/share/classes/java/util/zip/package-info.java
has been updated to point to the higher level location of the PKWARE
On Mon, 26 Feb 2024 14:29:19 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes that we officially deprecate the
>> following four methods in the `java.util.zip` package:
>>
>> * `Inflater.getTotalIn()`
>> * `Inflater.getTotalOut()`
>> * `Deflater.getTotalIn()`
>> *
On Sat, 24 Feb 2024 14:56:01 GMT, Lance Andersen wrote:
> Please review this PR which addresses the handling of invalid UTF-8 byte
> sequences in the entry name of a LOC file header and a Zip file comment which
> is returned via ZipFile::getComment.
>
> As part of the c
On Sun, 25 Feb 2024 15:26:35 GMT, Alan Bateman wrote:
> (In passing, the casing of "zip file" is very inconsistent in the javadoc,
> it's "ZIP file" in some places, "zip file" in others, the change here uses
> "Zip file").
Thank you for pointing out the discrepancy above.
Let's decide on
On Sun, 25 Feb 2024 12:20:36 GMT, Eirik Bjørsnøs wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates based on 1st round of feedback
>
> src/java.base/share/classes/java/util/zi
invalid UTF-8 byte sequence is encountered while converting the byte array to
> a String. The CSR for this change has also been approved.
>
> Mach5 tiers 1-3 are clean with this change.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last
On Sun, 25 Feb 2024 12:16:14 GMT, Jaikiran Pai wrote:
> Hello Lance, the changes look fine to me. `ZipFile.java` file will need a
> copyright year update.
Thank you Jai, updated
> test/jdk/java/util/zip/ZipFile/InvalidBytesInEntryNameOrComment.java line 189:
>
>> 187: try (ZipFile zf
On Sat, 24 Feb 2024 18:54:07 GMT, Lance Andersen wrote:
>> Please review this PR which addresses the handling of invalid UTF-8 byte
>> sequences in the entry name of a LOC file header and a Zip file comment
>> which is returned via ZipFile::getComment.
>>
>> A
On Sat, 24 Feb 2024 17:15:02 GMT, Eirik Bjørsnøs wrote:
> Since the CSR is already approved, I'll add a question here:
>
> `ZipFile` performs a lot of validation while opening ZIP files, including
> throwning ZipException for invalid entry names or comments. Why handle the
> ZIP file comment
On Sat, 24 Feb 2024 16:57:50 GMT, Eirik Bjørsnøs wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates based on 1st round of feedback
>
> src/java.base/share/classes/java/
On Sat, 24 Feb 2024 18:51:22 GMT, Lance Andersen wrote:
>> Please review this PR which addresses the handling of invalid UTF-8 byte
>> sequences in the entry name of a LOC file header and a Zip file comment
>> which is returned via ZipFile::getComment.
>>
>> A
invalid UTF-8 byte sequence is encountered while converting the byte array to
> a String. The CSR for this change has also been approved.
>
> Mach5 tiers 1-3 are clean with this change.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last
Please review this PR which addresses the handling of invalid UTF-8 byte
sequences in the entry name of a LOC file header and a Zip file comment which
is returned via ZipFile::getComment.
As part of the change, `ZipFile::getComment` will now return `null` if an
invalid UTF-8 byte sequence is
On Thu, 22 Feb 2024 09:49:31 GMT, Jaikiran Pai wrote:
> Can I get a review of this change which proposes to remove the `SystemTest`
> from among the `JSR166TestCase`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8278527 the
> `SystemTest.nanoTime` test has been intermittently failing
On Tue, 20 Feb 2024 19:56:53 GMT, Lance Andersen wrote:
> Please review the updates to open/src/java.base/share/legal/zlib.md to update
> the file from zlib 1.2.13 to zlib 1.3.1 which was missed as part of the PR
> for [JDK-8324632](https://bugs.openjdk.org/browse/JDK-8324632)
Please review the updates to open/src/java.base/share/legal/zlib.md to update
the file from zlib 1.2.13 to zlib 1.3.1 which was missed as part of the PR for
[JDK-8324632](https://bugs.openjdk.org/browse/JDK-8324632)
-
Commit messages:
- Update zlib.md for zlib 1.3.1
Changes:
On Tue, 20 Feb 2024 18:34:59 GMT, Naoto Sato wrote:
> Fixing a typo in the said method.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17933#pullrequestreview-1891265805
Vote: yes
On 2/19/24 3:40 PM, Stuart Marks wrote:
> I hereby nominate Viktor Klang [6] to Membership in the Core Libraries Group
> [4].
> Viktor has been a member of the Java team in Oracle since 2022, and he is
> currently a Committer on the JDK project. Viktor has led JEP 461 [1], an
>
For Lazy Consensus voting instructions, see [2].
Brian Burkhalter
[1] https://openjdk.org/census#core-libs
[2] https://openjdk.org/groups/#member-vote
[oracle_sig_logo.gif]
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
On Mon, 5 Feb 2024 13:14:39 GMT, Eirik Bjørsnøs wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data
On Fri, 9 Feb 2024 12:31:27 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
>> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
>> tested.
>>
>> The disk space requirement of this test is known to cause
On Fri, 9 Feb 2024 10:33:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests we speed up the `Zip64SizeTest` using a
>> small-sized ZIP64 ZIP file specifically created to reproduce the issue being
>> tested.
>>
>> The disk space requirement of this test is known to cause
On Wed, 7 Feb 2024 12:37:23 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>>
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the
On Tue, 6 Feb 2024 10:31:06 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>>
On Fri, 2 Feb 2024 21:20:29 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to fix to a regression in ZipFileSystem, introduced by
>> JDK-8322565 in PR #17170.
>>
>> When `Files.setPosixFilePermissions` is called on an existing MSDOS entry,
>> then `Entry.posixPerms` field will be -1 (all
On Fri, 2 Feb 2024 21:17:48 GMT, Eirik Bjørsnøs wrote:
>> test/jdk/jdk/nio/zipfs/TestPosix.java line 757:
>>
>>> 755: try (FileSystem fs = FileSystems.newFileSystem(ZIP_FILE,
>>> ENV_POSIX)) {
>>> 756: Path path = fs.getPath("hello.txt");
>>> 757:
On Fri, 2 Feb 2024 20:19:51 GMT, Eirik Bjørsnøs wrote:
> > I think the change is OK, any reason to not make it
> > `externalFileAttributes`?
>
> None other than length / verbosity. But since this refers to the _attributes
> of the external file_, dropping any name element also loses some
On Wed, 24 Jan 2024 10:28:46 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests we retire the ZIP test
>> `NoExtensionSignature` along with its `test.jar` test vector.
>>
>> The concern of a missing data descriptor signature is covered by the
>> recently updated
On Mon, 22 Jan 2024 13:58:00 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
On Wed, 24 Jan 2024 14:34:03 GMT, Eirik Bjørsnøs wrote:
> Please review this PR to fix to a regression in ZipFileSystem, introduced by
> JDK-8322565 in PR #17170.
>
> When `Files.setPosixFilePermissions` is called on an existing MSDOS entry,
> then `Entry.posixPerms` field will be -1 (all 1s
On Tue, 30 Jan 2024 16:17:13 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
>> to `ZipEntry.externalAttributes`.
>>
>> This field was introduced in
>> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
>>
On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib) has
> released Zlib 1.3.1 on January 24, 2024.
>
> T
On Mon, 29 Jan 2024 17:15:25 GMT, Alan Bateman wrote:
> @LanceAndersen Can you confirm that there are no changes to the 1.3..1.3.1
> diffs?
@AlanBateman, yes that is correct, there are no OpenJDK specific changes, it is
a straight port of the zlib 1.3.1 changes to our implementation
Hi all,
Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
The [Zlib Data Compression Library](https://github.com/madler/zlib) has
released Zlib 1.3.1 on January 24, 2024.
There are a [small number of
updates](https://github.com/madler/zlib/compare/v1.3.1..v1.3) between 1.3
On Fri, 26 Jan 2024 14:34:39 GMT, Eirik Bjørsnøs wrote:
> To help make progress here, I have relaxed the validation such that we now
> check:
>
> * That the "streaming mode" bit 3 flag is set
> * That at least one of the LOC's size fields are marked 0x.
> * That the LOC extra field has
On Mon, 22 Jan 2024 20:52:32 GMT, Roger Riggs wrote:
> When an exception handler for an OutOfMemoryError uses string concatenation
> to compose an exception message, the invoke dynamic string format
> implementation may itself exhaust memory, preventing the exception from being
> handled.
>
On Mon, 22 Jan 2024 14:34:25 GMT, Eirik Bjørsnøs wrote:
> @LanceAndersen Do you have a cent or two to spare?
Let me try and dig out from a couple of things and circle back to this again
-
PR Review Comment: https://git.openjdk.org/jdk/pull/12524#discussion_r1462519461
On Mon, 15 Jan 2024 10:26:53 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote:
> Fix a regression in the source resolution process where it failed to
> recognize a custom InputSource when both the public and system IDs are null.
> The particular issue is fixed at line 1233, the rest of the changes is
> formatting to make
On Tue, 9 Jan 2024 07:29:49 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests we retire the binary test vectors `ZipFile/input.zip`,
>> `ZipFile/input.jar` and `ZipFile/crash.jar`
>>
>> Binary test vectors are harder to analyze, and sharing test vectors across
>> unrelated tests increases
On Fri, 15 Dec 2023 11:15:30 GMT, Lance Andersen wrote:
>> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I
>> think it makes sense to include it in this PR, convert it to JUnit and move
>> it into `ReadZip.readAfterClose`.
>>
>> T
On Wed, 10 Jan 2024 18:29:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
On Wed, 20 Dec 2023 18:51:08 GMT, Eirik Bjørsnøs wrote:
> This PR suggests that `Files.setPosixPermissions`as implemented by
> `ZipFileSystem` should preserve the leading seven bits of the 'external file
> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
> and
On Tue, 2 Jan 2024 13:31:01 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests we retire the binary test vectors `ZipFile/input.zip`,
>> `ZipFile/input.jar` and `ZipFile/crash.jar`
>>
>> Binary test vectors are harder to analyze, and sharing test vectors across
>> unrelated tests increases
On Thu, 14 Dec 2023 14:55:08 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests we retire the binary test vectors `ZipFile/input.zip`,
>> `ZipFile/input.jar` and `ZipFile/crash.jar`
>>
>> Binary test vectors are harder to analyze, and sharing test vectors across
>> unrelated tests increases
On Wed, 3 Jan 2024 19:31:16 GMT, Joe Wang wrote:
> Fix the get (return) operation by using the same method as that used for
> checking the values of the DTD features during the resolution process.
>
> Note: this patch also addresses the issue reported in
>
On Tue, 2 Jan 2024 17:50:51 GMT, Eirik Bjørsnøs wrote:
>> Please review this test-only PR which adds test coverage for
>> `ZipFile.getEntry` under certain charset conditions.
>>
>> When `ZipFile.getEntry` is called for an entry which has the `Language
>> encoding flag` general purpose bit
On Tue, 2 Jan 2024 09:31:16 GMT, Eirik Bjørsnøs wrote:
>> Please review this test-only PR which adds test coverage for
>> `ZipFile.getEntry` under certain charset conditions.
>>
>> When `ZipFile.getEntry` is called for an entry which has the `Language
>> encoding flag` general purpose bit
On Sun, 31 Dec 2023 18:07:33 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which adds test coverage for
> `ZipFile.getEntry` under certain charset conditions.
>
> When `ZipFile.getEntry` is called for an entry which has the `Language
> encoding flag` general purpose bit flag
On Wed, 20 Dec 2023 15:37:37 GMT, Sean Coffey wrote:
> trivial test edit to use FileUtils.deleteFileIfExistsWithRetry test library
> API
>
> tested on CI system with test-repeat = 20 - no issues seen.
Hi Sean,
Thank you for tackling this.
Would it be beneficial to use a try-with-resources
On Thu, 14 Dec 2023 15:00:15 GMT, Eirik Bjorsnos wrote:
> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I
> think it makes sense to include it in this PR, convert it to JUnit and move
> it into `ReadZip.readAfterClose`.
>
> This removes the last remaining binary
On Thu, 14 Dec 2023 10:13:31 GMT, Eirik Bjorsnos wrote:
> The scope of this PR has now expanded to removing uses of the `input.zip` and
> `input.jar` files, updating any test using them to produce their own test
> vectors, and convert affected tests to JUnit.
>
> I'm marking the PR ready for
On Wed, 13 Dec 2023 21:19:34 GMT, Joe Wang wrote:
>> One of the three `XMLStreamException` constructors that takes a `Throwable`
>> fails to pass it to the superclass constructor.
>>
>> This simple patch fixes that omission.
>>
>> It's worth considering if there is any code out there that is
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780488559
ned in the standard
cited by the package info page, so I don’t see the harm in making it accessible
without interpretation.
Alan
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Networ
On Tue, 12 Dec 2023 11:59:36 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which adds validation of incorrect LOC signatures in
>> `ZipFileSystem`.
>>
>> `ZipFile` already rejects the case where the offset pointed to from the CEN
>> header does not start with the expected LOC
On Mon, 11 Dec 2023 15:38:28 GMT, Eirik Bjorsnos wrote:
> Please review this PR which adds validation of incorrect LOC signatures in
> `ZipFileSystem`.
>
> `ZipFile` already rejects the case where the offset pointed to from the CEN
> header does not start with the expected LOC signature. It
On Mon, 11 Dec 2023 17:22:14 GMT, Eirik Bjorsnos wrote:
> > One quick comment, if we are updating this test, we should look to get rid
> > of input.zip
>
> I started going down that road, but felt uneasy about the amount of unrelated
> changes in a single PR. I'd like to make efficient use of
On Fri, 8 Dec 2023 20:28:20 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests we rewrite the
> `../zip/ZipFile/ReadZip.java` test to JUnit.
>
> The current test is a single main method with a sequence of fairly unrelated
> scenarios. It would benefit from a rewrite to
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP
On Tue, 5 Dec 2023 15:58:14 GMT, Eirik Bjorsnos wrote:
> Please review this PR which suggests we retire the ZIP test
> `NoExtensionSignature` along with its `test.jar` test vector.
>
> The concern of a missing data descriptor signature is covered by the recently
> updated
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Mon, 4 Dec 2023 15:34:34 GMT, Eirik Bjorsnos wrote:
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name
On Fri, 1 Dec 2023 08:49:34 GMT, Alan Bateman wrote:
>> Thanks Jai, that makes sense. Replaced full path with just the base name in
>> latest commit.
>
> I think the second paragraph of the method description is problematic.
> Documenting the representation and then saying it is subject to
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1755023783
On Tue, 28 Nov 2023 20:49:38 GMT, Justin Lu wrote:
>> Please review this PR which converts the shell test,
>> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>>
>> This test is a test runner that launches test methods from
>> _PropertiesTest.java_. It tests both the ways to
1 - 100 of 566 matches
Mail list logo
