Or use extended Grapheme Cluster boundary "\\b{g}" instead of "\\b".
This will correctly search emoji sequences such as , while
"\\b" with Unicode option won't.
HTH,
Naoto
On 12/15/23 11:29 AM, Stefan Norberg wrote:
Thanks Raffaello,
Ah, thanks! Found
. It is also the intention of
> this PR to clarify those system properties and how they are overridden. A
> corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
On Fri, 15 Dec 2023 20:39:47 GMT, Brent Christian wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/Locale.java lin
On Fri, 15 Dec 2023 17:41:43 GMT, Naoto Sato wrote:
> 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are
> incorrect
This pull request has now been integrated.
Changeset: 57d97b52
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk22/
8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are
incorrect
-
Commit messages:
- Backport 87ef73329f66e898d85eecea94a4104a13b3a2db
Changes: https://git.openjdk.org/jdk22/pull/16/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22=16=00
Issue:
On Wed, 13 Dec 2023 23:10:05 GMT, Naoto Sato wrote:
> Small document correction on a return description.
This pull request has now been integrated.
Changeset: 87ef7332
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/87ef73329f66e898d85eecea94a4104a13b3a2db
Stats:
On Thu, 14 Dec 2023 17:08:02 GMT, Naoto Sato wrote:
>> Small document correction on a return description.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected @param description
T
On Thu, 14 Dec 2023 21:27:06 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/Locale.java line 264
. It is also the intention of
> this PR to clarify those system properties and how they are overridden. A
> corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties
line 111:
> 109: doclet.Factory=ファクトリ:
> 110: doclet.UnknownTag=不明なタグ。未登録のカスタム・タグ?
> 111:
> Small document correction on a return description.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Corrected @param description
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17098/files
- new: ht
On Thu, 14 Dec 2023 09:32:23 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected @param description
>
> src/java.base/share/classes/java/time/zone/Zone
Small document correction on a return description.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/17098/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17098=00
Issue: https://bugs.openjdk.org/browse/JDK-8321958
Stats: 2 lines in 1 file
On Wed, 13 Dec 2023 21:25:13 GMT, Jorn Vernee wrote:
>> Right, I suggested putting that in parentheses. Historically we haven't been
>> very formal about distinguishing between normative (Java SE) specifications
>> and informative text that talks about implementations. In this case I felt
>>
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780499321
. It is also the intention of
> this PR to clarify those system properties and how they are overridden. A
> corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
On Wed, 13 Dec 2023 18:33:13 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/Locale.java line 317
On Mon, 11 Dec 2023 23:20:25 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the
. It is also the intention of
> this PR to clarify those system properties and how they are overridden. A
> corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
On Mon, 11 Dec 2023 22:15:42 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
>> As the replacement of `ANG` to `XCG` won't occur until 2025, this change
>> does not need to go into JDK22. `HR` was also updated to remove the past
>> cutover
On Thu, 7 Dec 2023 22:15:51 GMT, Justin Lu wrote:
>> Please review this PR which updates an incorrect code example in
>> _java/text/ChoiceFormat_.
>>
>> ChoiceFormat (and MessageFormat) provide an example of how to produce a
>> pattern that supports singular and plural forms. The ChoiceFormat
On Mon, 11 Dec 2023 22:04:23 GMT, Justin Lu wrote:
>> make/jdk/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java
>> line 347:
>>
>>> 345: // otherwise it will leak out into
>>> Currency:getAvailableCurrencies
>>> 346: boolean notFutureCurrency =
On Mon, 11 Dec 2023 22:06:58 GMT, Justin Lu wrote:
>> IIUC, this should have happened before, as a currency update like "XXA" ->
>> "XXB" on a future date is pretty usual. I think this issue was simply not
>> discovered by any users till now.
>
> I think this wasn't discovered/hasn't failed
. It is also the intention of
> this PR to clarify those system properties and how they are overridden. A
> corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Chang
On Mon, 11 Dec 2023 22:42:56 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/java.base/share/classes/java/util/Locale.java line 270:
>
. It is also the intention of
> this PR to clarify those system properties and how they are overridden. A
> corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with four additional
commits since the last revision:
- Update src/java.base/share/classes/jav
On Mon, 11 Dec 2023 03:03:44 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
>> As the replacement of `ANG` to `XCG` won't occur until 2025, this change
>> does not need to go into JDK22. `HR` was also updated to remove the past
>> cutover
On Mon, 11 Dec 2023 02:59:02 GMT, Justin Lu wrote:
>> test/jdk/java/util/Currency/ValidateISO4217.java line 181:
>>
>>> 179: // without updating ISO4217Codes
>>> 180: String futureCurr = tokens.nextToken();
>>> 181:
>>>
This is a doc change to clarify what the `Default Locale` is, and how it is
established during the system startup using the system properties. Those
locale-related system properties have existed since the early days of Java, but
have never been publicly documented before. It is also the
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class
On Tue, 5 Dec 2023 23:04:55 GMT, Naoto Sato wrote:
> Currently, Locale-related system properties, such as `user.language` or
> `user.country`, are initialized when the `Locale` class is loaded. Making
> them static properties is safer than relying on the `Locale` class loading
> t
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class
On Thu, 7 Dec 2023 19:43:14 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
> As the replacement of `ANG` to `XCG` won't occur until 2025, this change does
> not need to go into JDK22. `HR` was also updated to remove the past cutover
>
On Wed, 6 Dec 2023 21:12:40 GMT, Naoto Sato wrote:
> This is an additional fix to JDK-8321131, where more clearing is required in
> JLine.
This pull request has now been integrated.
Changeset: 4ed38f5a
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/
This is an additional fix to JDK-8321131, where more clearing is required in
JLine.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/17004/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17004=00
Issue:
ed depending on the implementation.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four additional commits since
the last revision:
- Reflects rev
On Wed, 6 Dec 2023 18:10:05 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 415:
>>
>>> 413: public static String userRegion() {
>>> 414: return USER_REGION;
>>> 415: }
>>
>
On Wed, 6 Dec 2023 15:18:27 GMT, Roger Riggs wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class loading
>> timing,
On Wed, 6 Dec 2023 15:27:48 GMT, Roger Riggs wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class loading
>> timing,
On Wed, 6 Dec 2023 08:14:05 GMT, Alan Bateman wrote:
>> Currently, Locale-related system properties, such as `user.language` or
>> `user.country`, are initialized when the `Locale` class is loaded. Making
>> them static properties is safer than relying on the `Locale` class loading
>> timing,
On Wed, 6 Dec 2023 02:14:13 GMT, David Holmes wrote:
> I'm not following the changes to cdsHeapVerifier.cpp. You've marked the new
> entries as `C` but the definition is:
>
> ```
> // [C] A non-final static string that is assigned a string literal during
> class
> // initialization; this
Currently, Locale-related system properties, such as `user.language` or
`user.country`, are initialized when the `Locale` class is loaded. Making them
static properties is safer than relying on the class initialization timing,
which could potentially be changed depending on the implementation.
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Fri, 1 Dec 2023 18:24:48 GMT, Naoto Sato wrote:
> This is the fix to JLine, which makes it on par with the built-in Console fix
> ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
This pull request has now been integrated.
Changeset: bd04f91e
Author: Naoto Sat
On Sat, 2 Dec 2023 21:57:01 GMT, Naoto Sato wrote:
>> This is the fix to JLine, which makes it on par with the built-in Console
>> fix ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
>
> Naoto Sato has updated the pull request incrementally with one addition
> This is the fix to JLine, which makes it on par with the built-in Console fix
> ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Removed unnecessary modifi
On Fri, 1 Dec 2023 21:53:06 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clarify limitations
>
> src/java.base/share/classes/java/text/MessageFormat.java line 299:
>
>> 297: * the string produced
> This is the fix to JLine, which makes it on par with the built-in Console fix
> ([JDK-8320798](https://bugs.openjdk.org/browse/JDK-8320798)).
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
moved instance fields at t
On Fri, 1 Dec 2023 19:40:39 GMT, Iris Clark wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> moved instance fields at the top of the class
>
> src/jdk.internal.le/share/
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
This pull request has now been integrated.
Changeset: f6be7fdf
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/f6be7fdf22eede767a0ac29b4f1cb770cfdc0b0f
Stats: 8 li
On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove ensureOpen()
Thank
On Tue, 28 Nov 2023 19:12:50 GMT, Naoto Sato wrote:
> It is best practice to zero out the underlying buffer after use.
This pull request has now been integrated.
Changeset: d5685629
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/d568562966e9a2020704eee3d67b8a106f647
> Removing the unnecessary array assignments.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Use Arrays.fill()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16912/files
- new: https://git.openjdk.org/jdk/p
On Thu, 30 Nov 2023 21:17:57 GMT, Brian Burkhalter wrote:
> Is that "XXX" reminder at line 58 in MergeCollation still pertinent or could
> it be removed?
Maybe, but not 100% sure, so I just left it.
-
PR Comment: https://git.openjdk.org/jdk/pull/16912#issuecomment-1834615018
On Thu, 30 Nov 2023 21:26:20 GMT, Brett Okken wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use Arrays.fill()
>
> src/java.base/share/classes/sun/text/CompactByteArray.java line 83
PR submitted. I was pleasantly surprised how quickly bugreport.java.com
turned reports into issues.
Naoto
On 11/29/23 2:18 PM, Anthony Goubard wrote:
Thanks for the answers.
I've created an issue in bugreport.java.com
Removing the unnecessary array assignments.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16912/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16912=00
Issue: https://bugs.openjdk.org/browse/JDK-8321059
Stats: 8 lines in 2 files changed: 2
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Create
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
remove ensureOpen()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new: ht
On Thu, 30 Nov 2023 10:58:13 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.jav
On Wed, 29 Nov 2023 22:41:26 GMT, Justin Lu wrote:
> Please review this PR which updates an incorrect code example in
> _java/text/ChoiceFormat_.
>
> ChoiceFormat (and MessageFormat) provide an example of how to produce a
> pattern that supports singular and plural forms. The ChoiceFormat
On Tue, 28 Nov 2023 21:36:20 GMT, Joe Wang wrote:
>> Fix errors in the built-in Catalog implementation, specifically:
>> -- incorrect case in the property name as defined in the CSR
>> (https://bugs.openjdk.org/browse/JDK-8306056)
>> -- tests needed to be updated accordingly
>> --
On Tue, 28 Nov 2023 18:28:37 GMT, Justin Lu wrote:
>> Please review this PR which converts the shell test,
>> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>>
>> This test is a test runner that launches test methods from
>> _PropertiesTest.java_. It tests both the ways to
On Tue, 28 Nov 2023 20:11:42 GMT, Joe Wang wrote:
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> --
On Tue, 28 Nov 2023 19:23:45 GMT, Brian Burkhalter wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java li
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
corrected fromIndex
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new: ht
It is best practice to zero out the underlying buffer after use.
-
Commit messages:
- copyright year
- fill zero to position
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16861/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16861=00
Issue:
On Mon, 27 Nov 2023 19:32:04 GMT, Justin Lu wrote:
> Please review this PR which fixes timeouts for the two tests:
> _java/util/Locale/LocaleProvidersRun.java_ and
> _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_.
>
> These tests were updated to accept VM flags in
>
On Mon, 20 Nov 2023 19:15:18 GMT, Justin Lu wrote:
>> Please review this PR which allows these _j.util_ tests to launch new JVM
>> processes with VM flags,
>>
>> This is primarily done using by switching to
>> `ProcessTools::createTestJavaProcessBuilder`.
>
> Justin Lu has updated the pull
On Sat, 18 Nov 2023 17:38:48 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Sat, 18 Nov 2023 14:56:47 GMT, Roger Riggs wrote:
>> Now I tried and it didn't compile It should have been
>> `t.query(TemporalQueries.chronology()) instanceof IsoChronology`
>
> JapaneseChronology is an IsoChronology so run the test again (before
> committing) to make sure.
On Fri, 17 Nov 2023 22:58:00 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 4507:
>>
>>> 4505: || t instanceof LocalDateTime
>>> 4506: || t in
On Fri, 17 Nov 2023 22:16:36 GMT, Roger Riggs wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix format 'ja-JP-u-ca-japanese' ChronoLocalDate
>
> src/java.base/share/classes/java/util/Formatter.java line 4507:
>
On Fri, 10 Nov 2023 03:31:26 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Thu, 16 Nov 2023 18:11:48 GMT, Andrey Turbanov wrote:
>> A few classes in `sun.util` package have non-final fields which could easily
>> be marked `final`.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8316557:
On Fri, 17 Nov 2023 09:25:40 GMT, Justin Lu wrote:
> Please review this PR which allows these _j.util_ tests to launch new JVM
> processes with VM flags,
>
> This is primarily done using by switching to
> `ProcessTools::createTestJavaProcessBuilder`.
>
> _PropertiesTest.sh_ was updated with
On Fri, 17 Nov 2023 08:38:37 GMT, Andrey Turbanov wrote:
>> The map contains several entries so I think the plural form is appropriate
>> here.
>
> Current naming highlights the difference in values in this maps:
> `FIRST_DAY_OF_WEEK` vs `MINIMAL_DAYS_IN_FIRST_WEEK`.
> I like this approach.
On Thu, 16 Nov 2023 08:56:05 GMT, Andrey Turbanov wrote:
>> A few classes in `sun.util` package have non-final fields which could easily
>> be marked `final`.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8316557:
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Looks fine
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733111801
On Mon, 13 Nov 2023 23:35:11 GMT, Naoto Sato wrote:
> Correcting the explanation of the `DateFormat.SHORT` constant.
This pull request has now been integrated.
Changeset: 891d8cfa
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/891d8cfaf2fc0636bfe8f864cd010fb71266d
> Correcting the explanation of the `DateFormat.SHORT` constant.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
abbreviated/full clarification
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16645/files
-
On Tue, 14 Nov 2023 18:14:45 GMT, Roger Riggs wrote:
>> Thanks for the feedback, Joe. I think I would rather keep the description
>> somewhat abstract, simply mentioning the formatted output is `SHORT` <=
>> `MEDIUM` <= `LONG` <= `FULL` in length-wise. As it is noted in the previous
>>
On Tue, 14 Nov 2023 17:43:54 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/text/DateFormat.java line 12
> Correcting the explanation of the `DateFormat.SHORT` constant.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Further clarification
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16645/files
- new: ht
On Tue, 14 Nov 2023 01:41:15 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/text/DateFormat.java line 1
> Correcting the explanation of the `DateFormat.SHORT` constant.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16645/files
- new: ht
On Mon, 13 Nov 2023 21:38:11 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868)
>> which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_
>> static factory methods that have the _style_ parameter.
>
> Justin Lu has updated
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
This pull request has now been integrated.
Changeset: fe0ccdf5
Author:
Correcting the explanation of the `DateFormat.SHORT` constant.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16645/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16645=00
Issue: https://bugs.openjdk.org/browse/JDK-8319986
Stats: 1 line in 1
On Sun, 12 Nov 2023 21:39:29 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868)
> which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_
> static factory methods that have the _style_ parameter.
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
comm
On Fri, 10 Nov 2023 01:20:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four addi
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote:
> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
> Besides the data upgrade, regression tests are modified to accommodate the
> following CLDR fixes:
>
> CLDR-16534: Suggestion to rename the I
On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote:
> Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
> This change completes the Unicode 15.1 upgrade. The change is merely
> replacing binary data files used for the Normalization and BiDi support
This pul
On Thu, 9 Nov 2023 21:58:12 GMT, Justin Lu wrote:
> Please review this PR which makes an `ArrayIndexOutOfBoundsException`
> apparent in ChoiceFormat::format.
>
> An _incomplete_ ChoiceFormat can be created, which is not revealed until
> format is invoked.
Marked as reviewed by naoto
Fixing the `Format::parseObject(String, ParsePosition)` implementation in
`DateTimeFormatter` class, to not throw `DateTimeException` but to return null.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16586/files
Webrev:
On Wed, 8 Nov 2023 00:52:36 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the
> standard test command line arguments should be marked as `vm.flagless` to
> indicate to the testing infrastructure that they do not accept them and
> should
301 - 400 of 1222 matches
Mail list logo
