On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the
> standard test command line arguments should be marked as `vm.flagless` to
> indicate to the testing infrastructure that they do not accept them and
> should
On Wed, 8 Nov 2023 18:45:47 GMT, Steven Loomis wrote:
>> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
>> Besides the data upgrade, regression tests are modified to accommodate the
>> following CLDR fixes:
>>
>> CLDR-16534: Suggestion to rename the Islamic Calendar
Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
This change completes the Unicode 15.1 upgrade. The change is merely replacing
binary data files used for the Nomalization and BiDi support
-
Commit messages:
- update the license file
- Merge branch
Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
Besides the data upgrade, regression tests are modified to accommodate the
following CLDR fixes:
CLDR-16534: Suggestion to rename the Islamic Calendar to Hijri Calendar
On Tue, 7 Nov 2023 05:43:06 GMT, Joe Wang wrote:
>> Xalan 2.7.3: merge minor changes from the upstream project.
>>
>> Test: existing XML tests pass
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove commented out block in
On Tue, 7 Nov 2023 15:15:19 GMT, Shaojin Wen wrote:
>> Within java.util.Formatter, the year formatter supports only the range
>> [0,].
>> Only ISO_STANDARD_DATE has a ISO 8601 format defined for numbers outside
>> that range.
>> The formatting in java.time is defined over the full range
On Tue, 7 Nov 2023 01:31:03 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 6 Nov 2023 14:55:54 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote:
> Please review this PR which clarifies the definition of a _cancelled_ task in
> _j.util.Timer::purge_ and _j.util.Timer::cancel_.
>
> Timer::purge claims that its return value is the number of tasks in the queue
> that were cancelled. This
On Fri, 3 Nov 2023 12:03:24 GMT, Claes Redestad wrote:
> https://github.com/cassioneri/eaf suggest this code for leap year calculation:
>
> public static boolean isLeap(long year) {
> int d = year % 100 != 0 ? 4 : 16;
> return (year & (d - 1)) == 0;
> }
>
> .. with a
On Wed, 1 Nov 2023 21:27:57 GMT, Justin Lu wrote:
> Please review this simple change which refines the specification of some
> NumberFormat methods (with unsupported operations) to separate the API and
> implementation specification.
LGTM
-
Marked as reviewed by naoto
On Fri, 27 Oct 2023 22:21:41 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java line 283:
>>
>>> 281: return type;
>>> 282: }
>>> 283: }
>>
>> Instead of looping through all the elements, `Enum.valueOf()`
On Fri, 27 Oct 2023 19:20:01 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 27 Oct 2023 18:40:56 GMT, Justin Lu wrote:
>> Please review this PR which updates ChoiceFormat and MessageFormat to no
>> longer call overridable methods in their constructors.
>>
>> The overridable methods called in the constructors are:
>> _ChoiceFormat::applyPattern_,
On Fri, 27 Oct 2023 17:31:43 GMT, Justin Lu wrote:
>> Please review this PR which updates ChoiceFormat and MessageFormat to no
>> longer call overridable methods in their constructors.
>>
>> The overridable methods called in the constructors are:
>> _ChoiceFormat::applyPattern_,
On Mon, 23 Oct 2023 18:40:26 GMT, Naoto Sato wrote:
> Spec clarification of `ListFormat.equals()` method, utilizing newly
> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also
> been drafted.
This pull request has now been integrated.
Changeset: a52088
On Tue, 24 Oct 2023 17:04:25 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review comments
>
> Looks fine to me.
>
> Alternatively (or mor
> Spec clarification of `ListFormat.equals()` method, utilizing newly
> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also
> been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecti
> Spec clarification of `ListFormat.equals()` method, utilizing newly
> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also
> been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The pull request now con
On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote:
> Proposing adding getter methods for `locale` and `patterns` fields in the
> `ListFormat` instances. Those fields are used for `equals()`, but without the
> public getter methods, users cannot tell the reasoning of the equali
On Mon, 23 Oct 2023 23:16:42 GMT, Justin Lu wrote:
>> Please review this PR which adds a test for ChoiceFormat intended to test a
>> wide range of ChoiceFormat patterns.
>>
>> The existing test _Bug4387255_ only tests a singular basic pattern and does
>> not test for incorrect patterns
On Mon, 23 Oct 2023 21:15:44 GMT, Justin Lu wrote:
> Please review this PR which adds a test for ChoiceFormat intended to test a
> wide range of ChoiceFormat patterns.
>
> The existing test _Bug4387255_ only tests a singular basic pattern and does
> not test for incorrect patterns either.
>
Spec clarification of `ListFormat.equals()` method, utilizing newly introduced
`getLocale()` and `getPatterns()`. A corresponding CSR has also been drafted.
-
Depends on: https://git.openjdk.org/jdk/pull/16293
Commit messages:
- Fixing typo
- Removed redundant wording
- initial
On Mon, 23 Oct 2023 17:16:08 GMT, Justin Lu wrote:
> Please review this PR which clarifies inconsistency between
> `ChoiceFormat::applyPattern` and `ChoiceFormat::setChoices`.
>
> A `ChoiceFormat` is composed of limits and formats. `applyPattern()` will
> throw an exception if limits are not
Proposing adding getter methods for `locale` and `patterns` fields in the
`ListFormat` instances. Those fields are used for `equals()`, but without the
public getter methods, users cannot tell the reasoning of the equality of two
instances. A corresponding CSR has also been drafted.
On Thu, 19 Oct 2023 21:31:13 GMT, Justin Lu wrote:
> Please review this PR which adjusts the specification of
> `DateFormat.Field::getCalendarField` to conform to the implementation.
>
> `getCalendarField()` claims that it will return -1 if there is no
> corresponding `Calendar` constant.
>
On Mon, 16 Oct 2023 19:57:12 GMT, Naoto Sato wrote:
> CLDR provides very few short names for time zones, such as PST/PDT. This will
> typically end up substituting names from the COMPAT provider. Once the COMPAT
> is removed, they will be displayed in the GMT format, i.e.,
hich contains legacy (major) short names as FORMAT. The CLDR
> provider can use them instead of the GMT offset style. This enhancement is a
> precursor to the future removal of the COMPAT provider.
Naoto Sato has updated the pull request incrementally with one additional
commit since t
On Wed, 18 Oct 2023 15:13:14 GMT, Magnus Ihse Bursie wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Delay populating GMT format at runtime. Reflecting review comments.
>
> make/mod
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
Marked as reviewed by naoto (Reviewer).
On Tue, 17 Oct 2023 21:45:57 GMT, Steven Loomis wrote:
> > CLDR provides very few short names for time zones, such as PST/PDT. This
> > will typically end up substituting names from the COMPAT provider. Once the
> > COMPAT is removed, they will be displayed in the GMT format, i.e.,
> >
hich contains legacy (major) short names as FORMAT. The CLDR
> provider can use them instead of the GMT offset style. This enhancement is a
> precursor to the future removal of the COMPAT provider.
Naoto Sato has updated the pull request incrementally with one additional
commit since the l
On Tue, 17 Oct 2023 02:03:06 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use ZoneOffset to parse offset
>
> Looks fine.
> (I can't help thinking that some of th
hich contains legacy (major) short names as FORMAT. The CLDR
> provider can use them instead of the GMT offset style. This enhancement is a
> precursor to the future removal of the COMPAT provider.
Naoto Sato has updated the pull request incrementally with one additional
commit since the
On Mon, 9 Oct 2023 23:21:57 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
CLDR provides very few short names for time zones, such as PST/PDT. This will
typically end up substituting names from the COMPAT provider. Once the COMPAT
is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY. Although
some of the short names in the COMPAT provider are somewhat
On Thu, 12 Oct 2023 20:58:21 GMT, Justin Lu wrote:
>> Please review this PR which refactors a number of tests under
>> `test/text/NumberFormat` to use JUnit.
>>
>> During the switch to JUnit, the tests had the following updates (to improve
>> readability)
>> - separate the test data
On Wed, 11 Oct 2023 21:15:42 GMT, Justin Lu wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 62:
>>
>>> 60: // currencySymbolsTest() is only ran for COMPAT
>>> 61: private static final boolean isCompat =
>>> 62:
>>>
On Wed, 11 Oct 2023 21:20:47 GMT, Justin Lu wrote:
>> Please review this PR which refactors a number of tests under
>> `test/text/NumberFormat` to use JUnit.
>>
>> During the switch to JUnit, the tests had the following updates (to improve
>> readability)
>> - separate the test data
On Wed, 11 Oct 2023 07:59:24 GMT, Per Minborg wrote:
> This PR proposes to add @sealedGraph to `IllegalFormatException`
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16140#pullrequestreview-1672385095
On Tue, 3 Oct 2023 22:23:11 GMT, Justin Lu wrote:
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test data generation from
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote:
> Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument
> on calling `ListFormat::parseObject()`. A corresponding CSR has also been
> drafted.
This pull request has now been integrated.
Changeset: 1f0632
On Fri, 6 Oct 2023 22:48:40 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote:
>> Please review this PR which cleans up the static test utility class
>> _HexDumpReader_.
>>
>> This cleans up the code by replacing the nested _ByteArrayBuilder_ class
>> with _HexFormat_, and simplifies the File processing by using a
On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote:
> Please review this PR which cleans up the static test utility class
> _HexDumpReader_.
>
> This cleans up the code by replacing the nested _ByteArrayBuilder_ class with
> _HexFormat_, and simplifies the File processing by using a stream.
On Fri, 6 Oct 2023 17:50:56 GMT, Justin Lu wrote:
>> Please review this PR which refactors the ChoiceFormat tests to use JUnit.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review: separate into two tests
Good point
On Thu, 5 Oct 2023 20:57:07 GMT, Justin Lu wrote:
> Please review this PR which refactors the ChoiceFormat tests to use JUnit.
test/jdk/java/text/Format/ChoiceFormat/Bug8001209.java line 78:
> 76: "Mutating array returned from getter changed internals of
> ChoiceFormat");
>
On Wed, 4 Oct 2023 17:17:57 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. This was found during upgrading
> CLDR to v44, in which some list patterns are missing (thus to be inherited
> from parents) in Norwegian locales which could end up with infinite parent
Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument
on calling `ListFormat::parseObject()`. A corresponding CSR has also been
drafted.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16063/files
Webrev:
On Wed, 4 Oct 2023 22:56:28 GMT, Joe Wang wrote:
> Add a new factory method so that a CatalogResolver can be created with a
> resolve property on top of the Catalog object.
src/java.xml/share/classes/javax/xml/catalog/CatalogManager.java line 101:
> 99: * and {@code ignore}. {@code null}
On Wed, 13 Sep 2023 17:52:22 GMT, Mandy Chung wrote:
>> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
>> APIs if the method's variable arity modifier bit is set and
>> `asVarargsCollector` fails. It will include the exception message thrown by
>>
On Wed, 13 Sep 2023 17:52:22 GMT, Mandy Chung wrote:
>> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
>> APIs if the method's variable arity modifier bit is set and
>> `asVarargsCollector` fails. It will increase the exception message thrown
>> by
Please review the fix to the subject issue. This was found during upgrading
CLDR to v44, in which some list patterns are missing (thus to be inherited from
parents) in Norwegian locales which could end up with infinite parent lookup.
Avoiding the recursive call and changing it to a plain loop
On Mon, 2 Oct 2023 16:59:00 GMT, Naoto Sato wrote:
> A simple clarification of the conditions for throwing an IAE.
This pull request has now been integrated.
Changeset: 1809b8cd
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/1809b8cdd6f27fd2f19072a874f5020ca717ad11
St
On Fri, 29 Sep 2023 20:46:44 GMT, Justin Lu wrote:
> Please review this PR and which adjusts the pattern section of
> java.text.ChoiceFormat to specify the single quote behavior within a String
> pattern.
>
> The other Format classes that take a String pattern such as DecimalFormat,
>
A simple clarification of the conditions for throwing an IAE.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16013/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16013=00
Issue: https://bugs.openjdk.org/browse/JDK-8317265
Stats: 2 lines in 1
On Fri, 29 Sep 2023 23:24:13 GMT, Justin Lu wrote:
>> Please review this PR which removes the i18n related testing base classes
>> `IntlTest` and `CollatorTest` and converts all the tests that use them,
>>
>> IntlTest and CollatorTest are testing classes which are extended by tests in
>>
On Fri, 29 Sep 2023 21:22:01 GMT, Justin Lu wrote:
>> Please review this PR which removes the i18n related testing base classes
>> `IntlTest` and `CollatorTest` and converts all the tests that use them,
>>
>> IntlTest and CollatorTest are testing classes which are extended by tests in
>>
On Thu, 28 Sep 2023 18:13:12 GMT, Justin Lu wrote:
>> Please review this PR which removes the i18n related testing base classes
>> `IntlTest` and `CollatorTest` and converts all the tests that use them,
>>
>> IntlTest and CollatorTest are testing classes which are extended by tests in
>>
On Thu, 28 Sep 2023 17:37:00 GMT, Naoto Sato wrote:
> Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
> Windows time zones to Java time zones according to the region. Since `001`
> means world, no region-specific entries are needed if those t
Removing redundant entries in `lib/tzmappings` file on Windows. The file maps
Windows time zones to Java time zones according to the region. Since `001`
means world, no region-specific entries are needed if those time zones are the
same. The diff of the generated tzmappings files, before and
On Tue, 26 Sep 2023 21:49:11 GMT, Naoto Sato wrote:
> Some CLDR locales have partial list patterns, such as only the "end" pattern,
> and expect "start" and "middle" patterns to be inherited from parent locales.
> Made the code capable of the inher
On Wed, 27 Sep 2023 22:44:52 GMT, Mourad Abbay wrote:
>> Remove unused imports in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by naoto
On Wed, 27 Sep 2023 17:45:58 GMT, Mourad Abbay wrote:
> Remove unused imports in the java.util.stream package.
Please modify the copyright year accordingly. Otherwise LGTM
-
PR Review: https://git.openjdk.org/jdk/pull/15949#pullrequestreview-1647590729
> Some CLDR locales have partial list patterns, such as only the "end" pattern,
> and expect "start" and "middle" patterns to be inherited from parent locales.
> Made the code capable of the inheritance.
Naoto Sato has updated the pull request incremen
> Some CLDR locales have partial list patterns, such as only the "end" pattern,
> and expect "start" and "middle" patterns to be inherited from parent locales.
> Made the code capable of the inheritance.
Naoto Sato has updated the pull request incremen
Some CLDR locales have partial list patterns, such as only the "end" pattern,
and expect "start" and "middle" patterns to be inherited from parent locales.
Made the code capable of the inheritance.
-
Commit messages:
- initial commit
Changes:
On Tue, 19 Sep 2023 01:01:14 GMT, Naoto Sato wrote:
> Fixed the failing (well, false-positive) test case. Made the following
> changes to the test:
>
> - Corrected the path to the mapping files directory
> - Made sure to fail if the directory path is incorrect
> - Took care
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote:
>> Please review this PR which converts some tests under _Calendar_ to use
>> JUnit. These tests either previously used the internal _IntlTest_, or used
>> no framework at all.
>>
>> Any files named BugXXX.java will be renamed after
On Fri, 22 Sep 2023 19:44:00 GMT, Justin Lu wrote:
>> test/jdk/java/util/Calendar/Bug4766302.java line 32:
>>
>>> 30: import java.util.GregorianCalendar;
>>> 31:
>>> 32: @SuppressWarnings("serial")
>>
>> Is removing this OK?
>
> At first I thought so, there is no warning about a missing
On Tue, 19 Sep 2023 22:49:36 GMT, Naoto Sato wrote:
> Fixing a test case that fails in some time zones. Making sure the test is run
> in `UTC` zone will fix the issue. Confirmed the fix by manually setting
> machine's time zone to Europe/Dublin.
This pull request has now been i
On Thu, 21 Sep 2023 18:51:50 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has
On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
> Fixing a test case that fails in some time zones. Making sure the test is run
> in `UTC` zone will fix the issue. Confirmed the fix by manually setting
> machine's time zone to Europe/Dublin.
Naoto Sato has updated the pull request incrementally with one additional
commit since
On Thu, 21 Sep 2023 07:17:43 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> test/jdk/java/util/Properties/StoreReproducibilit
On Tue, 19 Sep 2023 21:10:41 GMT, Joe Wang wrote:
> Fix a NPE. The DTD patch (JDK-8306632) moved initialization to factories, for
> example, for SAXParser, the SecurityManagers are created in the
> SAXParserFactory impl and passed on to instances of SAXParsers. The
> (deprecated)
On Wed, 20 Sep 2023 22:10:16 GMT, Justin Lu wrote:
> Please review this PR, which updates the exception message for
> java.text.DateFormatSymbols.setZoneStrings
>
> `setZoneStrings()` takes a multi dimensional array as input. If any row does
> not have a length of at least 5, an
On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato wrote:
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Conjunct Break specified in
> the lat
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote:
>> Please review this PR which restricts sub-classing of the internal calendar
>> system in sun.util.calendar to only the existing implementations. Drive by
>> cleanup included.
>>
>> As the implementation is long-standing and complete with
On Wed, 20 Sep 2023 08:54:55 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup CalendarDate after revert
>> - Revert "Replace sprintf0d with Formatter"
>>
>>This reverts commit
On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has
> Fixing a test case that fails in some time zones. Making sure the test is run
> in `UTC` zone will fix the issue. Confirmed the fix by manually setting
> machine's time zone to Europe/Dublin.
Naoto Sato has updated the pull request incrementally with one additional
commit since
On Tue, 19 Sep 2023 21:10:18 GMT, Justin Lu wrote:
>> src/java.base/share/classes/sun/util/calendar/CalendarUtils.java line 132:
>>
>>> 130: * Mimics sprintf(buf, "%0*d", decaimal, width).
>>> 131: */
>>> 132: public static StringBuilder sprintf0d(StringBuilder sb, int value,
>>>
Fixing a test case that fails in some time zones. Making sure the test is run
in `UTC` zone will fix the issue. Confirmed the fix by manually setting
machine's time zone to Europe/Dublin.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/15829/files
On Fri, 15 Sep 2023 21:51:22 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Remove vestigial unused import
ntime
> - Provided `MS950_HKSCS.map`, which is simply a copy of `HKSCS2008.map`
> - Excluded other failing tests for IBM charsets that do not have map files.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Included the f
On Tue, 19 Sep 2023 18:15:54 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Included the failed directory location in the exception message
>
> test/jdk/sun/nio/cs/Te
On Tue, 19 Sep 2023 17:00:39 GMT, Steven Loomis wrote:
>> src/java.base/share/legal/unicode.md line 49:
>>
>>> 47: --
>>> 48:
>>> 49: Unicode® Copyright and Terms of Use
>>
>> You shouldn't need to pull in all of this — the entire license file is at
>>
On Tue, 19 Sep 2023 17:54:52 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 addi
On Tue, 19 Sep 2023 16:18:18 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
egmentation")](https://unicode.org/reports/tr29/) is included. A
> corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecting review comments
-
Changes:
- all: https://git.open
egmentation")](https://unicode.org/reports/tr29/) is included. A
> corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Update
make/jdk/src/classes/build/tools/generateextraproperties/Generate
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote:
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations.
>
> As the implementation is long-standing and complete with no intent for future
>
Fixed the failing (well, false-positive) test case. Made the following changes
to the test:
- Corrected the path to the mapping files directory
- Made sure to fail if the directory path is incorrect
- Took care of `GB18030` alias, which is dynamically derived at runtime
- Provided
On Mon, 18 Sep 2023 18:04:22 GMT, Erik Joelsson wrote:
>> Naoto Sato has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update
>> make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraP
egmentation")](https://unicode.org/reports/tr29/) is included. A
> corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
On Sat, 16 Sep 2023 07:37:37 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java
>> line 160:
>>
>>> 158: unsupported();
>>> 159: }
>>> 160:
>>
>> This removal does not look right. The class claims `immutable`, and yet it
>>
On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
401 - 500 of 1223 matches
Mail list logo
