On Thu, 11 May 2023 20:39:57 GMT, Justin Lu wrote:
>> Please review this javadoc only change which uses `@snippet` and
>> `@linkplain` in i18n related util packages.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review:
On Fri, 12 May 2023 08:45:37 GMT, Alan Bateman wrote:
> I'm just wondering where a developer might go to get a definitive list, i.e.
> aside from this API note, how would they know that "-trad" or "-traditional"
> can be used to configure the ordering. Locale.forLanguageTag supports more
>
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java
> on linux-x64.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13946#pullrequestreview-142360
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in
hat multiple implementations
> for a locale can be provided. I would also like reviews for the corresponding
> CSR.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added "reformed" tests
-
Changes:
- all: http
On Wed, 10 May 2023 23:54:37 GMT, Justin Lu wrote:
> Please review this javadoc only change which uses `@snippet` and `@linkplain`
> in i18n related util packages.
Looks good overall. Some minor comments follow.
src/java.base/share/classes/java/util/Currency.java line 517:
> 515: * If
On Thu, 11 May 2023 18:27:28 GMT, Justin Lu wrote:
> Please review this PR which adds an initial equality check to
> `RuleBasedCollator.compare(String source, String target)`.
>
> This speeds up the operation for equal input Strings, as it bypasses Collator
> rule comparisons of each element
On Thu, 11 May 2023 15:40:50 GMT, Justin Lu wrote:
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some
hat multiple implementations
> for a locale can be provided. I would also like reviews for the corresponding
> CSR.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.
On Thu, 11 May 2023 09:44:34 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> http -> https
>
> src/java.base/share/classes/java/text/Collator.java line 131:
>
On Wed, 10 May 2023 20:28:11 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Colla
hat multiple implementations
> for a locale can be provided. I would also like reviews for the corresponding
> CSR.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
http -> https
-
Changes:
- all: https://git.openjdk.org
The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
collation for Swedish to the modern one. In order to provide a means for users
who need the old collation, this PR intends to make `Collator` recognize the
`co` Unicode locale extension so that multiple implementations
On Tue, 9 May 2023 20:39:19 GMT, Justin Lu wrote:
> Please review this PR which adds an example snippet to
> `java.time.temporal.WeekFields.of(Locale locale)`
>
> The snippet demonstrates how to create a Locale that has English Locale
> qualities with an ISO-8601 first day of the week.
>
>
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote:
>> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases
>> did not correctly borrow or carry from the nanos to the seconds when
>> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS.
>> The errant computation was
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote:
> Updating the collation rules for Swedish to the modern one, which is aligned
> with the CLDR's default collation rules. Since it is changing the existing
> behavior, a release note has also been drafted:
> https://bugs.openjd
On Wed, 3 May 2023 20:32:25 GMT, Justin Lu wrote:
>> Please review this PR which adds the method `caseFoldLanguageTag(String
>> languageTag)` to java.util.Locale.
>>
>> This method case folds a language tag to adhere to _[section 2.1.1.
>> Formatting of Language Tags of
>>
On Tue, 2 May 2023 21:36:57 GMT, Justin Lu wrote:
>> test/jdk/java/util/Locale/CaseFoldLanguageTagTest.java line 56:
>>
>>> 54: @MethodSource("wellFormedTags")
>>> 55: public void TestWellFormedTags(String tag, String foldedTag) {
>>> 56: assertEquals(foldedTag,
On Tue, 2 May 2023 21:42:09 GMT, Justin Lu wrote:
>> Please review this PR which adds the method `caseFoldLanguageTag(String
>> languageTag)` to java.util.Locale.
>>
>> This method case folds a language tag to adhere to _[section 2.1.1.
>> Formatting of Language Tags of
>>
On Tue, 2 May 2023 18:34:11 GMT, Justin Lu wrote:
>> Please review this PR which adds the method `caseFoldLanguageTag(String
>> languageTag)` to java.util.Locale.
>>
>> This method case folds a language tag to adhere to _[section 2.1.1.
>> Formatting of Language Tags of
>>
On Sat, 29 Apr 2023 01:32:23 GMT, Joe Wang wrote:
>> Fix a copy n paste error in XMLSchemaValidator. When the patch was applied
>> while updating to Xerces 2.12.2, the original code was not removed,
>> resulting in reporting validation error twice.
>
> Joe Wang has updated the pull request
On Fri, 28 Apr 2023 05:47:24 GMT, Joe Wang wrote:
>> Add a system property, jdk.xml.config.file, to return the path to a custom
>> JAXP configuration file. The current configuration file, jaxp.properties,
>> that the JDK supports will become the default configuration file.
>>
>> CSR:
On Fri, 28 Apr 2023 17:08:10 GMT, Joe Wang wrote:
> Fix a copy n paste error in XMLSchemaValidator. When the patch was applied
> while updating to Xerces 2.12.2, the original code was not removed, resulting
> in reporting validation error twice.
On Fri, 28 Apr 2023 17:28:47 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which allows the` jdbc.drivers` system
> property to be searchable.
>
> Best.
> Lance
Marked as reviewed by naoto (Reviewer).
-
PR Review:
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote:
> Updating the collation rules for Swedish to the modern one, which is aligned
> with the CLDR's default collation rules. Since it is changing the existing
> behavior, a release note has also been drafted:
> https://bugs.openjd
On Thu, 27 Apr 2023 04:37:08 GMT, Joe Wang wrote:
> The rule was changed in 2006, the year Jave SE 6 was released. Though it
> looks like very much a corner case, it goes all the way back. I wonder if a
> CSR is needed?
We don't file a CSR for such a locale data change. These sorts of changes
Updating the collation rules for Swedish to the modern one, which is aligned
with the CLDR's default collation rules. Since it is changing the existing
behavior, a release note has also been drafted:
https://bugs.openjdk.org/browse/JDK-8306948
-
Commit messages:
- Added a test,
On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual
On Wed, 26 Apr 2023 03:03:58 GMT, Yoshiki Sato wrote:
>> Please review this PR.
>> With this minor change, the javazic compiler (Main.java) can produce the
>> HTML files that display given time zone data correctly.
>
> Yoshiki Sato has updated the pull request incrementally with one
On Tue, 25 Apr 2023 22:08:09 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual
On Tue, 18 Apr 2023 05:08:35 GMT, Yoshiki Sato wrote:
> Please review this PR.
> With this minor change, the javazic compiler (Main.java) can produce the HTML
> files that display given time zone data correctly.
I revisited the code, and now think that `mapList` better be `null`, as it
On Mon, 24 Apr 2023 23:47:05 GMT, Justin Lu wrote:
>> This PR fixes an intermittent failure (that only occurs on Windows) in
>> _DateFormatRegression.java_.
>>
>> With the integration of
>> [JDK-8304982](https://bugs.openjdk.org/browse/JDK-8304982),
>> _LocaleProviderAdapter.java_ now emits
On Tue, 18 Apr 2023 05:08:35 GMT, Yoshiki Sato wrote:
> Please review this PR.
> With this minor change, the javazic compiler (Main.java) can produce the HTML
> files that display given time zone data correctly.
test/jdk/sun/util/calendar/zi/GenDoc.java line 159:
> 157: if
On Mon, 24 Apr 2023 21:02:01 GMT, Justin Lu wrote:
> This PR fixes an intermittent failure (that only occurs on Windows) in
> _DateFormatRegression.java_.
>
> With the integration of
> [JDK-8304982](https://bugs.openjdk.org/browse/JDK-8304982),
> _LocaleProviderAdapter.java_ now emits a
On Thu, 20 Apr 2023 18:39:29 GMT, Naoto Sato wrote:
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit woul
On Tue, 28 Feb 2023 07:49:17 GMT, Madjosz wrote:
>> Fixes JDK-8302983 (and duplicate JDK-8302898)
>
> Madjosz has updated the pull request incrementally with one additional commit
> since the last revision:
>
> whitespace, remove stream()
Marked as reviewed by naoto (Reviewer).
On Thu, 20 Apr 2023 20:22:39 GMT, Justin Lu wrote:
>> Update the registry and accompanying tests with the **IANA 4/13/2022**
>> update.
>>
>> This update introduces the case where an IANA entry can have a preferred
>> value, but that preferred value has a preferred value as well.
>>
>> This
On Fri, 21 Apr 2023 12:42:24 GMT, David Schlosnagle wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/jni_util.c
>>
>> Co-aut
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the macro more robust.
Naoto Sato has upda
The current macro assumes the argument is `jint` because all locations pass
`jint`. However, this would not work if a wider type such as `jlong` is passed.
Removing the `unsigned` cast and make the condition explicit would make the
macro more robust.
-
Commit messages:
- 8304836:
On Thu, 20 Apr 2023 06:32:41 GMT, Justin Lu wrote:
> Small cleanup / tweak spotted in Calendar to improve readability.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13554#pullrequestreview-1394532604
On Thu, 20 Apr 2023 06:36:47 GMT, Justin Lu wrote:
>> Update the registry and accompanying tests with the **IANA 4/13/2022**
>> update.
>>
>> This update introduces the case where an IANA entry can have a preferred
>> value, but that preferred value has a preferred value as well.
>>
>> This
On Wed, 19 Apr 2023 20:07:32 GMT, Justin Lu wrote:
>> Update the registry and accompanying tests with the **IANA 4/13/2022**
>> update.
>>
>> This update introduces the case where an IANA entry can have a preferred
>> value, but that preferred value has a preferred value as well.
>>
>> This
On Wed, 19 Apr 2023 07:08:53 GMT, Peter Hofer wrote:
>> Store `Charset` object in `jnuEncoding` and use `String(byte[], Charset)`
>> and `String.getBytes(Charset)` instead of passing the charset name.
>
> Peter Hofer has updated the pull request with a new target base due to a
> merge or a
On Wed, 19 Apr 2023 06:50:45 GMT, Peter Hofer wrote:
>> src/java.base/share/native/libjava/jni_util.c line 757:
>>
>>> 755: jnuEncoding = (*env)->NewGlobalRef(env, charset.l);
>>> 756: (*env)->DeleteLocalRef(env, charset.l);
>>> 757: break;
>>
>>
On Tue, 18 Apr 2023 18:40:03 GMT, Naoto Sato wrote:
> The upgrade to CLDR v43 was missing the license-related file updates. Here
> are the supplemental updates.
This pull request has now been integrated.
Changeset: 85de01e6
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/
On Tue, 18 Apr 2023 11:34:45 GMT, Peter Hofer wrote:
>> Store `Charset` object in `jnuEncoding` and use `String(byte[], Charset)`
>> and `String.getBytes(Charset)` instead of passing the charset name.
>
> Peter Hofer has updated the pull request with a new target base due to a
> merge or a
The upgrade to CLDR v43 was missing the license-related file updates. Here are
the supplemental updates.
-
Commit messages:
- 8306323: Update license files in CLDR v43
Changes: https://git.openjdk.org/jdk/pull/13517/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13517=00
On Thu, 13 Apr 2023 20:20:02 GMT, Naoto Sato wrote:
> Upgrading the CLDR to [version
> 43](https://cldr.unicode.org/index/downloads/cldr-43). This semi-annual
> release is their `limited-submission` release so I would not expect
> regressions caused by formatting changes as we
On Wed, 29 Mar 2023 22:04:08 GMT, Justin Lu wrote:
> Many Calendar methods that take in a field parameter should document that
> they throw an ArrayIndexOutOfBoundsException if field is not between 0 and
> `Calendar.FIELD_COUNT`.
>
> This PR adds a clause to the class description to make the
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are
8/quality-heads-up/)
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Short ID test for "America/Ciudad_Juarez"
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13469/files
- new: https://git.openjdk.org/jdk/
On Thu, 13 Apr 2023 20:46:10 GMT, Steven R. Loomis wrote:
>> Upgrading the CLDR to [version
>> 43](https://cldr.unicode.org/index/downloads/cldr-43). This semi-annual
>> release is their `limited-submission` release so I would not expect
>> regressions caused by formatting changes as we had
Upgrading the CLDR to [version
43](https://cldr.unicode.org/index/downloads/cldr-43). This semi-annual release
is their `limited-submission` release so I would not expect regressions caused
by formatting changes as we had in JDK20/CLDRv42
(https://inside.java/2023/03/28/quality-heads-up/)
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote:
> Following tests read the unicode data files
> (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests,
> these files should be in test directories. No source code is using these
> files. Only tests are using these
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote:
> Following tests read the unicode data files
> (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests,
> these files should be in test directories. No source code is using these
> files. Only tests are using these
I too agree with Roger that deprecation would have high bar.
Another possibility to mitigate the situation rather than introducing
the new methods is to introduce a new system property and let the users
decide the default (yes, yet another property, but I believe it
warrants). Say,
On Mon, 3 Apr 2023 21:56:31 GMT, Justin Lu wrote:
> The GregorianCalendar constructors and Calendar.getInstance() methods that
> take TimeZone or Locale throw a NullPointerException if any values are null.
>
> This PR updates the javadoc to make this apparent.
Marked as reviewed by naoto
On Mon, 3 Apr 2023 21:56:33 GMT, Justin Lu wrote:
> This PR updates the Calendar.DAY_OF_WEEK documentation to make it clear that
> the field accepts _any_ value if the calendar is lenient and then normalizes
> it. Only if the calendar is non-lenient, will the field accept only one of
> SUNDAY
On Mon, 3 Apr 2023 16:47:40 GMT, Naoto Sato wrote:
> This is a precursor to the future removal of the `COMPAT` locale data
> provider. Before the actual removal of the provider, warn the users who
> explicitly specify `COMPAT` at the command line in order for their smooth
> migra
On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato wrote:
> Introducing new regex constructs that match those 6 new Unicode Emoji
> properties implemented in the `Character` class
> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
> drafted.
This pull request
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote:
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> -
On Tue, 4 Apr 2023 19:31:24 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> test/jdk/java/util/regex/RegExTest.java line 967:
>
>> 965:
> Introducing new regex constructs that match those 6 new Unicode Emoji
> properties implemented in the `Character` class
> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
> drafted.
Naoto Sato has updated the pull request incrementally with one additi
On Tue, 4 Apr 2023 06:54:38 GMT, Alan Bateman wrote:
>> Locale providers provided by users can all be loaded in the name of `SPI`,
>> as they are the real implementation of `LocaleServiceProvider` class, so the
>> order of the preference can be specified against JDK's `CLDR` provider. Does
>>
> This is a precursor to the future removal of the `COMPAT` locale data
> provider. Before the actual removal of the provider, warn the users who
> explicitly specify `COMPAT` at the command line in order for their smooth
> migration to CLDR. A CSR has also been drafted.
Naoto Sato
On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato wrote:
> Introducing new regex constructs that match those 6 new Unicode Emoji
> properties implemented in the `Character` class
> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
> drafted.
Thanks,
> Introducing new regex constructs that match those 6 new Unicode Emoji
> properties implemented in the `Character` class
> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
> drafted.
Naoto Sato has updated the pull request incrementally with one additi
On Mon, 3 Apr 2023 23:40:05 GMT, Yoshiki Sato wrote:
>> Pleases review this PR.
>> The PR includes the following changes.
>> - tzdata 2023c
>> - Hack code to deal with Cairo's DST end, which is same as done in
>> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
>>
Introducing new regex constructs that match those 6 new Unicode Emoji
properties implemented in the `Character` class
(https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
drafted.
-
Commit messages:
- 8305107: Emoji related binary properties in RegEx
On Mon, 3 Apr 2023 19:56:03 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced "Java Runtime Environment" with "JDK Reference Implementation"
&
On Mon, 3 Apr 2023 17:25:57 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced "Java Runtime Environment" with "JDK Reference Implementation"
&
> This is a precursor to the future removal of the `COMPAT` locale data
> provider. Before the actual removal of the provider, warn the users who
> explicitly specify `COMPAT` at the command line in order for their smooth
> migration to CLDR. A CSR has also been drafted.
Naoto Sato
This is a precursor to the future removal of the `COMPAT` locale data provider.
Before the actual removal of the provider, warn the users who explicitly
specify `COMPAT` at the command line in order for their smooth migration to
CLDR. A CSR has also been drafted.
-
Commit
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in
On Fri, 31 Mar 2023 21:38:31 GMT, Justin Lu wrote:
> Please review the ISO 4217 amendment 175 update.
>
> There are no meaningful code changes, but the version number should be
> updated accordingly to be in sync.
Marked as reviewed by naoto (Reviewer).
> Do you track the legal tender date?
On Fri, 31 Mar 2023 16:39:17 GMT, Justin Lu wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato wrote:
> Pleases review this PR.
> The PR includes the following changes.
> - tzdata 2023c
> - Hack code to deal with Cairo's DST end, which is same as done in
> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
> around
On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato wrote:
> Pleases review this PR.
> The PR includes the following changes.
> - tzdata 2023c
> - Hack code to deal with Cairo's DST end, which is same as done in
> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work
> around
On Thu, 30 Mar 2023 21:33:16 GMT, Justin Lu wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>>
On Wed, 29 Mar 2023 22:51:12 GMT, Justin Lu wrote:
> Small typo fix in Locale.lookupTag
>
> _tangs_ should be _tags_
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13235#pullrequestreview-1364170271
On Tue, 28 Mar 2023 21:06:34 GMT, Justin Lu wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Wed, 29 Mar 2023 08:16:32 GMT, Sergey Tsypanov wrote:
>> 1) When `DateTimeFormatter` is reused we don't need to copy
>> `availableZoneIds` and allocate `nonRegionIds` as PrefixTree can be taken
>> from cache. In the related benchmark allocation of `HashSet` takes ~93% of
>> all time, so
0c76b902676.png)
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- Merge branch 'master' into JDK-8304840-CharacterCodingException
- Duplicate descriptions in CharacterCodingException
- 83
On Tue, 28 Mar 2023 18:25:21 GMT, Naoto Sato wrote:
> Fixing a documentation bug for `CharacterCodingException` without any
> description to it as attached. A corresponding CSR is also drafted.
>
> ![Screenshot 2023-03-28 at 11 19 00
> AM](https://user-images.githubusercont
On Tue, 28 Mar 2023 21:48:23 GMT, Lance Andersen wrote:
> Please review this trivial change which removes a redundant `-` from an
> `@param` and cleans up the formatting for the `isValid` method.
>
>
> It looks like there is some additional formatting clean up that can be done
> but I will
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
>
> After:
>
On Fri, 17 Feb 2023 09:50:16 GMT, Sergey Tsypanov wrote:
> 1) When `DateTimeFormatter` is reused we don't need to copy
> `availableZoneIds` and allocate `nonRegionIds` as PrefixTree can be taken
> from cache. In the related benchmark allocation of `HashSet` takes ~93% of
> all time, so
On Fri, 24 Mar 2023 18:48:41 GMT, Justin Lu wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Fri, 17 Mar 2023 18:22:17 GMT, Justin Lu wrote:
> This PR updates the javadoc of `java.util.Calendar.getDisplayName()` and
> `java.util.Calendar.getDisplayNames()` to better reflect the actual behavior
> when the calendar is non-lenient.
>
> This involves updating the spec of both methods
On Thu, 23 Mar 2023 21:30:37 GMT, Justin Lu wrote:
>> Update IANA LSR to 2023-03-22
>> [update](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-March/85.html).
>> Add all new preferred languages to `ACCEPT_LANGUAGES` except `gu`.
>
> Justin Lu has updated the pull request
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
On Thu, 23 Mar 2023 19:07:05 GMT, Justin Lu wrote:
> Update IANA LSR to 2023-03-22
> [update](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-March/85.html).
> Add all new preferred languages to `ACCEPT_LANGUAGES` except `gu`.
On Tue, 14 Mar 2023 18:21:33 GMT, Roger Riggs wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote:
> Proposing accessor methods to Emoji properties defined in [Unicode Technical
> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character`
> class. This is per a request from the client group, as well as
On Fri, 17 Mar 2023 20:31:27 GMT, Andy Goryachev wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust CF test to read in with UTF-8 to fix failing test
>
>
On Fri, 17 Mar 2023 16:56:16 GMT, Adam Sotona wrote:
>> The fix to `IncludeLocalesPlugin` has been integrated. @asotona would you
>> please check that the exception is not thrown with your changes?
>
> Yes, I can confirm the test now passes.
Great! Thanks for checking
-
PR:
On Fri, 17 Mar 2023 11:35:52 GMT, Adam Sotona wrote:
>> Submitted: https://github.com/openjdk/jdk/pull/13067
>
> I've reverted `IncludeLocalesPlugin` to previous version, plus minor fixes
> and together with #13067 the `IncludeLocalesPluginTest` is passing.
> Thank you.
The fix to
On Thu, 16 Mar 2023 20:43:38 GMT, Naoto Sato wrote:
> This is a blocker for
> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
> weed out non-class files for calling `ClassReader` by checking the file
> extension. Regression tests are
701 - 800 of 1222 matches
Mail list logo
