On Sat, 7 Jan 2023 10:35:50 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review suggestions
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleP
On Fri, 6 Jan 2023 22:38:13 GMT, Justin Lu wrote:
> When ID is null, TimeZone.getTimeZone(String ID) throws a
> NullPointerException.
>
> For example,
>
>
> String someID = null;
> TimeZone tz1 = TimeZone.getTimeZone(someID);
> ```
>
> throws a `NullPointerException`
>
> This change
On Mon, 9 Jan 2023 01:09:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes an issue in the javadoc
>> text of the internal class IteratorSpliterator? This addresses the issue
>> reported at https://bugs.openjdk.org/browse/JDK-8297306.
>
> Jaikiran Pai has
On Wed, 4 Jan 2023 21:49:18 GMT, Justin Lu wrote:
> Within _test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java_
>
> GregorianCalendar alone handles all the necessary imports, Calendar is not
> needed
Marked as reviewed by naoto (Reviewer).
-
PR:
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote:
>> Removed constructors of primitive wrapper classes (deprecated for removal)
>> in _javax.xml.stream.XMLOutputFactory_
>>
>> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
>
> Justin Lu has updated the pull request
On Fri, 6 Jan 2023 18:54:07 GMT, Justin Lu wrote:
> Removed constructors of primitive wrapper classes (deprecated for removal) in
> _java.util.Arrays_
>
> Replaced with .valueOf() method
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11885
Due to the fact that JLine spawns native processes to obtain terminal
information on macOS/Linux, we decided to disable the JLine by default for
performance degradation reasons. It is still possible to enable it by
specifying it on the command line with `jdk.console` system property (not a
On Fri, 6 Jan 2023 17:42:53 GMT, Justin Lu wrote:
> Removed constructors of primitive wrapper classes (deprecated for removal)
> for the following
> - _java.text.ChoiceFormat_
> - _java.text.MessageFormat_
>
> Replaced with .valueOf() method
LGTM
On Fri, 6 Jan 2023 06:35:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes an issue in the javadoc
> text of the internal class IteratorSpliterator? This addresses the issue
> reported at https://bugs.openjdk.org/browse/JDK-8297306.
Hi Jai, the fix looks good
On Wed, 4 Jan 2023 21:48:26 GMT, Justin Lu wrote:
> Added the missing copyright header
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11854
On Wed, 4 Jan 2023 21:48:26 GMT, Justin Lu wrote:
> Added the missing copyright header
Changes requested by naoto (Reviewer).
test/jdk/java/text/Format/NumberFormat/CurrencySymbols.properties line 2:
> 1: #
> 2: # Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
This
On Wed, 4 Jan 2023 19:57:56 GMT, Naoto Sato wrote:
> This is a pre-requisite fix for upgrading CLDR to v43. The upcoming CLDR
> changed the inheritance mechanism a bit with this change:
> https://unicode-org.atlassian.net/browse/CLDR-15054 where they removed the
> duplica
er buildtool that
> it was not capable of inheriting the partially populated, aliased elements in
> an array object. This changeset also removed the unused logging code.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Removed un
This is a pre-requisite fix for upgrading CLDR to v43. The upcoming CLDR
changed the inheritance mechanism a bit with this change:
https://unicode-org.atlassian.net/browse/CLDR-15054 where they removed the
duplication of data. This revealed an issue in CLDRConverter buildtool that it
was not
On Tue, 3 Jan 2023 23:06:35 GMT, Justin Lu wrote:
>> Regression caused by the fix to
>> [JDK-8296239](https://bugs.openjdk.org/browse/JDK-8296239). The ISO 4217
>> Amendment 174 Update changes went into effect starting in 2023.
>>
>> _java/text/Format/NumberFormat/CurrencyFormat.java_ fails
On Tue, 3 Jan 2023 20:14:30 GMT, Justin Lu wrote:
>> Regression caused by the fix to
>> [JDK-8296239](https://bugs.openjdk.org/browse/JDK-8296239). The ISO 4217
>> Amendment 174 Update changes went into effect starting in 2023.
>>
>> _java/text/Format/NumberFormat/CurrencyFormat.java_ fails
On Tue, 3 Jan 2023 17:40:42 GMT, Justin Lu wrote:
> Regression caused by the fix to
> [JDK-8296239](https://bugs.openjdk.org/browse/JDK-8296239). The ISO 4217
> Amendment 174 Update changes went into effect starting in 2023.
>
> _java/text/Format/NumberFormat/CurrencyFormat.java_ fails as
>
On Thu, 22 Dec 2022 21:25:39 GMT, Stuart Marks wrote:
> It was running as part of tier4 (which is kind of a catch-all tier) but since
> it's (an internal) part of java.util, it should really be in tier1. This adds
> the test/jdk/jdk/internal/util directory to the :jdk_util_other test group.
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote:
> This test isn't part of any test group, so it isn't being run regularly! I'm
> adding it to the jdk_util_other test group.
I think backporting should do in this case (and simpler)
-
PR: https://git.openjdk.org/jdk/pull/11769
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote:
> This test isn't part of any test group, so it isn't being run regularly! I'm
> adding it to the jdk_util_other test group.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11769
On Wed, 21 Dec 2022 23:21:42 GMT, Ichiroh Takiguchi
wrote:
>> test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date.
>> I used following standalone testcase
>>
>> import java.util.Calendar;
>> import java.util.Date;
>> import java.util.SimpleTimeZone;
>>
>> public class
On Wed, 21 Dec 2022 15:57:29 GMT, Ichiroh Takiguchi
wrote:
> test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date.
> I used following standalone testcase
>
> import java.util.Calendar;
> import java.util.Date;
> import java.util.SimpleTimeZone;
>
> public class CheckDST
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote:
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
This pull request has now been i
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since
On Wed, 21 Dec 2022 11:18:25 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced assert with requireNonNull
>
> src/java.base/share/classes/jdk/internal/
On Wed, 21 Dec 2022 00:33:09 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed JdkConsoleProviderImpl, caching INSTANCE
>
> src/java.base/share/classes/jdk/i
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since
On Tue, 20 Dec 2022 14:24:28 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed JdkConsoleProviderImpl, caching INSTANCE
>
> src/java.base/share/classes/jdk/i
On Tue, 20 Dec 2022 14:44:38 GMT, Jaikiran Pai wrote:
>> Actually, I see that it isn't possible for these to be final because we set
>> these up in the `console(...)` instance method of this class. That's because
>> this `JdkConsoleImpl` implements both the `JdkConsole` interface and the
>>
> Moving the built-in implementation of `Console` from `java.io` package into
> `jdk.internal.io` package. It now implements `JdkConsole` interface and is
> accessed through `ProxyingConsole`.
Naoto Sato has updated the pull request incrementally with one additional
commit since
Moving the built-in implementation of `Console` from `java.io` package into
`jdk.internal.io` package. It now implements `JdkConsole` interface and is
accessed through `ProxyingConsole`.
-
Commit messages:
- Split Console_md.c
- 8298971: Move Console implementation into jdk
On Mon, 19 Dec 2022 20:12:15 GMT, Roger Riggs wrote:
> Update javadoc examples to use try-with-resources and use javadoc snippet
> tags.
> The examples in ObjectInputStream and ObjectOutputStream get an update with
> try-with-resources and use of javadoc snippet tags.
> ObjectInputFilter is
On Wed, 14 Dec 2022 23:08:16 GMT, Naoto Sato wrote:
> Fixing `CLDRConverter` build tool to not regard [new
> locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731)
> introduced in CLDR 43 as one of the bas
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
There is another translation drop
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
Marked as reviewed by naoto (Reviewer).
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix https and changed URL back
Thanks for the update, Damon. Looks good for this
On Fri, 9 Dec 2022 20:14:53 GMT, Naoto Sato wrote:
> `Console` class now has a couple of internal subclasses within `java.io`
> package. It should be `sealed` and subclasses be declared in the `permits`
> clause. The implementation resided in `Console` class is separated into
>
On Thu, 15 Dec 2022 02:45:48 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed trailing whitespace
Changes requested by naoto (Reviewer).
On Thu, 15 Dec 2022 17:45:38 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> newUnsupportedOperationException(), cosmetic changes to method descs
>
> src/j
> `Console` class now has a couple of internal subclasses within `java.io`
> package. It should be `sealed` and subclasses be declared in the `permits`
> clause. The implementation resided in `Console` class is separated into
> `ConsoleImpl` class.
Naoto Sato has updated the
On Thu, 15 Dec 2022 12:24:34 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved echo() to ConsoleImpl, clean-ups
>
> src/java.base/share/classes/java/io/Co
> `Console` class now has a couple of internal subclasses within `java.io`
> package. It should be `sealed` and subclasses be declared in the `permits`
> clause. The implementation resided in `Console` class is separated into
> `ConsoleImpl` class.
Naoto Sato has updated the
o `java.base` module, then a test case fails.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Allow Latin script by default
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11684/files
- new: https://git.openjdk.org/jd
Fixing `CLDRConverter` build tool to not regard [new
locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731)
introduced in CLDR 43 as one of the base locales. Otherwise they would
incorrectly go into `java.base` module,
On Wed, 14 Dec 2022 02:16:41 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved echo() to ConsoleImpl, clean-ups
>
> src/java.base/share/classes/java/io/Consol
On Wed, 14 Dec 2022 08:46:58 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four addi
> `Console` class now has a couple of internal subclasses within `java.io`
> package. It should be `sealed` and subclasses be declared in the `permits`
> clause. The implementation resided in `Console` class is separated into
> `ConsoleImpl` class.
Naoto Sato has updated the
On Tue, 13 Dec 2022 04:36:24 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four addi
> `Console` class now has a couple of internal subclasses within `java.io`
> package. It should be `sealed` and subclasses be declared in the `permits`
> clause. The implementation resided in `Console` class is separated into
> `ConsoleImpl` class.
Naoto Sato has updated the
`Console` class now has a couple of internal subclasses within `java.io`
package. It should be `sealed` and subclasses be declared in the `permits`
clause.
-
Commit messages:
- tidying up
- sealed Console, impl/if separation
Changes: https://git.openjdk.org/jdk/pull/11615/files
On Fri, 9 Dec 2022 18:32:37 GMT, Naoto Sato wrote:
> The example in `Scanner` directly uses `System.in` which may cause unwanted
> behavior when the default charset and the console charset differ. Using
> `Console.reader()` is more appropriate. Also changed examples into snippets.
On Sat, 10 Dec 2022 08:15:49 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified @link comment in the snippet
>
> src/java.base/share/classes/java/util/
> The example in `Scanner` directly uses `System.in` which may cause unwanted
> behavior when the default charset and the console charset differ. Using
> `Console.reader()` is more appropriate. Also changed examples into snippets.
Naoto Sato has updated the pull request incrementally
On Fri, 9 Dec 2022 18:32:37 GMT, Naoto Sato wrote:
> The example in `Scanner` directly uses `System.in` which may cause unwanted
> behavior when the default charset and the console charset differ. Using
> `Console.reader()` is more appropriate. Also changed examples into snipp
On Fri, 9 Dec 2022 18:32:37 GMT, Naoto Sato wrote:
> The example in `Scanner` directly uses `System.in` which may cause unwanted
> behavior when the default charset and the console charset differ. Using
> `Console.reader()` is more appropriate. Also changed examples into snippe
The example in `Scanner` directly uses `System.in` which may cause unwanted
behavior when the default charset and the console charset differ. Using
`Console.reader()` is more appropriate. Also changed examples into snippets.
-
Commit messages:
- 8297288: Example code in Scanner
On Tue, 6 Dec 2022 18:10:38 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 99:
>>
>>> 97: */
>>> 98:
>>> 99: public class Console implements Flushable
>>
>> Should we perhaps `seal` this class and only `perm
On Tue, 29 Nov 2022 19:38:02 GMT, Naoto Sato wrote:
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementat
On Wed, 7 Dec 2022 18:57:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/io/ProxyingCo
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined comments, no-op in WrappingReader/Writer::close()
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Wed, 7 Dec 2022 11:54:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Making the wrapper classes static
>
> src/java.base/share/classes/java/io/Co
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Making the wrapper classes static
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Synchronize reader/writer by wrapping them
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
On Tue, 6 Dec 2022 19:17:44 GMT, Naoto Sato wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console im
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Further addressing review comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
On Tue, 6 Dec 2022 07:34:45 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/Console.java line 616:
>>
>>> 614:
>>> JdkConsoleProvider.DEFAULT_PROVIDER_MODULE_NAME);
>>> 615: return
>>>
On Tue, 6 Dec 2022 06:19:37 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed the copyright year
>
> src/java.base/share/classes/java/io/Console.java line 9
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 22 additional commits
On Mon, 5 Dec 2022 14:38:51 GMT, Andrew John Hughes wrote:
>> Update to the latest tzdata, 2022g.
>>
>> Primary changes:
>> * `America/Ojinaga` (CST) is split, creating `America/Ciudad_Juarez`
>> (MST/MDT)
>> * `America/Pangnirtung` becomes a link to `America/Iqaluit`
>> * `America/Ojinaga`
On Mon, 5 Dec 2022 14:38:51 GMT, Andrew John Hughes wrote:
>> Update to the latest tzdata, 2022g.
>>
>> Primary changes:
>> * `America/Ojinaga` (CST) is split, creating `America/Ciudad_Juarez`
>> (MST/MDT)
>> * `America/Pangnirtung` becomes a link to `America/Iqaluit`
>> * `America/Ojinaga`
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Fixed the copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
- new: https://
On Sun, 4 Dec 2022 17:09:15 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed the expected behavior when the SecurityManager is enabled
>
> src/java.base/shar
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
oleole -> ole
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
- new: https://git.op
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing review comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11421/files
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Changed the expected behavior when the SecurityManager is enabled
-
Changes:
- all: https://git.openj
On Wed, 30 Nov 2022 18:07:07 GMT, Andrew John Hughes wrote:
> Update to the latest tzdata, 2022g.
>
> Primary changes:
> * `America/Ojinaga` (CST) is split, creating `America/Ciudad_Juarez` (MST/MDT)
> * `America/Pangnirtung` becomes a link to `America/Iqaluit`
> * `America/Ojinaga` gains DST
On Fri, 2 Dec 2022 15:21:40 GMT, Weijun Wang wrote:
>> Naoto has confirmed that the password prompt from keytool does not echo,
>> good!
>>
>> The intention is that Console be usable in jshell so I think the issue is
>> that readPassword is echo'ing when used in jshell. Maybe someone
>>
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added more tests, loading with doPrivileged()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1142
On Thu, 1 Dec 2022 19:37:28 GMT, Jonathan Gibbons wrote:
>> src/java.base/share/classes/java/lang/Character.java line 172:
>>
>>> 170: * occur. For example, in a future release, synchronization may fail.
>>> 171: *
>>> 172: * @spec https://www.unicode.org/reports/tr27 Unicode 3.1.0
>>
>>
On Thu, 1 Dec 2022 17:53:58 GMT, Weijun Wang wrote:
>> I can still see the password on screen. Here `in` is a
>> `jdk.jshell.execution.Util` so the updated check on line 58 above failed.
>>
>> $ jshell -C--add-exports -Cjava.base/sun.security.tools.keytool=ALL-UNNAMED
>> -R--add-exports
plementation if available.
> A corresponding CSR has been drafted.
Naoto Sato has updated the pull request incrementally with two additional
commits since the last revision:
- Adds a test
- Removed JavaIOAccess.charset() which is no longer needed
-
Changes:
- all: https://git.
On Wed, 30 Nov 2022 17:07:35 GMT, Jim Laskey wrote:
>> This is to allow Console to be used even when it is not attached to the
>> platform provided terminal, such as the case when the standard input is
>> redirected. `System.console()` now returns a Console implementation based on
>>
This is to allow Console to be used even when it is not attached to the
platform provided terminal, such as the case when the standard input is
redirected. `System.console()` now returns a Console implementation based on
`jdk.internal.le` terminal by default, or jshell implementation if
On Mon, 28 Nov 2022 16:52:09 GMT, Weibing Xiao wrote:
> fix the illegal characters of directory names in Windows
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11393
On Mon, 28 Nov 2022 17:53:43 GMT, Justin Lu wrote:
> Problem: Javadoc in Locale.lookup is incorrect. Javadoc should match the
> parameter arguments. See lines 3562-3563.
>
> Fix: For `@throws NullPointerException` replace `if priorityList or tags is
> null` with `if priorityList or locales is
On Fri, 18 Nov 2022 21:22:05 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>>
On Fri, 18 Nov 2022 18:36:51 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the
On Fri, 18 Nov 2022 11:57:40 GMT, Adam Sotona wrote:
> There is a typo in `java -help` referencing -disable-@files instead of
> --disable-@files option.
>
> Please review.
>
> Thanks,
> Adam
Changes in English resource bundles are automatically detected by the
translation process, and each
On Wed, 16 Nov 2022 19:07:48 GMT, Naoto Sato wrote:
> Adding a `@sealedGraph` tag to `ZoneId` class.
This pull request has now been integrated.
Changeset: 8b140e2d
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/8b140e2d747676f6c5f53ccb18cee307e7d3da1c
Stats: 1 l
Adding a `@sealedGraph` tag to `ZoneId` class.
-
Commit messages:
- 8297152: Add a @sealedGraph tag to ZoneId
Changes: https://git.openjdk.org/jdk/pull/11195/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11195=00
Issue: https://bugs.openjdk.org/browse/JDK-8297152
Stats:
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Marked as reviewed by naoto
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote:
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
I just wonder if this change warrants a CSR. If it is merely printing out a
warning, it may not
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Although there aren't actual code
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
>
On Wed, 9 Nov 2022 18:58:30 GMT, Naoto Sato wrote:
> Pick up the fix in the upstream CLDR v42 maintenance branch for their
> tzdata2022f changes.
This pull request has now been integrated.
Changeset: 54c986e7
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/
Pick up the fix in the upstream CLDR v42 maintenance branch for their
tzdata2022f changes.
-
Commit messages:
- 8296715: CLDR v42 update for tzdata 2022f
Changes: https://git.openjdk.org/jdk/pull/11066/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11066=00
Issue:
On Fri, 4 Nov 2022 17:21:04 GMT, Justin Lu wrote:
> Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to
> Euro (to take place on 1/1/2023).
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10994
On Fri, 4 Nov 2022 17:21:04 GMT, Justin Lu wrote:
> Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to
> Euro (to take place on 1/1/2023).
Changes requested by naoto (Reviewer).
src/java.base/share/data/currency/CurrencyData.properties line 192:
> 190: CI=XOF
>
On Thu, 3 Nov 2022 17:23:53 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
901 - 1000 of 1197 matches
Mail list logo
