Re: RFR: 8296250" Update ICU4J to Version 74.1

On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote: > Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74). > This change completes the Unicode 15.1 upgrade. The change is merely > replacing binary data files used for the Normalization and BiDi support Marked as

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v6]

On Wed, 8 Nov 2023 00:52:36 GMT, Shaojin Wen wrote: >> j.u.Formatter now prints "%tF" (iso standard date) and the result is >> incorrect when processing year < 0 or year > > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v2]

On Thu, 9 Nov 2023 09:07:31 GMT, Chen Liang wrote: > Just curious, how does benchmark > StringConstructor.newStringFromCharsMixedBegin change before and after this > patch? If we can see how much of an impact this has on CJK strings it would > be appreciated. You may have better insights

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v2]

nes whether the latin1 or the non-latin1 representation is > returned. > > - The methods that scan for non-latin1 characters and their intrinsic > implementations are updated to return the index of the non-latin1 character. > > - String construction from StringBuilder and CharSequ

RFR: 8319574: Exec/process tests should be marked as flagless

Tests that directly use ProcessBuilder to spawn processes and do not pass the standard test command line arguments should be marked as `vm.flagless` to indicate to the testing infrastructure that they do not accept them and should not be run with extra test command line options `test.vm.opts`

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs

On Wed, 8 Nov 2023 16:47:17 GMT, Raffaello Giulietti wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

On Tue, 7 Nov 2023 19:17:03 GMT, Raffaello Giulietti wrote: >> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, >> throwing `OutOfMemoryError` instead to indicate that the resulting `String` >> would be too large. > > Raffaello Giulietti has updated the pull request

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString()

On Wed, 1 Nov 2023 17:40:04 GMT, Raffaello Giulietti wrote: > Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, > throwing `OutOfMemoryError` instead to indicate that the resulting `String` > would be too large. src/java.base/share/classes/java/math/BigDecimal.java line

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs

On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote: > Strings, after construction, are immutable but may be constructed from > mutable arrays of bytes, characters, or integers. > The string constructors should guard against the effects of mutating the > arrays during constructio

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs

On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote: > Strings, after construction, are immutable but may be constructed from > mutable arrays of bytes, characters, or integers. > The string constructors should guard against the effects of mutating the > arrays during constructio

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v5]

On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v5]

On Tue, 7 Nov 2023 13:45:54 GMT, Claes Redestad wrote: >> test/jdk/java/util/Formatter/BasicDateTime.java line 473: >> >>> 471: "%tF", >>> 472: >>> DecimalFormatSymbols.getInstance(localeEuES).getMinusSign() + "2023-01-13", >>> 473:

Re: RFR: 8319378: Spec for j.util.Timer::purge and j.util.Timer::cancel could be improved

On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote: > Please review this PR which clarifies the definition of a _cancelled_ task in > _j.util.Timer::purge_ and _j.util.Timer::cancel_. > > Timer::purge claims that its return value is the number of tasks in the queue > that were cancelled. This

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v13]

On Mon, 6 Nov 2023 19:53:03 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs

On Sat, 4 Nov 2023 00:07:33 GMT, Chen Liang wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction that might

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs

On Sun, 5 Nov 2023 13:32:20 GMT, ExE Boss wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction that might

RFR: 8311906: Improve robustness of String constructors with mutable array inputs

Strings, after construction, are immutable but may be constructed from mutable arrays of bytes, characters, or integers. The string constructors should guard against the effects of mutating the arrays during construction that might invalidate internal invariants for the correct behavior of

Re: RFR: 8319423: Improve Year.isLeap by checking divisibility by 16 [v2]

On Mon, 6 Nov 2023 00:50:22 GMT, Claes Redestad wrote: > I suggest we go ahead and integrate this, file an RFE to re-examine the > division-by-constant in C2, then re-evaluate these `isLeapYear` micros in > that new environment. These are good improvements and are beneficial with or without

Re: RFR: 8319423: Improve Year.isLeap by checking divisibility by 16 [v2]

On Fri, 3 Nov 2023 23:22:27 GMT, Claes Redestad wrote: >> https://github.com/cassioneri/eaf suggest this code for leap year >> calculation: >> >> public static boolean isLeap(long year) { >> int d = year % 100 != 0 ? 4 : 16; >> return (year & (d - 1)) == 0; >> } >> >>

Re: RFR: 8319423: Improve Year.isLeap by checking divisibility by 16

On Fri, 3 Nov 2023 12:03:24 GMT, Claes Redestad wrote: > https://github.com/cassioneri/eaf suggest this code for leap year calculation: > > public static boolean isLeap(long year) { > int d = year % 100 != 0 ? 4 : 16; > return (year & (d - 1)) == 0; > } > > .. with a

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v3]

On Mon, 16 Oct 2023 20:52:10 GMT, Shaojin Wen wrote: >> j.u.Formatter now prints "%tF" (iso standard date) and the result is >> incorrect when processing year < 0 or year > > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

On Thu, 2 Nov 2023 14:25:20 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the

Re: RFR: 8319323: FFM: Harmonize the @throws tags in the javadocs

On Thu, 2 Nov 2023 14:46:49 GMT, Per Minborg wrote: > This PR proposes to harmonize the @throws tags in the javadocs for the FFM > API. > > The @throws tags are using a bit different principles with respect to > formatting and ending with a period or not. > > Looking at some prominent Java

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

On Thu, 2 Nov 2023 15:57:15 GMT, Mandy Chung wrote: >> The test fails on windows because unmatched comparison of `Path.toString()` >> vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to >> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. > > Mandy

Re: RFR: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" [v2]

On Wed, 1 Nov 2023 19:46:33 GMT, Mandy Chung wrote: >> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for >> 5 seconds and then grab the output. Then run `jcmd` to dump the thread >> stacks in case there is a deadlock. The test ignores and swallows any >> exception

Re: RFR: 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false"

On Wed, 1 Nov 2023 17:54:00 GMT, Mandy Chung wrote: > `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for 5 > seconds and then grab the output. Then run `jcmd` to dump the thread stacks > in case there is a deadlock. The test ignores and swallows any exception > which

Re: RFR: 8318962: Update ProcessTools javadoc with suggestions in 8315097 [v2]

On Tue, 31 Oct 2023 17:15:50 GMT, Leo Korinth wrote: >> Updates to javadoc after improvement ideas in the review of 8315097. I have >> also removed the incomplete invocation command line. I also removed >> incomplete information in `executeTestJvm` and added a link to >>

Re: RFR: 8318962: Javadoc: Update ProcessTools after suggestions in 8315097 [v2]

On Tue, 31 Oct 2023 17:15:50 GMT, Leo Korinth wrote: >> Updates to javadoc after improvement ideas in the review of 8315097. I have >> also removed the incomplete invocation command line. I also removed >> incomplete information in `executeTestJvm` and added a link to >>

Re: RFR: 8315004: Runtime.halt() debug logging

On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote: > I want to add a log output similar to JDK-8301627 to Runtime.halt(). > To avoid double logging of Runtime.exit(), add a flag to indicate whether > logging was done, and fix it so that logging is done only once. > Could someone please

Re: RFR: 8318962: Javadoc: Update ProcessTools after suggestions in 8315097

On Tue, 31 Oct 2023 07:19:53 GMT, Leo Korinth wrote: > Updates to javadoc after improvement ideas in the review of 8315097. I have > also removed the incomplete invocation command line. I also removed > incomplete information in `executeTestJvm` and added a link to >

Re: RFR: 8315097: Rename createJavaProcessBuilder [v7]

On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It

Re: RFR: 8315097: Rename createJavaProcessBuilder [v7]

On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v3]

On Tue, 24 Oct 2023 22:57:59 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It

Re: RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v3]

On Tue, 24 Oct 2023 17:58:48 GMT, Naoto Sato wrote: >> Spec clarification of `ListFormat.equals()` method, utilizing newly >> introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also >> been drafted. > > Naoto Sato has updated the pull request incrementally with one

Re: RFR: 8318051: Duration.between uses exceptions for control flow

On Mon, 23 Oct 2023 17:33:48 GMT, Eamonn McManus wrote: > The existing logic uses nanosecond arithmetic to compute Duration.between. > Since that can overflow for durations greater than 292 years, it has a > try/catch that falls back to computing the seconds part and adjusting that > for

Re: RFR: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11 [v2]

On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote: >> Windows 11 does not reserve as many names as prior versions of Windows so do >> not expect exceptions for COM7 and LPT1. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8317612: ChoiceFormat and MessageFormat constructors call non-final public method [v2]

On Fri, 6 Oct 2023 18:07:37 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630) >> which makes the implications of overriding _ChoiceFormat::applyPattern_ and >> _MessageFormat::applyPattern_ apparent by adding a implSpec tag to the >> method.

Re: RFR: 8318051: Duration.between uses exceptions for control flow

On Mon, 23 Oct 2023 17:33:48 GMT, Eamonn McManus wrote: > The existing logic uses nanosecond arithmetic to compute Duration.between. > Since that can overflow for durations greater than 292 years, it has a > try/catch that falls back to computing the seconds part and adjusting that > for

Re: RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat

On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two >

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comment. > > Thanks for your review comments. I will implement them and push again.

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v5]

On Wed, 18 Oct 2023 16:39:47 GMT, Alan Bateman wrote: > We have to be very careful with proposals like this as it means code outside > of java.lang having access to the underlying bytes. I think other > alternatives needs to be explored to avoid this and related concerns. Yes, adding another

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v5]

On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]

On Sun, 15 Oct 2023 16:36:33 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Corrected use of whitespace in text block.

Re: RFR: JDK-8318415: Adjust describing comment of os_getChildren after 8315026

On Wed, 18 Oct 2023 08:18:47 GMT, Matthias Baesken wrote: > 8315026 adjusted and improved the describings comments already for AIX/Linux. > But macOS was not adjusted. Thanks for the updates. - Marked as reviewed by rriggs (Reviewer). PR Review:

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v5]

On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8316150: Refactor get chars and string size

On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote: > 1. Reduce duplicate stringSize code > 2. Move java.lang.StringLatin1.getChars to > jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other > packages also need to use this method There's a lot of duplication exposed here

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v9]

On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Tests with base64 input are removed.

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v9]

On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Tests with base64 input are removed.

Re: RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty wrote: > Trivial ProblemListing for some tests: > > [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList > runtime/CompressedOops/CompressedClassPointers.java on two platforms >

Integrated: 8317956: Make jdk.internal.util.Architecture current architecture final

On Wed, 11 Oct 2023 13:25:14 GMT, Roger Riggs wrote: > The static for the current architecture should be final to allow some > optimizations. This pull request has now been integrated. Changeset: c1f698d3 Author: Roger Riggs URL: https://git.openjdk.org/jdk/

Re: RFR: JDK-8315026: ProcessHandle implementation listing processes on AIX should use getprocs64 [v5]

On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote: >> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX >> in TreeTest.test5. >> The reason is: Previously the implementation based on the /proc file system >> lead to double pids in the child list; at least

Re: RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5 [v5]

On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote: >> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX >> in TreeTest.test5. >> The reason is: Previously the implementation based on the /proc file system >> lead to double pids in the child list; at least

Re: RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5 [v4]

On Wed, 11 Oct 2023 14:07:00 GMT, Joachim Kern wrote: >> The callers in ProcessHandlerImpl depend on knowing the parent pid for each >> process. >> They are used to find the descendants of a process. When reading /proc >> that's necessary. > > @RogerRiggs Roger you are most familiar with

Re: RFR: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage

On Wed, 11 Oct 2023 08:07:31 GMT, Per Minborg wrote: > This PR proposes to Add @sealedGraph to `StringTemplate.Processor.Linkage` Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16141#pullrequestreview-1671316636

Re: RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5 [v4]

On Wed, 11 Oct 2023 12:20:00 GMT, Matthias Baesken wrote: >> Hi Thomas, this function is just the same as the linux and macos >> implementation. And I do not want to make more changes as really needed, >> otherwise the siblings character gets lost. Following your proposal means to >> do the

RFR: 8317956: Make jdk.internal.util.Architecture current architecture final

The static for the current architecture should be final to allow some optimizations. - Commit messages: - 8317956: Make jdk.internal.util.Archecture current architecture final Changes: https://git.openjdk.org/jdk/pull/16150/files Webrev:

Re: RFR: 8317742: ISO Starndard Date Format implementation consistency on DateTimeFormatter and String.format [v2]

On Mon, 9 Oct 2023 23:21:57 GMT, Shaojin Wen wrote: >> j.u.Formatter now prints "%tF" (iso standard date) and the result is >> incorrect when processing year < 0 or year > > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: JDK-8315026: java/lang/ProcessHandle/TreeTest.java fails intermittent on AIX in TreeTest.test5 [v3]

On Tue, 10 Oct 2023 09:36:47 GMT, Joachim Kern wrote: >> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX >> in TreeTest.test5. >> The reason is: Previously the implementation based on the /proc file system >> lead to double pids in the child list; at least

Re: RFR: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements [v3]

On Tue, 10 Oct 2023 14:27:13 GMT, Claes Redestad wrote: >> Alternative to #16082 >> >> Name (unchanged) Cnt Base Error Test >> Error Unit Change >> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± >> 0,007 ms/op 1,09x (p = 0,000*)

Re: RFR: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements

On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote: > Alternative to #16082 > > Name (unchanged) Cnt Base Error Test Error > Unit Change > URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007 > ms/op 1,09x (p = 0,000*) >

Re: RFR: 8317742: ISO Starndard Date Format implementation consistency on DateTimeFormatter and String.format

On Tue, 3 Oct 2023 21:37:46 GMT, 温绍锦 wrote: > j.u.Formatter now prints "%tF" (iso standard date) and the result is > incorrect when processing year < 0 or year > The CSR is created, if you can provide (as a comment on the PR) the descriptions as described in the template, I can put them

Re: RFR: 8317742: ISO Starndard Date Format implementation consistency on DateTimeFormatter and String.format

On Tue, 3 Oct 2023 21:37:46 GMT, 温绍锦 wrote: > j.u.Formatter now prints "%tF" (iso standard date) and the result is > incorrect when processing year < 0 or year > This PR will need an evaluation of the compatibility risk of changing the behavior, describing existing uses and scope and how

Re: 回复：Adding appendHex method to StringBuilder

Hi, The j.u.HexFormat class has methods that append hex formatted byte arrays to an Appendable such as StringBuilder. The `toHexDigits` methods return strings with the hex values of byte, short, char, int, and long. Similar `formatHex` methods could be added with an Appendable argument

Re: ISO Starndard Date Format implementation consistency on DateTimeFormatter and String.format

Hi, Java.time has a clear definition of negative years. It would need a closer look as to j.u.Formatter's interpretation of negative years, though it should be consistent for j.t.LocalDate. Created: 8317742 ISO Starndard Date Format

Re: RFR: 8316974: ListFormat creation is unsuccessful for some of the supported Locales [v3]

On Wed, 27 Sep 2023 19:06:26 GMT, Naoto Sato wrote: >> Some CLDR locales have partial list patterns, such as only the "end" >> pattern, and expect "start" and "middle" patterns to be inherited from >> parent locales. Made the code capable of the inheritance. > > Naoto Sato has updated the pull

Re: RFR: 8316974: ListFormat creation is unsuccessful for some of the supported Locales [v2]

On Tue, 26 Sep 2023 22:27:55 GMT, Naoto Sato wrote: >> Some CLDR locales have partial list patterns, such as only the "end" >> pattern, and expect "start" and "middle" patterns to be inherited from >> parent locales. Made the code capable of the inheritance. > > Naoto Sato has updated the pull

Re: RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v6]

On Wed, 27 Sep 2023 14:13:05 GMT, Aleksei Voitylov wrote: >> test java.lang.String.RegionMatches1Tests fails on all platforms with >> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by >> default. The fix is to return true immediately if len is negative, since for

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v8]

On Wed, 27 Sep 2023 09:07:44 GMT, 温绍锦 wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and

Integrated: 8315721: CloseRace.java#id0 fails transiently on libgraal

On Tue, 26 Sep 2023 17:03:00 GMT, Roger Riggs wrote: > The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp. > The problem appears with the Graal compiler but may also occur on other > platforms. This pull request has now been integrated. Changeset: 1be355

Re: RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v5]

On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov wrote: >> test java.lang.String.RegionMatches1Tests fails on all platforms with >> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by >> default. The fix is to return true immediately if len is negative, since for

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v7]

On Tue, 19 Sep 2023 14:30:18 GMT, 温绍锦 wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v7]

On Tue, 19 Sep 2023 14:30:18 GMT, 温绍锦 wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and

RFR: 8315721: CloseRace.java#id0 fails transiently on libgraal

The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp. The problem appears with the Graal compiler but may also occur on other platforms. - Commit messages: - 8315721: CloseRace.java#id0 fails transiently on libgraal Changes:

Re: RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v4]

On Tue, 26 Sep 2023 16:18:09 GMT, Aleksei Voitylov wrote: >> test java.lang.String.RegionMatches1Tests fails on all platforms with >> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by >> default. The fix is to return true immediately if len is negative, since for

Re: RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v3]

On Tue, 26 Sep 2023 14:06:56 GMT, Aleksei Voitylov wrote: >> test java.lang.String.RegionMatches1Tests fails on all platforms with >> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by >> default. The fix is to return true immediately if len is negative, since for

Re: RFR: 8316150: Refactor get chars and string size [v21]

On Sun, 24 Sep 2023 02:46:38 GMT, 温绍锦 wrote: >> 1. Reduce duplicate stringSize code >> 2. Move java.lang.StringLatin1.getChars to >> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other >> packages also need to use this method > > 温绍锦 has updated the pull request

Re: RFR: 8311906: Race condition in String constructor

On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote: > In the constructor of String, many locations the user-supplied byte or char > arrays are read multiple times with a plain memory access; if a user > previously wrote to one of such locations out of happens-before order, > distinct plain

Re: RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v9]

On Thu, 21 Sep 2023 15:35:16 GMT, Brian Burkhalter wrote: >> Add a `finally` block to delete the created files. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8315960: Use assertEquals Looking good. It may be useful

Re: Integrated: 8316582: Minor startup regression in 22-b15 due JDK-8310929

On Wed, 20 Sep 2023 09:12:48 GMT, Claes Redestad wrote: > This patch reverts the use of `ByteArrayLittleEndian` in `StringLatin1`. > > This use is the cause of a small (~1.5ms) startup regression in 22-b15. While > a manageable startup regression in and of itself, the use of `VarHandles` in

Re: RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v7]

On Tue, 19 Sep 2023 21:45:13 GMT, Brian Burkhalter wrote: >> Add a `finally` block to delete the created files. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8315960: Fix indentation

Re: RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v5]

On Tue, 19 Sep 2023 20:53:44 GMT, Brian Burkhalter wrote: >> Add a `finally` block to delete the created files. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8315960: Improve test as suggested by Reviewer

Re: RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v4]

On Fri, 15 Sep 2023 21:51:22 GMT, Brian Burkhalter wrote: >> Add a `finally` block to delete the created files. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8315960: Remove vestigial unused import

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]

On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote: >> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest

Re: RFR: 8315999: Improve Date toString performance [v13]

On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote: >> improve date toString performance, includes: >> >> java.util.Date.toString >> java.util.Date.toGMTString >> java.time.Instant.toString >> java.time.LocalDate.toString >> java.time.LocalDateTime.toString >> java.time.LocalTime.toString > > 温绍锦 has

Re: RFR: 8316150: Refactor get chars and string size [v4]

On Wed, 13 Sep 2023 14:08:15 GMT, 温绍锦 wrote: >> 1. Reduce duplicate stringSize code >> 2. Move java.lang.StringLatin1.getChars to >> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other >> packages also need to use this method > > 温绍锦 has updated the pull request

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v6]

On Tue, 19 Sep 2023 10:41:51 GMT, 温绍锦 wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v6]

On Tue, 19 Sep 2023 01:35:49 GMT, 温绍锦 wrote: >> The original (and current) is coded to avoid a condition inside the loop. > > I also think that the way of writing for_0 combined with if > 0 is easier to > understand, The operation overhead of if > 0 is very small, and it will not > affect

Re: RFR: 8316426: Optimization for HexFormat.formatHex

On Fri, 15 Sep 2023 18:04:29 GMT, 温绍锦 wrote: > In the improvement of @cl4es PR #15591, the advantages of non-lookup-table > were discussed. > > But if the input is byte[], using lookup table can improve performance. > > For HexFormat#formatHex(Appendable, byte[]) and

Re: RFR: 8316426: Optimization for HexFormat.formatHex

On Mon, 18 Sep 2023 13:40:48 GMT, Chen Liang wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and

Re: RFR: 8316426: Optimization for HexFormat.formatHex

On Fri, 15 Sep 2023 22:19:53 GMT, 温绍锦 wrote: > HexDecimal#DIGITS is a table with a size of 512 bytes. I think that in such a > table, when it needs to be used continuously, it is worthwhile to perform > table lookup operations. HexFormat was designed for presenting bytes to humans, typical

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v7]

On Mon, 4 Sep 2023 06:50:18 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >>

Re: RFR: 8316160: Remove sun.misc.Unsafe.{shouldBeInitialized,ensureClassInitialized}

On Wed, 13 Sep 2023 09:50:35 GMT, Alan Bateman wrote: > Unsafe.{shouldBeInitialized,ensureClassInitialized} are deprecated for > removal since JDK 15. It's time to remove them. > Lookup.ensureInitialized(Class) was added in Java 15 as a standard API to > ensure that an accessible class is

Re: RFR: 8316190: Improve MemorySegment::toString

On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote: > This PR proposes to improve the MemorySegment::toString to reduce cluttering > and add missing comas. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15740#pullrequestreview-1626999067

Re: RFR: 8316190: Improve MemorySegment::toString

On Thu, 14 Sep 2023 12:02:53 GMT, Per Minborg wrote: >> This PR proposes to improve the MemorySegment::toString to reduce cluttering >> and add missing comas. > > src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277: > >> 275: } >> 276: >> 277: public static String

Re: RFR: 8315789: Minor HexFormat performance improvements [v2]

On Fri, 8 Sep 2023 10:32:40 GMT, Claes Redestad wrote: >> This PR seeks to improve formatting of hex digits using >> `java.util.HexFormat` somewhat. >> >> This is achieved getting rid of a couple of lookup tables, caching the >> result of `HexFormat.of().withUpperCase()`, and removing tiny

Re: RFR: 8315999: Improve Date toString performance [v13]

On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote: >> improve date toString performance, includes: >> >> java.util.Date.toString >> java.util.Date.toGMTString >> java.time.Instant.toString >> java.time.LocalDate.toString >> java.time.LocalDateTime.toString >> java.time.LocalTime.toString > > 温绍锦 has

Re: RFR: 8315999: Improve Date toString performance [v13]

On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote: >> improve date toString performance, includes: >> >> java.util.Date.toString >> java.util.Date.toGMTString >> java.time.Instant.toString >> java.time.LocalDate.toString >> java.time.LocalDateTime.toString >> java.time.LocalTime.toString > > 温绍锦 has

<    1   2   3   4   5   6   7   8   9   10   >