On Thu, 6 Apr 2023 22:44:52 GMT, Phil Race wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded qualified export from java.base to jdk.attach
>
> src/jdk.accessibilit
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> -
On Mon, 3 Apr 2023 17:43:55 GMT, Raffaello Giulietti
wrote:
> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in
> addition to the substrings returned by current `split()` variants, also
> return the delimiters matching the regular expression.
On Thu, 6 Apr 2023 20:42:26 GMT, Glavo wrote:
>> There is no benefit to preemptively defining a full set of architectures; we
>> only need those that are used in the OpenJDK runtime selection of options or
>> parameters.
>> The other and unknown cases can be handled in code using switch as
On Thu, 6 Apr 2023 20:38:02 GMT, Thomas Stuefe wrote:
> Another question, how does this work with Zero?
Zero is orthogonal to architecture; the interpreter is compiled for a specific
target architecture.
-
PR Comment: https://git.openjdk.org/jdk/pull/13357#issuecomment-1499606550
On Thu, 6 Apr 2023 20:28:29 GMT, Thomas Stuefe wrote:
> What about PPC (big endian)? Used on AIX?
I'm not aware of any code (in OpenJDK) related to big/little endian that is
derived from `os.arch`.
>
> On Arm, it may be useful to know whether we built for thumb mode (We recently
> had this
On Thu, 6 Apr 2023 19:55:07 GMT, Glavo wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unneeded qualified export from java.base to jdk.attach
>
> src/java.base/s
s in `java.base` and a few others are included but other modules will be
> done in separate PRs.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove unneeded qualified export from java.base to jdk.attach
-
Changes:
On Thu, 6 Apr 2023 18:44:02 GMT, Alan Bateman wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to Foreign API to avoid class with another PR
>> Rename S390X to S3
s in `java.base` and a few others are included but other modules will be
> done in separate PRs.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove obsolete conditions in Windows AttachProviderImpl.
All platforms and architectu
s in `java.base` and a few others are included but other modules will be
> done in separate PRs.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Revert changes to Foreign API to avoid class with another PR
Rename S390X to S390, rep
On Thu, 6 Apr 2023 15:27:49 GMT, David M. Lloyd wrote:
>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 47:
>>
>>> 45:
>>> 46: // Cache a copy of the array for lightweight indexing
>>> 47: private static final Architecture[] archValues =
>>>
On Thu, 6 Apr 2023 03:17:57 GMT, ExE Boss wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/s
On Thu, 6 Apr 2023 07:41:48 GMT, Per Minborg wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/s
On Thu, 6 Apr 2023 08:05:14 GMT, ExE Boss wrote:
>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 85:
>>
>>> 83: */
>>> 84: @ForceInline
>>> 85: public static boolean isRISCV64() {
>>
>> Are all the "isers" necessary to provide constant code folding or is
On Wed, 5 Apr 2023 23:39:00 GMT, Jorn Vernee wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> test/jdk/java/foreign/Test
On Thu, 6 Apr 2023 03:17:37 GMT, ExE Boss wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/s
On Wed, 5 Apr 2023 20:31:43 GMT, Bernd wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> test/jdk/jdk/internal/util/A
On Wed, 5 Apr 2023 20:25:43 GMT, Bernd wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/share/classes/jdk/i
s in `java.base` and a few others are included but other modules will be
> done in separate PRs.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Correct spelling of isAARCH64 in WIndows AttachProviderImpl
-
Changes:
s in `java.base` and a few others are included but other modules will be
> done in separate PRs.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Correct name of isRISCV64 method.
-
Changes:
- all: https://git.open
s in `java.base` and a few others are included but other modules will be
> done in separate PRs.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Rename isXXX method to be uppercase architecture names matching the enum.
Refactor the
On Wed, 5 Apr 2023 16:23:08 GMT, Glavo wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86,
Define an internal jdk.internal.util.Architecture enumeration and static
methods to replace uses of the system property `os.arch`.
The enumeration values are defined to match those used in the build.
The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, PPC64LE`
Note that `amd64`
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> -
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets,
> - jdk.net,
> -
On Wed, 5 Apr 2023 08:37:27 GMT, Alan Bateman wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the
>> system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> -
On Wed, 5 Apr 2023 08:39:35 GMT, Alan Bateman wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the
>> system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> -
On Tue, 4 Apr 2023 20:15:52 GMT, Naoto Sato wrote:
>> Introducing new regex constructs that match those 6 new Unicode Emoji
>> properties implemented in the `Character` class
>> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
>> drafted.
>
> Naoto Sato has updated
On Tue, 4 Apr 2023 17:10:09 GMT, Naoto Sato wrote:
>> Introducing new regex constructs that match those 6 new Unicode Emoji
>> properties implemented in the `Character` class
>> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
>> drafted.
>
> Naoto Sato has updated
With the addition of `jdk.internal.util.OperatingSystem` references to the
system property `os.name` can be replaced.
This PR exports jdk.internal.util to:
- java.prefs,
- java.security.jgss,
- java.smartcardio,
- jdk.charsets,
- jdk.net,
- jdk.zipfs
-
Commit messages:
- In
On Tue, 4 Apr 2023 11:09:24 GMT, Alan Bateman wrote:
>> Early on during this PR, we decided and implemented to read the
>> `ModuleTarget` only if the java.base module's file path doesn't match that
>> of the current platform's file path. If we remove that check and instead
>> always read the
On Sat, 1 Apr 2023 17:34:37 GMT, Joe Darcy wrote:
> The StringBuilder and StringBuffer classes are Appendable by virtue of from
> subclasses their non-public superclass AbstractStringBuilder.
>
> It is slightly clearer to declare StringBuilder and StringBuffer to directly
> implement
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote:
>> Modify the `Space` instances used for size comparison to be created with
>> total number of bytes derived from the Windows `diskFree` utility instead of
>> Cygwin’s `df`.
>
> Brian Burkhalter has updated the pull request
Hi Raffaello,
It sounds useful to return the delimiters in a new API.
It might be interesting to guarantee the array returns n strings and n-1
delimiters; filling with an empty string at the beginning and end if the
input starts with or ends with a delimiter.
Similar to the construction of
On Fri, 3 Mar 2023 19:26:52 GMT, Roger Riggs wrote:
> Runtime.exec and ProcessBuilder.start methods create a new operating system
> process with the program and arguments. Many applications configure a logging
> subsystem to monitor application events. Logging a process star
On Wed, 29 Mar 2023 11:28:53 GMT, Aleksey Shipilev wrote:
> Java API has the `Thread.sleep(millis, nanos)` method exposed to users. The
> documentation for that method clearly says the precision and accuracy are
> dependent on the underlying system behavior. However, it always rounds up
>
On Wed, 29 Mar 2023 16:09:18 GMT, Raffaello Giulietti
wrote:
>
> Would it make sense to throw an `AssertionError` in the constructor? Just in
> case...
It hardly seems worth the bytecode; the constructor could only be invoked by
breaking in using reflection and the result would be an
On Wed, 29 Mar 2023 08:13:06 GMT, Per Minborg wrote:
> Non-instantiable utility classes should be declared `final` and have a
> private constructors.
>
> See Effective Java, Third Edition, Joshua Bloch (for example, Item 19 or Item
> 22).
The CSR implies that java.util.Arrays has a
On Mon, 27 Feb 2023 22:05:20 GMT, Brian Burkhalter wrote:
>> Modify the `Space` instances used for size comparison to be created with
>> total number of bytes derived from the Windows `diskFree` utility instead of
>> Cygwin’s `df`.
>
> Brian Burkhalter has updated the pull request with a new
On Wed, 29 Mar 2023 08:13:06 GMT, Per Minborg wrote:
> Non-instantiable utility classes should be declared `final` and have a
> private constructors.
>
> See Effective Java, Third Edition, Joshua Bloch (for example, Item 19 or Item
> 22).
Marked as reviewed by rriggs (Reviewer).
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Update wording to add
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
>
> After:
>
On Mon, 27 Mar 2023 21:12:28 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
On Tue, 28 Mar 2023 18:25:21 GMT, Naoto Sato wrote:
> Fixing a documentation bug for `CharacterCodingException` without any
> description to it as attached. A corresponding CSR is also drafted.
>
>  in `java.lang.Character`
>> class. This is per a request from the client group, as well as refining the
>>
On Wed, 15 Mar 2023 18:47:09 GMT, Raffaello Giulietti
wrote:
>> Remove instantiation of `StringBuilder`
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8291598: Matcher.appendReplacement should not create new
On Tue, 14 Mar 2023 15:49:56 GMT, Naoto Sato wrote:
>> Proposing accessor methods to Emoji properties defined in [Unicode Technical
>> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character`
>> class. This is per a request from the client group, as well as refining the
>>
On Tue, 14 Mar 2023 15:04:47 GMT, Alan Bateman wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation and improve exception message
>
> src/java.base/share/classes/jdk/inte
s with `os.name`
> - Clear and consistent use across build, runtime, and JDK modules
>
> The PR includes updates within java.base to use the new API.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Cover defa
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove dead code and
s with `os.name`
> - Clear and consistent use across build, runtime, and JDK modules
>
> The PR includes updates within java.base to use the new API.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Fix indentation and i
On Fri, 10 Mar 2023 21:34:56 GMT, Roger Riggs wrote:
>> Runtime.exec and ProcessBuilder.start methods create a new operating system
>> process with the program and arguments. Many applications configure a
>> logging subsystem to monitor application events. Logging a process
On Fri, 10 Mar 2023 05:42:18 GMT, David Holmes wrote:
>> Good point. `OperatingSystemProps.java` can be a OS-specific class like:
>>
>> src/java.base/macosx/classes/jdk/internal/misc/OperatingSystemProps.java
>> linux/classes/jdk/internal/misc/OperatingSystemProps.java
>>
On Mon, 13 Mar 2023 09:48:19 GMT, Daniel Jeliński wrote:
>> This patch modifies the `getLastErrorString` method to return a `jstring`.
>> Thanks to that we can avoid unnecessary back and forth conversions between
>> Unicode and other charsets on Windows.
>>
>> Other changes include:
>> - the
On Fri, 10 Mar 2023 21:21:56 GMT, Roger Riggs wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archi
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Reword @implNote to in
s with `os.name`
> - Clear and consistent use across build, runtime, and JDK modules
>
> The PR includes updates within java.base to use the new API.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Move OperatingSyste
On Fri, 10 Mar 2023 13:35:27 GMT, Raffaello Giulietti
wrote:
>> As a followup of [JDK-8302590](https://bugs.openjdk.org/browse/JDK-8302590),
>> this issue covers the analogous case for a search of a string rather than a
>> character.
>
> Raffaello Giulietti has updated the pull request
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with two additional
commits since the last revision:
- Fix one more i
On Thu, 9 Mar 2023 20:24:11 GMT, Thomas Stuefe wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revise logging of ProcessBuilder.start to support DEBUG and TRACE logging.
>>
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Reorder pid, directo
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already
On Sun, 5 Mar 2023 06:14:49 GMT, Thomas Stuefe wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add javadoc @implNote to Runtime.exec and ProcessBuilder methods
>
> Hi Roger,
>
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.
On Wed, 8 Mar 2023 23:23:38 GMT, Mandy Chung wrote:
> I wonder if `jdk.internal.platform` would be a better home for
> `OperatingSystem` class?
jdk.internal.platform seems to be focused on information about container
environments such as Docker.
jdk.internal.misc already contains other
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Revise logging of Pr
On Thu, 9 Mar 2023 16:05:56 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 98:
>>
>>> 96: @ForceInline
>>> 97: public static boolean isLinux() {
>>> 98: return OperatingSystemProp
On Thu, 9 Mar 2023 17:07:28 GMT, Mandy Chung wrote:
>> The one in the template file is independent to the build variables.
>
>> I would argue that we should keep the replacement string matching the make
>> variable its getting the value from. It makes it easier to trace the origin
>> of the
have OpenJDK 19 and 17 respectively.
On Wed, Mar 8, 2023, 6:54 PM David Holmes wrote:
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs
wrote:
> Improvements to support OS specific customization for JDK
internal use:
> - To select values and code; allowing elimination of
On Wed, 8 Mar 2023 23:09:06 GMT, Mandy Chung wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
On Thu, 9 Mar 2023 00:45:02 GMT, Naoto Sato wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>>
On Thu, 9 Mar 2023 15:24:04 GMT, Erik Joelsson wrote:
>> src/java.base/share/classes/jdk/internal/misc/OperatingSystemProps.java.template
>> line 39:
>>
>>> 37:
>>> 38: // Index/ordinal of the current OperatingSystem enum as substituted
>>> by the build
>>> 39: static final int
On Wed, 8 Mar 2023 23:11:34 GMT, Mandy Chung wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
On Wed, 8 Mar 2023 22:49:05 GMT, Raffaello Giulietti
wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
On Thu, 9 Mar 2023 02:51:24 GMT, David Holmes wrote:
> Has this totally killed of BSD support on the JDK side? I thought building
> non-macOS BSD was still viable, but perhaps not - certainly not after this
> change.
I haven't found any use of BSD and I don't think the build supports a BSD
Improvements to support OS specific customization for JDK internal use:
- To select values and code; allowing elimination of unused code and values
- Optionally evaluated by build processes, compilation, or archiving (i.e. CDS)
- Simple API to replace adhoc comparisons with `os.name`
- Clear
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on
On Sun, 5 Mar 2023 06:14:49 GMT, Thomas Stuefe wrote:
> I think to be even more useful it could make sense to print the current
> directory the child is started in as well as the env var array, possibly only
> with a finer logging level.
There are concerns about exposing potentially sensitive
On Mon, 6 Mar 2023 12:44:57 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add javadoc @implNote to Runtime.exec and ProcessBuilder methods
>
> src/jav
On Sat, 4 Mar 2023 02:22:39 GMT, Naoto Sato wrote:
>> This change is to fix a regression caused by the fix to
>> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix
>> was simply disabling offset-based parsing if the parser was text-based.
>> Instead, check if it is
chooses which utility class
to call based on the native order vs. some other option?
Thanks,
Brett
On Wed, Mar 1, 2023 at 9:08 AM Roger Riggs wrote:
Hi,
That's an interesting idea. Recently VarHandle access methods were
created by JDK-8300236 [1] [2]
in the jdk.internal.util package. See
Hi Albert,
The only downside of the WhiteBox API is the need to link and run with
native code.
It make adhoc testing more difficult.
I would not say ForceGC relies on chance, since it is testing the
specific condition as requested by the caller.
It uses mechanisms available to normal
can identify the caller and purpose.
> Logging the process start event is complementary to the process start event
> generated for JFR (Java Flight Recorder).
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Add javadoc @implNo
701 - 800 of 1131 matches
Mail list logo
