Re: RFR: 8331077 : nroff man page update for jar tool [v2]

2024-05-01 Thread Sean Coffey
On Wed, 1 May 2024 18:42:12 GMT, Weibing Xiao wrote: >> nroff man page update for jar tool. >> This update is caused by the change of  >> https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got >> updated in other repos, the corresponding nroff man page was never updated >>

Integrated: 8329013: StackOverflowError when starting Apache Tomcat with signed jar

2024-04-02 Thread Sean Coffey
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote: > Calling extra logging calls during initialization of Logger libraries can > cause recursion leading to StackOverflowError > This patch adds logic to the EventHelper class to detect recursion and > prevent it. This pull req

Re: RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar [v2]

2024-04-02 Thread Sean Coffey
On Tue, 2 Apr 2024 14:59:33 GMT, Sean Coffey wrote: >> Calling extra logging calls during initialization of Logger libraries can >> cause recursion leading to StackOverflowError >> This patch adds logic to the EventHelper class to detect recursion and >> prevent it. >

Re: RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar

2024-04-02 Thread Sean Coffey
On Tue, 2 Apr 2024 11:16:55 GMT, Jaikiran Pai wrote: >> Calling extra logging calls during initialization of Logger libraries can >> cause recursion leading to StackOverflowError >> This patch adds logic to the EventHelper class to detect recursion and >> prevent it. > > You are right, turns

Re: RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar [v2]

2024-04-02 Thread Sean Coffey
> Calling extra logging calls during initialization of Logger libraries can > cause recursion leading to StackOverflowError > This patch adds logic to the EventHelper class to detect recursion and > prevent it. Sean Coffey has updated the pull request incrementally with one additi

Re: RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar

2024-04-02 Thread Sean Coffey
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote: > Calling extra logging calls during initialization of Logger libraries can > cause recursion leading to StackOverflowError > This patch adds logic to the EventHelper class to detect recursion and > prevent it. Thanks for t

RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar

2024-03-28 Thread Sean Coffey
Calling extra logging calls during initialization of Logger libraries can cause recursion leading to StackOverflowError This patch adds logic to the EventHelper class to detect recursion and prevent it. - Commit messages: - 8329013 Changes:

Re: RFR: 8318812: LauncherHelper.checkAndLoadMain closes jar file that's about to be re-opened [v3]

2024-02-19 Thread Sean Coffey
On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein wrote: >> Please review this PR that makes the launcher helper keep a reference to the >> executable JAR file active after extracting the name of the main class and >> returning it as Class instance. Now, when loading classes from the JAR file,

Re: RFR: 8318812: LauncherHelper.checkAndLoadMain closes jar file that's about to be re-opened [v2]

2024-02-19 Thread Sean Coffey
On Thu, 15 Feb 2024 06:29:24 GMT, Christian Stein wrote: >> Please review this PR that makes the launcher helper keep a reference to the >> executable JAR file active after extracting the name of the main class and >> returning it as Class instance. Now, when loading classes from the JAR file,

Re: RFR: 8325150: (tz) Update Timezone Data to 2024a

2024-02-07 Thread Sean Coffey
On Wed, 7 Feb 2024 08:45:40 GMT, Johny Jose wrote: > Timezone data 2024a changes LGTM - Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17743#pullrequestreview-1867359537

Re: RFR: 8322725: (tz) Update Timezone Data to 2023d

2024-01-04 Thread Sean Coffey
On Thu, 4 Jan 2024 13:34:50 GMT, Johny Jose wrote: > tzdata2023d changes LGTM - Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17268#pullrequestreview-1804359390

Integrated: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process

2023-12-20 Thread Sean Coffey
On Wed, 20 Dec 2023 15:37:37 GMT, Sean Coffey wrote: > trivial test edit to use FileUtils.deleteFileIfExistsWithRetry test library > API > > tested on CI system with test-repeat = 20 - no issues seen. This pull request has now been integrated. Changeset: f6fe39ff Author: Sean

Re: RFR: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process

2023-12-20 Thread Sean Coffey
On Wed, 20 Dec 2023 15:37:37 GMT, Sean Coffey wrote: > trivial test edit to use FileUtils.deleteFileIfExistsWithRetry test library > API > > tested on CI system with test-repeat = 20 - no issues seen. Thanks for the review Lance. I didn't use try-with-resources during test creat

RFR: 8322078: ZipSourceCache.testKeySourceMapping() test fails with The process cannot access the file because it is being used by another process

2023-12-20 Thread Sean Coffey
trivial test edit to use FileUtils.deleteFileIfExistsWithRetry test library API tested on CI system with test-repeat = 20 - no issues seen. - Commit messages: - 8322078 Changes: https://git.openjdk.org/jdk/pull/17169/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17169=00

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-19 Thread Sean Coffey
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) >> which overrides and provides an implementation of `toString()` in >> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > Justin Lu has

Integrated: 8317678: Fix up hashCode() for ZipFile.Source.Key

2023-10-23 Thread Sean Coffey
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote: > Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. This pull request has now been integrated. Changeset: 8d9a4b43 Author: Sean Coffey URL:

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v11]

2023-10-23 Thread Sean Coffey
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v11]

2023-10-23 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Update jmh test comments - Changes:

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v10]

2023-10-23 Thread Sean Coffey
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v10]

2023-10-23 Thread Sean Coffey
On Mon, 23 Oct 2023 13:04:20 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v10]

2023-10-23 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Incorporate test review comments fr

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v9]

2023-10-23 Thread Sean Coffey
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v9]

2023-10-23 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Update code comments - Changes:

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v8]

2023-10-18 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Update lastModifiedTime comment - C

Re: RFR: 8314891: Additional Zip64 extra header validation [v7]

2023-10-18 Thread Sean Coffey
On Mon, 18 Sep 2023 13:17:25 GMT, Lance Andersen wrote: >> Please review this PR which improves the Zip64 extra header validation: >> >> - Throw a ZipException If the extra len field is 0 and : >> -- size, csize, or loc offset are set to 0x >> -- disk starting number is set to 0x >>

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v7]

2023-10-18 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Testcase feedback from Lance - C

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v6]

2023-10-17 Thread Sean Coffey
On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v6]

2023-10-17 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: remove getCanonicalFile calls, update ZipFi

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v5]

2023-10-17 Thread Sean Coffey
On Tue, 17 Oct 2023 08:50:15 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request with a new target base due to a &

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v5]

2023-10-17 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes b

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v4]

2023-10-13 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: minor test edits and comment u

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v3]

2023-10-13 Thread Sean Coffey
On Fri, 13 Oct 2023 08:45:07 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v3]

2023-10-13 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: insert back lastmodified check. enhance testcase

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v2]

2023-10-10 Thread Sean Coffey
On Tue, 10 Oct 2023 12:46:22 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v2]

2023-10-10 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: incorporate review comments - C

RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key

2023-10-10 Thread Sean Coffey
Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source objects aren't created for the same zip file. - Commit messages: - Initial changes Changes: https://git.openjdk.org/jdk/pull/16115/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16115=00 Issue:

Integrated: 8316087: Test SignedLoggerFinderTest.java is still failing

2023-09-13 Thread Sean Coffey
On Wed, 13 Sep 2023 11:26:30 GMT, Sean Coffey wrote: > Some log messages from the test may be dropped if the bootstraplogger is in > use at time of log call. (bootstap logger logs at INFO level, the security > event logger logs at DEBUG level) > > Modify the test to use a patc

RFR: 8316087: Test SignedLoggerFinderTest.java is still failing

2023-09-13 Thread Sean Coffey
Some log messages from the test may be dropped if the bootstraplogger is in use at time of log call. (bootstap logger logs at INFO level, the security event logger logs at DEBUG level) Modify the test to use a patched EventHelper class to let it log at INFO level also, ensuring the bootstrap

Integrated: 8315696: SignedLoggerFinderTest.java test failed

2023-09-08 Thread Sean Coffey
On Tue, 5 Sep 2023 20:06:41 GMT, Sean Coffey wrote: > Update the recently added LoggerFinder tests to cater for a possible > condition where the test finishes before the boot logger executor service has > flushed its pending data. > > By simulating a slow thread in the Execu

RFR: 8315696: SignedLoggerFinderTest.java test failed

2023-09-06 Thread Sean Coffey
Update the recently added LoggerFinder tests to cater for a possible condition where the test finishes before the boot logger executor service has flushed its pending data. By simulating a slow thread in the ExecutorService used in BootstrapLogger, I was able to reproduce the issue described.

Integrated: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError

2023-08-30 Thread Sean Coffey
On Wed, 23 Aug 2023 15:41:16 GMT, Sean Coffey wrote: > Recursive initialization calls possible during loading of LoggerFinder > service. > > This fix detects the recursive call and returns a temporary LoggerFinder that > is backed by a lazy logger. Automated test case develo

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v7]

2023-08-29 Thread Sean Coffey
nder service while also having other threads poke > System.getLogger during this framework initialization. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: more tidying up in tests - Changes: - all: https://git.openj

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v6]

2023-08-29 Thread Sean Coffey
nder service while also having other threads poke > System.getLogger during this framework initialization. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Review comments from Daniel. Further test clean up - Ch

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v5]

2023-08-28 Thread Sean Coffey
nder service while also having other threads poke > System.getLogger during this framework initialization. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Fix up test cases - Changes: - all: https://git.openjdk.org

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v4]

2023-08-28 Thread Sean Coffey
nder service while also having other threads poke > System.getLogger during this framework initialization. Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - Tidy up SignedLoggerFinderTest.java - Code contribution from Daniel includ

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v3]

2023-08-25 Thread Sean Coffey
On Fri, 25 Aug 2023 10:33:49 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/jdk/internal/logger/LazyLoggers.java line 425: >> >>> 423: */ >>> 424: public static final Logger getLogger(String name, Module module) { >>> 425: BootstrapLogger.detectBackend(); >> >>

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v2]

2023-08-25 Thread Sean Coffey
On Fri, 25 Aug 2023 10:24:23 GMT, Jaikiran Pai wrote: >> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Improve test coverage >> - Incorporate review comments from Daniel > > src/

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v3]

2023-08-25 Thread Sean Coffey
nder service while also having other threads poke > System.getLogger during this framework initialization. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: fix up bootstrap loggers, patch contribution from Daniel - Ch

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v2]

2023-08-25 Thread Sean Coffey
On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey wrote: >> Recursive initialization calls possible during loading of LoggerFinder >> service. >> >> This fix detects the recursive call and returns a temporary LoggerFinder >> that is backed by a lazy logger.

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError

2023-08-24 Thread Sean Coffey
On Wed, 23 Aug 2023 15:41:16 GMT, Sean Coffey wrote: > Recursive initialization calls possible during loading of LoggerFinder > service. > > This fix detects the recursive call and returns a temporary LoggerFinder that > is backed by a lazy logger. Automated test case develo

Re: RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError [v2]

2023-08-24 Thread Sean Coffey
nder service while also having other threads poke > System.getLogger during this framework initialization. Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - Improve test coverage - Incorporate review comments from Daniel --

RFR: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError

2023-08-23 Thread Sean Coffey
Recursive initialization calls possible during loading of LoggerFinder service. This fix detects the recursive call and returns a temporary LoggerFinder that is backed by a lazy logger. Automated test case developed to simulate loading of an external LoggerFinder service while also having

Re: RFR: 8313765: Invalid CEN header (invalid zip64 extra data field size) [v9]

2023-08-16 Thread Sean Coffey
On Tue, 15 Aug 2023 18:43:36 GMT, Lance Andersen wrote: >> This PR updates the extra field validation added as part of >> [JDK-8302483](https://bugs.openjdk.org/browse/JDK-8302483) to deal with >> issues seen with 3rd party tools/libraries where a ZipException may be >> encountered when

Integrated: 8311653: Modify -XshowSettings launcher behavior

2023-07-27 Thread Sean Coffey
On Mon, 24 Jul 2023 16:00:52 GMT, Sean Coffey wrote: > Modify the -XshowSettings launcher option to print non-verbose settings > details of all components by default. Verbose settings details will be > printed via the -XshowSettings:all option. Modify the -XshowSettings option > t

Re: RFR: 8311653: Modify -XshowSettings launcher behavior [v3]

2023-07-27 Thread Sean Coffey
On Wed, 26 Jul 2023 09:22:14 GMT, Sean Coffey wrote: >> Modify the -XshowSettings launcher option to print non-verbose settings >> details of all components by default. Verbose settings details will be >> printed via the -XshowSettings:all option. Modify the -XshowSettings op

Re: RFR: 8311653: Modify -XshowSettings launcher behavior [v3]

2023-07-26 Thread Sean Coffey
rror message in such scenarios > and abort the VM launch. Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since th

Re: RFR: 8311653: Modify -XshowSettings launcher behavior [v2]

2023-07-26 Thread Sean Coffey
On Tue, 25 Jul 2023 21:01:03 GMT, Mandy Chung wrote: >> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Incorporate review feedback >> - modify -X output for :all > > src/

Re: RFR: 8311653: Modify -XshowSettings launcher behavior

2023-07-25 Thread Sean Coffey
On Mon, 24 Jul 2023 16:00:52 GMT, Sean Coffey wrote: > Modify the -XshowSettings launcher option to print non-verbose settings > details of all components by default. Verbose settings details will be > printed via the -XshowSettings:all option. Modify the -XshowSettings option > t

Re: RFR: 8311653: Modify -XshowSettings launcher behavior [v2]

2023-07-25 Thread Sean Coffey
rror message in such scenarios > and abort the VM launch. Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - Incorporate review feedback - modify -X output for :all - Changes: - all: https://git.openjdk.org/jdk/pull/15001/files

RFR: 8311653: Modify -XshowSettings launcher behavior

2023-07-24 Thread Sean Coffey
Modify the -XshowSettings launcher option to print non-verbose settings details of all components by default. Verbose settings details will be printed via the -XshowSettings:all option. Modify the -XshowSettings option to reject bad values passed to it. Print an error message in such scenarios

Integrated: 8310201: Reduce verbose locale output in -XshowSettings launcher option

2023-07-17 Thread Sean Coffey
On Fri, 14 Jul 2023 10:01:16 GMT, Sean Coffey wrote: > Simple tweak to remove the "available locales" section from default > `-XshowSettings` output. > > Instead, it remains available with the `-XshowSettings:locale` option This pull request has now been integrated

Re: RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option [v2]

2023-07-14 Thread Sean Coffey
On Fri, 14 Jul 2023 11:21:02 GMT, Sean Coffey wrote: >> Simple tweak to remove the "available locales" section from default >> `-XshowSettings` output. >> >> Instead, it remains available with the `-XshowSettings:locale` option > > Sean Coffey ha

Re: RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option [v2]

2023-07-14 Thread Sean Coffey
On Fri, 14 Jul 2023 11:02:33 GMT, Jaikiran Pai wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review feedback and bug id added to test > > src/java.base/share/classes/sun/launche

Re: RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option [v2]

2023-07-14 Thread Sean Coffey
> Simple tweak to remove the "available locales" section from default > `-XshowSettings` output. > > Instead, it remains available with the `-XshowSettings:locale` option Sean Coffey has updated the pull request incrementally with one additional commit since the la

RFR: 8310201: Reduce verbose locale output in -XshowSettings launcher option

2023-07-14 Thread Sean Coffey
Simple tweak to remove the "available locales" section from default `-XshowSettings` output. Instead, it remains available with the `-XshowSettings:locale` option - Commit messages: - 8310201 Changes: https://git.openjdk.org/jdk/pull/14885/files Webrev:

Integrated: 8281658: Add a security category to the java -XshowSettings option

2023-07-14 Thread Sean Coffey
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration This pull request has now been integrated. Changeset: 2e12a123 Author: Sean Coffey URL: https://git.openjdk.o

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v11]

2023-07-14 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v10]

2023-07-07 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - Harden code to report lack of SSL support - Testcase corr

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v8]

2023-07-07 Thread Sean Coffey
On Fri, 7 Jul 2023 13:40:53 GMT, Sean Coffey wrote: >> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 123: >> >>> 121: } >>> 122: >>> 123: ostream.println(INDENT + "Security TLS configuration:"); >&

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v8]

2023-07-07 Thread Sean Coffey
On Thu, 6 Jul 2023 14:03:12 GMT, Sean Mullan wrote: >> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 addi

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v8]

2023-07-07 Thread Sean Coffey
On Thu, 6 Jul 2023 18:43:41 GMT, Roger Riggs wrote: >> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 addi

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v8]

2023-07-07 Thread Sean Coffey
On Thu, 6 Jul 2023 17:15:20 GMT, Mandy Chung wrote: > > The changes make me wonder if `-XshowSetting:aardvark` should be an error > > rather than default to print all settings. Something we should look at > > again. Same thing for `-XshowSettings:system` on non-Linux, probably should > > have

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v9]

2023-07-07 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v8]

2023-06-27 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Sean Coffey
On Mon, 19 Jun 2023 18:21:49 GMT, Roger Riggs wrote: >> @RogerRiggs - do you mean to print nothing in the "bad command input" >> scenario ? The current -XshowSettings launch behaviour prints all data if a >> bad value is passed to it. I was mimicking this for security subcommands. >> >> Are

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v7]

2023-06-19 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Don't allow bad subcommand values for security com

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Sean Coffey
On Sat, 17 Jun 2023 01:51:36 GMT, Weijun Wang wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Pass PrintStream to security helper > > src/java.base/share/classes/sun/launcher/SecurityS

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v4]

2023-06-19 Thread Sean Coffey
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote: >> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor out security code to helper class >> - Print aliases. Order Provider type/ser

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Sean Coffey
On Fri, 16 Jun 2023 15:15:59 GMT, Roger Riggs wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Pass PrintStream to security helper > > src/java.base/share/classes/sun/launcher/SecurityS

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v6]

2023-06-19 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - restore more informative help message - Split long prop

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-16 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Pass PrintStream to security helper - Changes:

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit si

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Wed, 14 Jun 2023 14:06:33 GMT, Sean Mullan wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424: >> >>> 422:if (!services.isEmpty()) { >>> 423:services.stream() >>> 424: >>>

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183: >> >>> 181: case "locale": >>> 182: printLocale(); >>> 183: break; >> >> printLocale might need the same treatment to

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Wed, 14 Jun 2023 12:46:36 GMT, Weijun Wang wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments from Roger and tweak some code > > src/java.b

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v4]

2023-06-16 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - Refactor out security code to helper class - Print aliases.

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Incorporate review comments from Roger and tweak som

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-14 Thread Sean Coffey
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request with a new target base due to a > merge or a rebase. T

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-14 Thread Sean Coffey
On Tue, 13 Jun 2023 14:30:57 GMT, Roger Riggs wrote: >> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six addi

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

2023-06-13 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-13 Thread Sean Coffey
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Thanks for the feedback to date. I've pushed new changes to reflect requested changes. I've changed the default` -XshowSe

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-12 Thread Sean Coffey
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Thanks for the reviews to date. All good comments, I'll implement. Yes, the output of `-XShowSettings` is more verbose.

RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Sean Coffey
New functionality in the -XshowSettings menu to display relevant information about JDK security configuration - Commit messages: - minor edits, copyright, descriptions etc - Merge branch 'master' into 8281658-showsettings-security - Merge branch 'master' into

Integrated: 8305950: Have -XshowSettings option display tzdata version

2023-05-09 Thread Sean Coffey
On Mon, 8 May 2023 13:14:34 GMT, Sean Coffey wrote: > minor enhancement to have -XshowSettings launcher option display the version > of tzdata installed in the JDK > > example output of the new tzdata info : > > > > Locale settings: > default locale = En

RFR: 8305950: Have -XshowSettings option display tzdata version

2023-05-08 Thread Sean Coffey
minor enhancement to have -XshowSettings launcher option display the version of tzdata installed in the JDK example output of the new tzdata info : Locale settings: default locale = English default display locale = English default format locale = English tzdata version =

Re: RFR: 8304498: JShell does not switch to raw mode when there is no /bin/test [v2]

2023-03-23 Thread Sean Coffey
On Wed, 22 Mar 2023 18:38:08 GMT, Jan Lahoda wrote: >> If JShell is run on a system that does not have `/bin/test` (which is, >> apparently, possible for some systems, which only have `/usr/bin/test`), it >> won't switch the terminal into the raw mode, and the input will not work >> properly.

Re: RFR: 8304498: JShell does not switch to raw mode when there is no /bin/test

2023-03-22 Thread Sean Coffey
On Mon, 20 Mar 2023 12:10:04 GMT, Jan Lahoda wrote: > If JShell is run on a system that does not have `/bin/test` (which is, > apparently, possible for some systems, which only have `/usr/bin/test`), it > won't switch the terminal into the raw mode, and the input will not work > properly. >

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Sean Coffey
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-23 Thread Sean Coffey
On Thu, 23 Feb 2023 09:03:49 GMT, Alan Bateman wrote: >> Scratch that: as it seems to be important that we don't switch after startup >> then what this code is really reaching for is `static final` field >> semantics. Since `StandardCharsets` might be loaded very early a holder >> class

Re: RFR: 8301119: Support for GB18030-2022

2023-02-22 Thread Sean Coffey
On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato wrote: > Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping

  1   2   >