On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458
On Fri, 31 May 2024 14:34:16 GMT, Sonia Zaldana Calles
wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Decreasing diff size addressing unnecessary changes
>
> Hi all,
>
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/r
On Thu, 9 May 2024 19:52:12 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](h
On Sun, 12 May 2024 18:52:30 GMT, Alan Bateman wrote:
> This mostly looks good. I'm just puzzled CHECK_EXCEPTION_NULL_FAIL. The JNI
> functions GetStaticMethodID, GetMethodID and NewObject return NULL with a
> pending exception when they fail. So I would expect CHECK_EXCEPTION_NULL_FAIL
> to
On Wed, 8 May 2024 09:37:58 GMT, Thomas Stuefe wrote:
> This may be food for another RFE, to keep this patch minimal. But a good
> solution, to me, would be like this:
>
> * have the same logic for return codes (1 = error, 0 = success) to ease
> understanding
> * have clearly named constants
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Decreasing diff size addressing unnecessary changes
--
On Mon, 6 May 2024 19:06:10 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](h
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Fixing indentation
Co-authored-by: ExE Boss <3889017+exe
On Mon, 6 May 2024 16:30:11 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](h
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Fixing broken uncaught exception mechanism
-
Chang
On Mon, 6 May 2024 10:21:12 GMT, Jaikiran Pai wrote:
>> Hi @mlchung, thanks for the feedback! I’ve pushed the updates.
>>
>> Just a question about ```NULL_CHECK0```.
>>
>> ```NULL_CHECK0``` reports the error message and then the exception is
>> described in ```CHECK_EXCEPTION_LEAVE```. This
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Make deleting file OS agnostic
-
Changes:
- all: ht
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with two
additional commits since the last revision:
- Adding test case
- Removing long lines
-
Changes:
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Using new macro to avoid reporting JNI error
-
Chang
On Fri, 19 Apr 2024 17:04:30 GMT, Mandy Chung wrote:
>> @lahodaj
>>
>>> I would suggest to take the test from 18753 though - doing a change like
>>> this without a test may lead to hard-to-find regressions in the future.
>>> (Note the current test should guard against both JDK-8329420 and
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Changes based on feedback
-
Changes:
- all: ht
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Fixing space formatting
-
Changes:
- all: https://
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458
``LauncherHelper#getMainType``` but I'm looking
> forward to your suggestions.
>
> Cheers,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with three
additional commits since the last revision:
- Adding test case
- Removing the need to call mainType me
On Thu, 18 Apr 2024 07:34:24 GMT, Jan Lahoda wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the issue
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458
On Tue, 16 Apr 2024 06:30:55 GMT, Alan Bateman wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the issue
Hi folks,
This PR aims to fix [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
I think the regression got introduced in
[JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
In the issue linked above,
24 matches
Mail list logo
