On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
Marked as reviewed by alanb (Reviewer).
-
PR Review:
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
@AlanBateman @stuart-marks Does any of you have any cycles to review this
one-word PR? :)
-
PR Comment:
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
Yes, looks good to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/16313#issuecomment-1775517786
Resolves a visibility issue in SubmissionPublisher by making the `waiter`
member of BufferedSubscription *volatile*.
-
Commit messages:
- Addresses JDK-8293713 by making the waiter thread member volatile
Changes: https://git.openjdk.org/jdk/pull/16313/files
Webrev:
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
Discussed this change with @DougLea
-
PR Comment: