Re: RFR: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-24 Thread Alan Bateman
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote: > Resolves a visibility issue in SubmissionPublisher by making the `waiter` > member of BufferedSubscription *volatile*. Marked as reviewed by alanb (Reviewer). - PR Review:

Re: RFR: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-23 Thread Viktor Klang
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote: > Resolves a visibility issue in SubmissionPublisher by making the `waiter` > member of BufferedSubscription *volatile*. @AlanBateman @stuart-marks Does any of you have any cycles to review this one-word PR? :) - PR Comment:

Re: RFR: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-23 Thread Doug Lea
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote: > Resolves a visibility issue in SubmissionPublisher by making the `waiter` > member of BufferedSubscription *volatile*. Yes, looks good to me. - PR Comment: https://git.openjdk.org/jdk/pull/16313#issuecomment-1775517786

RFR: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-23 Thread Viktor Klang
Resolves a visibility issue in SubmissionPublisher by making the `waiter` member of BufferedSubscription *volatile*. - Commit messages: - Addresses JDK-8293713 by making the waiter thread member volatile Changes: https://git.openjdk.org/jdk/pull/16313/files Webrev:

Re: RFR: 8293713 : java/net/httpclient/BufferingSubscriberTest.java fails in timeout, blocked in submission publisher

2023-10-23 Thread Viktor Klang
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote: > Resolves a visibility issue in SubmissionPublisher by making the `waiter` > member of BufferedSubscription *volatile*. Discussed this change with @DougLea - PR Comment: