Re: RFR: 8296329: jar validator doesn't account for minor class file version [v2]

2022-11-22 Thread Bo Zhang
On Wed, 23 Nov 2022 03:01:51 GMT, Jorn Vernee wrote: >> @JornVernee can you please sponsor this PR? > > @blindpirate Yes. If you `/integrate` it, I can then `/sponsor`. Thanks @JornVernee ! - PR: https://git.openjdk.org/jdk/pull/11153

Re: RFR: 8296329: jar validator doesn't account for minor class file version [v2]

2022-11-22 Thread Jorn Vernee
On Wed, 23 Nov 2022 02:50:26 GMT, Bo Zhang wrote: >> Marked as reviewed by jvernee (Reviewer). > > @JornVernee can you please sponsor this PR? @blindpirate Yes. If you `/integrate` it, I can then `/sponsor`. - PR: https://git.openjdk.org/jdk/pull/11153

Re: RFR: 8296329: jar validator doesn't account for minor class file version [v2]

2022-11-22 Thread Bo Zhang
On Wed, 16 Nov 2022 13:23:03 GMT, Jorn Vernee wrote: >> Bo Zhang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit

Re: RFR: 8296329: jar validator doesn't account for minor class file version [v2]

2022-11-16 Thread Jorn Vernee
On Wed, 16 Nov 2022 00:44:50 GMT, Bo Zhang wrote: >> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329), >> previously, the jar validator compare the "version" to validate a >> multi-release jar. The "version" is a mix of the major and minor version >> fused into a

Re: RFR: 8296329: jar validator doesn't account for minor class file version [v2]

2022-11-15 Thread Bo Zhang
On Tue, 15 Nov 2022 02:14:46 GMT, Jorn Vernee wrote: >> Bo Zhang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit

Re: RFR: 8296329: jar validator doesn't account for minor class file version [v2]

2022-11-15 Thread Bo Zhang
> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329), > previously, the jar validator compare the "version" to validate a > multi-release jar. The "version" is a mix of the major and minor version > fused into a single int, which might be a negative number with >