Re: RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation [v2]

2022-11-24 Thread Claes Redestad
On Thu, 24 Nov 2022 17:50:42 GMT, Andrey Turbanov wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Require 64-bit arch to avoid (most) hypothetical false positives > >

Re: RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation [v2]

2022-11-24 Thread Andrey Turbanov
On Thu, 24 Nov 2022 15:01:12 GMT, Claes Redestad wrote: >> When concatenating Strings, OutOfMemoryError should be thrown on all >> overflow conditions. This fixes a case that erroneously thro IAE on >> concatenations of long (`length > Integer.MAX_VALUE/2`) UTF16 strings due >> failing to

Re: RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation [v2]

2022-11-24 Thread Alan Bateman
On Thu, 24 Nov 2022 15:01:12 GMT, Claes Redestad wrote: >> When concatenating Strings, OutOfMemoryError should be thrown on all >> overflow conditions. This fixes a case that erroneously thro IAE on >> concatenations of long (`length > Integer.MAX_VALUE/2`) UTF16 strings due >> failing to

Re: RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation [v2]

2022-11-24 Thread Claes Redestad
On Thu, 24 Nov 2022 14:14:56 GMT, Alan Bateman wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Require 64-bit arch to avoid (most) hypothetical false positives > >

Re: RFR: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation [v2]

2022-11-24 Thread Claes Redestad
> When concatenating Strings, OutOfMemoryError should be thrown on all overflow > conditions. This fixes a case that erroneously thro IAE on concatenations of > long (`length > Integer.MAX_VALUE/2`) UTF16 strings due failing to check for > overflow after shifting index left with the coder. > >