Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v4]

2022-12-01 Thread Roger Riggs
On Thu, 1 Dec 2022 08:14:07 GMT, Sergey Tsypanov wrote: >> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` >> which in turn specifies the same exception thrown under the same conditions >> and the implementation does exactly the same checks. This means we can >>

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v4]

2022-12-01 Thread Claes Redestad
On Thu, 1 Dec 2022 08:14:07 GMT, Sergey Tsypanov wrote: >> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` >> which in turn specifies the same exception thrown under the same conditions >> and the implementation does exactly the same checks. This means we can >>

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v4]

2022-12-01 Thread Sergey Tsypanov
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` > which in turn specifies the same exception thrown under the same conditions > and the implementation does exactly the same checks. This means we can remove > the check from `String.offsetByCodePoints()` and rely on

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v3]

2022-12-01 Thread Sergey Tsypanov
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` > which in turn specifies the same exception thrown under the same conditions > and the implementation does exactly the same checks. This means we can remove > the check from `String.offsetByCodePoints()` and rely on

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v2]

2022-12-01 Thread Sergey Tsypanov
On Wed, 30 Nov 2022 20:41:47 GMT, Claes Redestad wrote: >> Sergey Tsypanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v2]

2022-11-30 Thread Claes Redestad
On Wed, 30 Nov 2022 18:17:47 GMT, Sergey Tsypanov wrote: >> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` >> which in turn specifies the same exception thrown under the same conditions >> and the implementation does exactly the same checks. This means we can >>

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v2]

2022-11-30 Thread Roger Riggs
On Wed, 30 Nov 2022 18:17:47 GMT, Sergey Tsypanov wrote: >> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` >> which in turn specifies the same exception thrown under the same conditions >> and the implementation does exactly the same checks. This means we can >>

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints()

2022-11-30 Thread Sergey Tsypanov
On Thu, 24 Nov 2022 10:08:31 GMT, Sergey Tsypanov wrote: > `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` > which in turn specifies the same exception thrown under the same conditions > and the implementation does exactly the same checks. This means we can remove

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints() [v2]

2022-11-30 Thread Sergey Tsypanov
> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` > which in turn specifies the same exception thrown under the same conditions > and the implementation does exactly the same checks. This means we can remove > the check from `String.offsetByCodePoints()` and rely on

Re: RFR: 8297561: Redundant index check in String.offsetByCodePoints()

2022-11-27 Thread Andrey Turbanov
On Thu, 24 Nov 2022 10:08:31 GMT, Sergey Tsypanov wrote: > `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` > which in turn specifies the same exception thrown under the same conditions > and the implementation does exactly the same checks. This means we can remove

RFR: 8297561: Redundant index check in String.offsetByCodePoints()

2022-11-24 Thread Sergey Tsypanov
`String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` which in turn specifies the same exception thrown under the same conditions and the implementation does exactly the same checks. This means we can remove the check from `String.offsetByCodePoints()` and rely on the one