Re: RFR: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime [v4]

2022-12-06 Thread David Holmes
On Tue, 6 Dec 2022 08:56:47 GMT, Doug Simon wrote: >> src/hotspot/share/jvmci/jvmci.cpp line 234: >> >>> 232: if (thread != nullptr && thread->is_Java_thread()) { >>> 233: ResourceMark rm; >>> 234: JavaThreadState state = ((JavaThread*) thread)->thread_state(); >> >> Please use

Re: RFR: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime [v4]

2022-12-06 Thread Doug Simon
On Tue, 6 Dec 2022 05:28:24 GMT, David Holmes wrote: >> Doug Simon has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed is_module_resolvable to is_module_observable > > src/hotspot/share/jvmci/jvmci.cpp line 234: > >> 232: if

Re: RFR: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime [v4]

2022-12-05 Thread David Holmes
On Mon, 5 Dec 2022 17:45:25 GMT, Doug Simon wrote: >> Libgraal is compiled ahead of time and should not need any JVMCI Java code >> to be dynamically loaded at runtime. Prior to this PR, this is not the case >> due to: >> >> * Code to copy system properties from the HotSpot heap into the

Re: RFR: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime [v4]

2022-12-05 Thread Doug Simon
> Libgraal is compiled ahead of time and should not need any JVMCI Java code to > be dynamically loaded at runtime. Prior to this PR, this is not the case due > to: > > * Code to copy system properties from the HotSpot heap into the libgraal > heap. This is in >