On Fri, 5 May 2023 16:43:46 GMT, Jiangli Zhou wrote:
>>> [...] I'll see if I can test this on a mandrel build tomorrow...
>>
>> @jianglizhou So I've tested this with a mandrel build and it doesn't break
>> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a)
>> doesn't
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote:
>> As @jerboaa mentioned, for GraalVM native-image we produce our own
>> `libjvm.a` as part of building GraalVM (every native image gets statically
>> linked to that library). See
>>
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
On Thu, 4 May 2023 19:32:45 GMT, Jiangli Zhou wrote:
>>> [...] I'll see if I can test this on a mandrel build tomorrow...
>>
>> @jianglizhou So I've tested this with a mandrel build and it doesn't break
>> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a)
>> doesn't
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote:
>> As @jerboaa mentioned, for GraalVM native-image we produce our own
>> `libjvm.a` as part of building GraalVM (every native image gets statically
>> linked to that library). See
>>
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote:
>> As @jerboaa mentioned, for GraalVM native-image we produce our own
>> `libjvm.a` as part of building GraalVM (every native image gets statically
>> linked to that library). See
>>
On Thu, 4 May 2023 09:40:31 GMT, Paul Woegerer wrote:
>> GraalVM native-image has it's own `libjvm.a` shim which would likely
>> conflict or produce undesirable results. So I'd prefer the approach where
>> `static-libs-image` wouldn't produce hotspot `libjvm.a` as part of it. For
>> new
On Wed, 3 May 2023 18:51:54 GMT, Severin Gehwolf wrote:
>>> Could we decouple `hotspot-static-libs` from `static-libs-image` somehow,
>>> please? `static-libs-image` is used by the `graal-builder-image` target and
>>> it would be good if it didn't include hotspot static libs as they are not
On Wed, 3 May 2023 18:51:54 GMT, Severin Gehwolf wrote:
>>> Could we decouple `hotspot-static-libs` from `static-libs-image` somehow,
>>> please? `static-libs-image` is used by the `graal-builder-image` target and
>>> it would be good if it didn't include hotspot static libs as they are not
On Wed, 3 May 2023 18:31:56 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update based on @erikj79 review comments and suggestions:
>> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
On Wed, 3 May 2023 18:40:52 GMT, Jiangli Zhou wrote:
>> I'm hoping to get input from the graal team on the impact of this change.
>> The exact usage of the new libjvm.a file is still under discussion so I
>> share you concern about changing things for the current static libs usecase
>> before
On Wed, 3 May 2023 18:33:56 GMT, Erik Joelsson wrote:
>> make/Main.gmk line 1060:
>>
>>> 1058: symbols-image: $(LIBS_TARGETS) $(LAUNCHER_TARGETS)
>>> 1059:
>>> 1060: static-libs-image: hotspot-static-libs $(STATIC_LIBS_TARGETS)
>>
>> Could we decouple `hotspot-static-libs` from
On Wed, 3 May 2023 17:05:29 GMT, Severin Gehwolf wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update based on @erikj79 review comments and suggestions:
>> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN)
On Wed, 3 May 2023 17:58:25 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/VM static libraries:
>>
>> - Create libjvm.a together with other JDK static libraries
On Wed, 3 May 2023 16:57:04 GMT, Severin Gehwolf wrote:
> @jianglizhou How does the produced image look like after this patch? I.e.
> what's the contents of `build/*/images/static-libs`?
With the changes in this patch, `build/*/images/static-libs` will contain the
`libjvm.a` in addition to
On Wed, 3 May 2023 13:42:03 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update based on @erikj79 review comments and suggestions:
>> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when
On Wed, 3 May 2023 13:34:12 GMT, Erik Joelsson wrote:
> The current target user of the .a libraries is GraalVM, so we should check
> with them that the changes to the contents of the `.a` files isn't impacting
> them in a bad way. @dougxc what do you think?
Thanks for the heads up - I've
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when
This PR is branched from the makefile changes for
https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
handling the JDK/VM static libraries:
- Create libjvm.a together with other JDK static libraries when building
'static-libs-image' (or 'static-libs-bundles') target,
28 matches
Mail list logo