On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejovic
wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejovic
wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejovic
wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Thu, 1 Jun 2023 10:25:49 GMT, Severin Gehwolf wrote:
> I'm concerned about the hard-coding of delimiter values and the added
> accidential complexity in order to avoid the Regex engine. Note that this
> test fails due to the delimiter hard-coding:
>
> ```
>
On Tue, 13 Jun 2023 15:48:31 GMT, Christian Wimmer wrote:
> We (as the Native Image team) are OK with this. Our testing will detect that
> pretty quickly, and then the new code can be fixed.
That may well be the case. However, until all the concerns raised by OpenJDK
reviewers who have looked
On Thu, 1 Jun 2023 12:11:29 GMT, Alan Bateman wrote:
> It's easy to introduce a new change to this code which accidentally drags in
> some of those (unwanted) dependencies again.
We (as the Native Image team) are OK with this. Our testing will detect that
pretty quickly, and then the new code
On Tue, 6 Jun 2023 10:10:38 GMT, Aleksandar Pejovic
wrote:
>> I'm not convinced this is a good change. Going by that mailing list thread,
>> it suggests that people considered changing it. If one of those attempts
>> were successful, it would have broken this code. It makes it rather fragile.
On Mon, 5 Jun 2023 09:44:31 GMT, Severin Gehwolf wrote:
>> As far as I can tell, the delimiter hasn't changed since the file was
>> introduced, and judging by the kernel mailing list (e.g., see [the
>> following](https://lore.kernel.org/all/yr5jvhhsucrbt...@mtj.duckdns.org/)),
>> I don't
On Mon, 5 Jun 2023 09:02:06 GMT, Aleksandar Pejovic
wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupInfo.java line 110:
>>
>>> 108: */
>>> 109: static CgroupInfo fromCgroupsLine(String line) {
>>> 110: String[] tokens = line.split("\t");
>>
>> With this
On Thu, 1 Jun 2023 09:47:29 GMT, Severin Gehwolf wrote:
>> The current code for cgroup support in the JDK has large and expensive
>> dependencies: it uses NIO, streams, and regular expressions. This leads to
>> unnecessary class loading and slows down startup, especially when the code
>> is
On Thu, 1 Jun 2023 08:50:33 GMT, Severin Gehwolf wrote:
>> The current code for cgroup support in the JDK has large and expensive
>> dependencies: it uses NIO, streams, and regular expressions. This leads to
>> unnecessary class loading and slows down startup, especially when the code
>> is
On Wed, 31 May 2023 13:49:46 GMT, Aleksandar Pejovic
wrote:
>>> I guess I'll have to wait for OCA verification.
>>
>> Yes.
>>
>>> One failure is due to a lack of reviewers, so would you be able to do a
>>> review?
>>
>> Yes, I'll try to do a review later today or tomorrow.
>>
>> Thanks!
>
On Thu, 1 Jun 2023 12:01:15 GMT, Severin Gehwolf wrote:
> It's easy to introduce a new change to this code which accidentally drags in
> some of those (unwanted) dependencies again.
I do not like the changes proposed here, they are all crying out for several
round cleanups and modernization.
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejović wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejović wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Wed, 31 May 2023 13:49:46 GMT, Aleksandar Pejović wrote:
>>> I guess I'll have to wait for OCA verification.
>>
>> Yes.
>>
>>> One failure is due to a lack of reviewers, so would you be able to do a
>>> review?
>>
>> Yes, I'll try to do a review later today or tomorrow.
>>
>> Thanks!
>
On Wed, 31 May 2023 12:21:13 GMT, Aleksandar Pejović wrote:
> I guess I'll have to wait for OCA verification.
Yes.
> One failure is due to a lack of reviewers, so would you be able to do a
> review?
Yes, I'll try to do a review later today or tomorrow.
Thanks!
-
PR Comment:
On Wed, 31 May 2023 09:38:08 GMT, Aleksandar Pejović wrote:
>> @pejovica Please enable GHA testing on your fork. Once enabled, please merge
>> latest master into your branch so as to trigger a GHA run. Thanks!
>
> @jerboaa I enabled GḪA testing. Other than a couple of Windows errors (which
>
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejović wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
>
On Wed, 31 May 2023 12:54:57 GMT, Severin Gehwolf wrote:
> Yes, I'll try to do a review later today or tomorrow.
Awesome, thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/14216#issuecomment-1570276516
On Wed, 31 May 2023 09:38:08 GMT, Aleksandar Pejović wrote:
>> @pejovica Please enable GHA testing on your fork. Once enabled, please merge
>> latest master into your branch so as to trigger a GHA run. Thanks!
>
> @jerboaa I enabled GḪA testing. Other than a couple of Windows errors (which
>
On Tue, 30 May 2023 13:48:49 GMT, Severin Gehwolf wrote:
>> The current code for cgroup support in the JDK has large and expensive
>> dependencies: it uses NIO, streams, and regular expressions. This leads to
>> unnecessary class loading and slows down startup, especially when the code
>> is
The current code for cgroup support in the JDK has large and expensive
dependencies: it uses NIO, streams, and regular expressions. This leads to
unnecessary class loading and slows down startup, especially when the code is
executed early during an application startup. This is especially a
23 matches
Mail list logo
