Re: RFR: 8310994: Add JFR event for selection operations [v2]

2024-04-16 Thread Alan Bateman
On Mon, 26 Feb 2024 14:17:09 GMT, Daniel Fuchs wrote: >> src/jdk.jfr/share/classes/jdk/jfr/events/SelectorSelectEvent.java line 44: >> >>> 42: @Label("SelectionKey Count") >>> 43: @Description("Number of channels ready for I/O or added to ready >>> set") >>> 44: public int

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2024-02-26 Thread Daniel Fuchs
On Wed, 13 Dec 2023 18:49:08 GMT, Daniel Fuchs wrote: >> Tim Prinzing has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2024-02-26 Thread Daniel Fuchs
On Wed, 13 Dec 2023 18:58:40 GMT, Tim Prinzing wrote: >> src/java.base/share/classes/jdk/internal/event/SelectorSelectEvent.java line >> 41: >> >>> 39: public class SelectorSelectEvent extends Event { >>> 40: >>> 41: public int selectionKeyCount; >> >> I still believe we should record

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2023-12-13 Thread Tim Prinzing
On Wed, 13 Dec 2023 18:47:50 GMT, Daniel Fuchs wrote: >> Tim Prinzing has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2023-12-13 Thread Daniel Fuchs
On Wed, 13 Dec 2023 18:38:11 GMT, Tim Prinzing wrote: >>> It could also be interesting to provide the `timeout` that was given to the >>> selection operation. >> >> I've tried to work through issues, esp. around selector spinning, and being >> able to distinguish select from selectNow is

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2023-12-13 Thread Daniel Fuchs
On Wed, 13 Dec 2023 18:38:09 GMT, Tim Prinzing wrote: >> Added mirror event with static methods: jdk.internal.event.SelectionEvent >> that provides the duration of select calls and the count of how many keys >> are available. >> >> Emit the event from SelectorImpl::lockAndDoSelect >> >> Test

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2023-12-13 Thread Tim Prinzing
On Thu, 23 Nov 2023 11:18:45 GMT, Erik Gahlin wrote: >> src/jdk.jfr/share/classes/jdk/jfr/events/SelectionEvent.java line 43: >> >>> 41: >>> 42: @Label("Selection Count") >>> 43: @Description("Number of channels selected") >> >> I suspect you'll need to rename this event to something

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2023-12-13 Thread Tim Prinzing
On Fri, 8 Dec 2023 06:30:21 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/event/SelectionEvent.java line 38: >> >>> 36: public class SelectionEvent extends Event { >>> 37: >>> 38: public int count; >> >> It could also be interesting to provide the `timeout` that was

Re: RFR: 8310994: Add JFR event for selection operations [v2]

2023-12-13 Thread Tim Prinzing
> Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at jdk.jfr.event.io.TestSelectionEvents Tim Prinzing has