Re: RFR: 8315004: Runtime.halt() debug logging

2023-10-31 Thread Roger Riggs
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote: > I want to add a log output similar to JDK-8301627 to Runtime.halt(). > To avoid double logging of Runtime.exit(), add a flag to indicate whether > logging was done, and fix it so that logging is done only once. > Could someone please

Re: RFR: 8315004: Runtime.halt() debug logging

2023-10-31 Thread Alan Bateman
On Fri, 1 Sep 2023 08:29:41 GMT, Alan Bateman wrote: >> I think you may have missed the comment in the JBS issue. Logging means >> running potentially arbitrary code, doing this at Runtime.halt time is >> problematic. I thought the conclusion from the work on Runtime.exit was not >> to log in

Re: RFR: 8315004: Runtime.halt() debug logging

2023-10-30 Thread Quan Anh Mai
On Tue, 31 Oct 2023 00:14:39 GMT, Masanori Yano wrote: >>> @AlanBateman Sorry for missing your comment on JBS. I can't find any >>> discussion of the need for logs in Runtime.halt in JDK-8301627, so I'm not >>> sure if it was intentional that no logging output was added to Runtime.halt. >>>

Re: RFR: 8315004: Runtime.halt() debug logging

2023-10-30 Thread Masanori Yano
On Fri, 1 Sep 2023 08:29:41 GMT, Alan Bateman wrote: >> I think you may have missed the comment in the JBS issue. Logging means >> running potentially arbitrary code, doing this at Runtime.halt time is >> problematic. I thought the conclusion from the work on Runtime.exit was not >> to log in

Re: RFR: 8315004: Runtime.halt() debug logging

2023-09-07 Thread Masanori Yano
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote: > I want to add a log output similar to JDK-8301627 to Runtime.halt(). > To avoid double logging of Runtime.exit(), add a flag to indicate whether > logging was done, and fix it so that logging is done only once. > Could someone please

Re: RFR: 8315004: Runtime.halt() debug logging

2023-09-01 Thread Roger Riggs
On Fri, 1 Sep 2023 08:29:41 GMT, Alan Bateman wrote: >> I think you may have missed the comment in the JBS issue. Logging means >> running potentially arbitrary code, doing this at Runtime.halt time is >> problematic. I thought the conclusion from the work on Runtime.exit was not >> to log in

Re: RFR: 8315004: Runtime.halt() debug logging

2023-09-01 Thread Alan Bateman
On Fri, 25 Aug 2023 09:49:20 GMT, Alan Bateman wrote: >> I want to add a log output similar to JDK-8301627 to Runtime.halt(). >> To avoid double logging of Runtime.exit(), add a flag to indicate whether >> logging was done, and fix it so that logging is done only once. >> Could someone please

Re: RFR: 8315004: Runtime.halt() debug logging

2023-09-01 Thread Masanori Yano
On Fri, 25 Aug 2023 09:49:20 GMT, Alan Bateman wrote: >> I want to add a log output similar to JDK-8301627 to Runtime.halt(). >> To avoid double logging of Runtime.exit(), add a flag to indicate whether >> logging was done, and fix it so that logging is done only once. >> Could someone please

Re: RFR: 8315004: Runtime.halt() debug logging

2023-08-25 Thread Alan Bateman
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote: > I want to add a log output similar to JDK-8301627 to Runtime.halt(). > To avoid double logging of Runtime.exit(), add a flag to indicate whether > logging was done, and fix it so that logging is done only once. > Could someone please

RFR: 8315004: Runtime.halt() debug logging

2023-08-25 Thread Masanori Yano
I want to add a log output similar to JDK-8301627 to Runtime.halt(). To avoid double logging of Runtime.exit(), add a flag to indicate whether logging was done, and fix it so that logging is done only once. Could someone please review this fix? - Commit messages: - Merge branch