Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2024-02-06 Thread Raffaello Giulietti
On Sun, 21 Jan 2024 13:48:49 GMT, Shaojin Wen wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2024-01-21 Thread Shaojin Wen
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-27 Thread 温绍锦
On Mon, 25 Sep 2023 12:20:36 GMT, 温绍锦 wrote: >>> The reason why I split it into multiple small methods is to avoid a single >>> method codeSize > 325. After merging small methods, the performance will >>> decrease. >> >> Yes, I can refactor to keep the same structure and verify performance is

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-27 Thread Raffaello Giulietti
On Mon, 25 Sep 2023 12:20:36 GMT, 温绍锦 wrote: >>> The reason why I split it into multiple small methods is to avoid a single >>> method codeSize > 325. After merging small methods, the performance will >>> decrease. >> >> Yes, I can refactor to keep the same structure and verify performance is

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-25 Thread 温绍锦
On Mon, 25 Sep 2023 12:28:06 GMT, Claes Redestad wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> fix logic error > > src/java.base/share/classes/java/util/Formatter.java line 2949: > >> 2947: }

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-25 Thread Claes Redestad
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized.

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-25 Thread 温绍锦
On Mon, 25 Sep 2023 11:46:36 GMT, Claes Redestad wrote: > > The reason why I split it into multiple small methods is to avoid a single > > method codeSize > 325. After merging small methods, the performance will > > decrease. > > Yes, I can refactor to keep the same structure and verify

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-25 Thread Claes Redestad
On Mon, 25 Sep 2023 11:36:10 GMT, 温绍锦 wrote: > The reason why I split it into multiple small methods is to avoid a single > method codeSize > 325. After merging small methods, the performance will > decrease. Yes, I can refactor to keep the same structure and verify performance is neutral or

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-25 Thread 温绍锦
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized.

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-25 Thread Claes Redestad
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized.

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-24 Thread 温绍锦
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on