Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

2023-11-08 Thread Ryan Wallace
On Wed, 8 Nov 2023 09:42:25 GMT, Ryan Wallace wrote: >> Hi all, >> >> Please review this fix for jar tool not producing archive if there is a >> missing file supplied. Fix is to throw an exception and exit processing when >> a missing file is supplied. Current behaviour will recognise missing

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

2023-11-08 Thread Alan Bateman
On Wed, 8 Nov 2023 16:03:22 GMT, Ryan Wallace wrote: > Added and tested and it still works as expected. @ryawalla Would it be possible to update the PR description so there's a clear summary on the updated proposal? I think it aligns the behavior with what happens when a bad file path is

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

2023-11-08 Thread Jaikiran Pai
On Wed, 8 Nov 2023 09:42:25 GMT, Ryan Wallace wrote: >> Hi all, >> >> Please review this fix for jar tool not producing archive if there is a >> missing file supplied. Fix is to throw an exception and exit processing when >> a missing file is supplied. Current behaviour will recognise missing

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

2023-11-08 Thread Ryan Wallace
> Hi all, > > Please review this fix for jar tool not producing archive if there is a > missing file supplied. Fix is to throw an exception and exit processing when > a missing file is supplied. Current behaviour will recognise missing file as > an error but continue processing and not produce