Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v2]

2023-11-07 Thread Erik Gahlin
On Tue, 7 Nov 2023 09:27:51 GMT, Alan Bateman wrote: >> I filed an issue to investigate if there is a problem with SOE, or if the >> OOM check is really needed now. >> https://bugs.openjdk.org/browse/JDK-8319579 >> >> Regardless of outcome, It would be good to document the results of the >>

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v2]

2023-11-07 Thread Erik Gahlin
On Tue, 7 Nov 2023 09:24:20 GMT, Alan Bateman wrote: >> Erik Gahlin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove SecurityException and IllegalArgumentException from throws clause > >

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v2]

2023-11-07 Thread Alan Bateman
On Tue, 7 Nov 2023 02:10:29 GMT, Erik Gahlin wrote: > I filed an issue to investigate if there is a problem with SOE, or if the OOM > check is really needed now. https://bugs.openjdk.org/browse/JDK-8319579 > > Regardless of outcome, It would be good to document the results of the >

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v2]

2023-11-07 Thread Alan Bateman
On Mon, 6 Nov 2023 22:52:50 GMT, Erik Gahlin wrote: >> Could I have a review of a PR that removes the bytecode instrumentation for >> the exception events. >> >> Testing: jdk/jdk/jfr + tier1 + tier2 > > Erik Gahlin has updated the pull request incrementally with one additional > commit since

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v2]

2023-11-06 Thread Erik Gahlin
On Mon, 6 Nov 2023 22:41:17 GMT, Erik Gahlin wrote: >> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 44: >> >>> 42: >>> 43: public static void traceError(Class clazz, String message) { >>> 44: if (OutOfMemoryError.class.isAssignableFrom(clazz)) { >> >>

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v2]

2023-11-06 Thread Erik Gahlin
> Could I have a review of a PR that removes the bytecode instrumentation for > the exception events. > > Testing: jdk/jdk/jfr + tier1 + tier2 Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Remove SecurityException and