Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-29 Thread Sandhya Viswanathan
On Tue, 28 Nov 2023 20:52:35 GMT, Srinivas Vamsi Parasa wrote: >> Thanks Sandhya, will fix this issue. > > Thanks Sandhya for suggesting the change to use supports_simd_sort(BasicType > bt). Please see the updated code upstreamed. @vamsi-parasa Thanks, your changes look good to me.

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-28 Thread Srinivas Vamsi Parasa
On Tue, 28 Nov 2023 12:25:57 GMT, Jatin Bhateja wrote: >> src/hotspot/share/opto/library_call.cpp line 5448: >> >>> 5446: BasicType bt = elem_type->basic_type(); >>> 5447: // Disable the intrinsic for 64-bit types with AVX2 >>> 5448: if ((bt == T_LONG || bt == T_DOUBLE) && UseAVX == 2) {

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-28 Thread Srinivas Vamsi Parasa
On Tue, 28 Nov 2023 00:08:00 GMT, Srinivas Vamsi Parasa wrote: >> src/hotspot/share/opto/library_call.cpp line 5391: >> >>> 5389: BasicType bt = elem_type->basic_type(); >>> 5390: // Disable the intrinsic for 64-bit types with AVX2 >>> 5391: if ((bt == T_LONG || bt == T_DOUBLE) &&

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-28 Thread Srinivas Vamsi Parasa
On Tue, 28 Nov 2023 12:23:00 GMT, Jatin Bhateja wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 11 >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-28 Thread Srinivas Vamsi Parasa
On Mon, 27 Nov 2023 23:44:25 GMT, Sandhya Viswanathan wrote: >> Not listed here: https://oca.opensource.oracle.com/?ojr=contributors > > Yes, Vamsi is part of Intel Java team. He also has the author status > (https://openjdk.org/census#sparasa). > @sviswa7 I am asking about the copyright

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-28 Thread Jatin Bhateja
On Tue, 28 Nov 2023 12:23:12 GMT, Jatin Bhateja wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 11 >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-28 Thread Jatin Bhateja
On Sat, 18 Nov 2023 01:21:09 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX2 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread David Holmes
On Mon, 27 Nov 2023 23:44:25 GMT, Sandhya Viswanathan wrote: >> Not listed here: https://oca.opensource.oracle.com/?ojr=contributors > > Yes, Vamsi is part of Intel Java team. He also has the author status > (https://openjdk.org/census#sparasa). @sviswa7 I am asking about the copyright holder

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread Srinivas Vamsi Parasa
On Tue, 28 Nov 2023 00:04:55 GMT, Sandhya Viswanathan wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 11 >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread Sandhya Viswanathan
On Sat, 18 Nov 2023 01:21:09 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX2 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread Sandhya Viswanathan
On Tue, 21 Nov 2023 15:14:28 GMT, Dalibor Topic wrote: >> src/java.base/linux/native/libsimdsort/avx2-32bit-qsort.hpp line 3: >> >>> 1: /* >>> 2: * Copyright (c) 2021, 2023, Intel Corporation. All rights reserved. >>> 3: * Copyright (c) 2021 Serge Sans Paille. All rights reserved. >> >> Is

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-21 Thread Dalibor Topic
On Thu, 16 Nov 2023 07:09:31 GMT, David Holmes wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 11 >> additional