Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-12-04 Thread Magnus Ihse Bursie
On Thu, 30 Nov 2023 20:19:56 GMT, Srinivas Vamsi Parasa wrote: >> Raising the minimum gcc version is not done willy-nilly. (I feel a "You just >> don't ..." meme coming up) >> >> But you are saying that you want to skip building this library unless you >> have a gcc version that supports

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-12-03 Thread David Holmes
On Wed, 29 Nov 2023 13:26:58 GMT, serge-sans-paille wrote: >> I take it he is not an Intel employee, in which case he has to be an OpenJDK >> contributor himself for code for which he holds a copyright to be >> contributed to OpenJDK. @robilad please correct me if I am wrong here. > > hey o/

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-12-02 Thread Dalibor Topic
On Wed, 29 Nov 2023 13:26:58 GMT, serge-sans-paille wrote: >> I take it he is not an Intel employee, in which case he has to be an OpenJDK >> contributor himself for code for which he holds a copyright to be >> contributed to OpenJDK. @robilad please correct me if I am wrong here. > > hey o/

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-12-02 Thread serge-sans-paille
On Wed, 29 Nov 2023 06:12:54 GMT, David Holmes wrote: >> Not listed here: https://oca.opensource.oracle.com/?ojr=contributors > > I take it he is not an Intel employee, in which case he has to be an OpenJDK > contributor himself for code for which he holds a copyright to be contributed > to

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-11-30 Thread Srinivas Vamsi Parasa
On Thu, 30 Nov 2023 20:07:19 GMT, Magnus Ihse Bursie wrote: > But you are saying that you want to skip building this library unless you > have a gcc version that supports c++17? > Yes, the request is to skip building the simdsort library if GCC version is < 8 as only GCC >= 8 supports C++17

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-11-30 Thread Magnus Ihse Bursie
On Thu, 30 Nov 2023 18:19:51 GMT, Srinivas Vamsi Parasa wrote: >> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not >> just CXXFLAGS? >> >> Also @vamsi-parasa, did you check into if this really was needed and why? To >> be clear, I basically consider this an

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]

2023-11-30 Thread Srinivas Vamsi Parasa
> The goal is to develop faster sort routines for x86_64 CPUs by taking > advantage of AVX2 instructions. This enhancement provides an order of > magnitude speedup for Arrays.sort() using int, long, float and double arrays. > > For serial sort on random data, this PR shows upto ~7.5x