On Thu, 16 May 2024 18:09:04 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 418:
>>
>>> 416: __ cmpq(haystack_len, 0x10);
>>> 417: __ ja_b(L_moreThan16);
>>> 418:
>>
>> An assert here to check for header size >= 16 would be good.
>> Also a
On Wed, 22 May 2024 14:50:40 GMT, Scott Gibbons wrote:
>> test/jdk/java/lang/StringBuffer/IndexOf.java line 284:
>>
>>> 282:
>>> 283: // Note: it is possible although highly improbable that failCount
>>> will
>>> 284: // be > 0 even if everthing is working ok
>>
>> This sounds like
On Wed, 15 May 2024 19:34:40 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> test/jdk/java/lang/StringBuffer/IndexOf.java line 90:
>
>> 88:
>> 89:
On Fri, 24 May 2024 18:32:53 GMT, Volodymyr Paprotski wrote:
>> Fixed
>
> (missed a `git add`? don't see the updates for this file)
Hmmm... Not sure what happened.
>> Since we're only concerned with the delta of performance, does this really
>> matter? Can you suggest an alternative?
>
> The
On Fri, 17 May 2024 23:59:05 GMT, Scott Gibbons wrote:
>> test/jdk/java/lang/StringBuffer/IndexOf.java line 40:
>>
>>> 38: private static boolean failure = false;
>>> 39: public static void main(String[] args) throws Exception {
>>> 40: String testName = "IndexOf";
>>
>> intentation
>
On Wed, 22 May 2024 14:41:36 GMT, Scott Gibbons wrote:
>> test/micro/org/openjdk/bench/java/lang/StringIndexOfHuge.java line 132:
>>
>>> 130: @Benchmark
>>> 131: public int searchHugeLargeSubstring() {
>>> 132: return dataStringHuge.indexOf("B".repeat(30) + "X" +
>>> "A".repeat(30),
On Fri, 17 May 2024 22:37:13 GMT, Sandhya Viswanathan
wrote:
>> Not sure what you mean here. I *think* you mean that hsLength is not the
>> length of the remaining bytes in the haystack, but the actual length. There
>> may be an issue if that is correct, right? I'll investigate.
>
> Yes,
On Wed, 15 May 2024 19:18:27 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> test/jdk/java/lang/StringBuffer/IndexOf.java line 54:
>
>> 52: //
On Mon, 6 May 2024 23:19:07 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 329:
>
>>
On Wed, 15 May 2024 19:18:02 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> test/jdk/java/lang/StringBuffer/IndexOf.java line 40:
>
>> 38:
On Tue, 14 May 2024 00:38:30 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1178:
>
>>
On Tue, 14 May 2024 18:38:38 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1784:
>
>>
On Fri, 17 May 2024 22:40:50 GMT, Sandhya Viswanathan
wrote:
>> The entry code switches Windows calling convention into Linux calling
>> convention by moving/saving registers, which are properly restored on
>> function exit. This makes register tracking easier.
>
> I don't see the place
On Thu, 16 May 2024 17:08:21 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 238:
>>
>>> 236: const Register needle = rdx;
>>> 237: const Register needle_len = rcx;
>>> 238:
>>
>> This is the calling convention on Linux. How is windows
On Thu, 16 May 2024 20:22:40 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 1510:
>>
>>> 1508: compare_big_haystack_to_needle(sizeKnown, size,
>>> NUMBER_OF_NEEDLE_BYTES_TO_COMPARE, loop_top, hsPtrRet, hsLength,
>>> 1509:
On Mon, 6 May 2024 20:56:36 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 1174:
>
>> 1172: //
On Tue, 7 May 2024 17:25:04 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4492:
>
>> 4490:
>>
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Wed, 15 May 2024 19:21:37 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> test/jdk/java/lang/StringBuffer/IndexOf.java line 47:
>
>> 45:
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
30 matches
Mail list logo
