On Mon, 26 Feb 2024 06:00:13 GMT, Jaikiran Pai wrote:
>>> (In passing, the casing of "zip file" is very inconsistent in the javadoc,
>>> it's "ZIP file" in some places, "zip file" in others, the change here uses
>>> "Zip file").
>>
>> Thank you for pointing out the discrepancy above.
>>
>>
On Sun, 25 Feb 2024 19:05:58 GMT, Lance Andersen wrote:
> I would suggest "ZIP file" based on the PKWare APPNOTE.TXT,
I think using this case would be good.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17995#discussion_r1502076153
On Sun, 25 Feb 2024 15:26:35 GMT, Alan Bateman wrote:
> (In passing, the casing of "zip file" is very inconsistent in the javadoc,
> it's "ZIP file" in some places, "zip file" in others, the change here uses
> "Zip file").
Thank you for pointing out the discrepancy above.
Let's decide on
On Sun, 25 Feb 2024 14:17:05 GMT, Lance Andersen wrote:
>> Please review this PR which addresses the handling of invalid UTF-8 byte
>> sequences in the entry name of a LOC file header and a Zip file comment
>> which is returned via ZipFile::getComment.
>>
>> As part of the change,
On Sun, 25 Feb 2024 14:17:05 GMT, Lance Andersen wrote:
>> Please review this PR which addresses the handling of invalid UTF-8 byte
>> sequences in the entry name of a LOC file header and a Zip file comment
>> which is returned via ZipFile::getComment.
>>
>> As part of the change,
> Please review this PR which addresses the handling of invalid UTF-8 byte
> sequences in the entry name of a LOC file header and a Zip file comment which
> is returned via ZipFile::getComment.
>
> As part of the change, `ZipFile::getComment` will now return `null` if an
> invalid UTF-8 byte
