Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-12 Thread Ioi Lam
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-12 Thread David Holmes
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-11 Thread Naoto Sato
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-10 Thread David Holmes
On Fri, 8 Dec 2023 21:11:57 GMT, Naoto Sato wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-09 Thread Bernd
On Fri, 8 Dec 2023 21:11:57 GMT, Naoto Sato wrote: > in recent JDK releases. ok, could be that this has changed before. It does make sense to not allow it if the sequence of initialisation can’t be guaranteed. - PR Comment:

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-08 Thread Naoto Sato
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-08 Thread Bernd
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-08 Thread Naoto Sato
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-06 Thread Roger Riggs
On Wed, 6 Dec 2023 20:55:48 GMT, Naoto Sato wrote: >> Currently, Locale-related system properties, such as `user.language` or >> `user.country`, are initialized when the `Locale` class is loaded. Making >> them static properties is safer than relying on the `Locale` class loading >> timing,

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-06 Thread Naoto Sato
> Currently, Locale-related system properties, such as `user.language` or > `user.country`, are initialized when the `Locale` class is loaded. Making > them static properties is safer than relying on the `Locale` class loading > timing, which could potentially be changed depending on the

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-06 Thread Naoto Sato
On Wed, 6 Dec 2023 18:10:05 GMT, Naoto Sato wrote: >> src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 415: >> >>> 413: public static String userRegion() { >>> 414: return USER_REGION; >>> 415: } >> >> Using methods to retrieve these makes is more