On Tue, 19 Dec 2023 03:44:26 GMT, Stuart Marks wrote:
>> It looks the `else-if` and `else` clauses in method
>> `ArraysSupport::hugeLength` could be simplified by `Math::max`.
>
> This change would make the code shorter, but in my opinion, it obscures
> what's going on. This code tries to be
On Sat, 9 Dec 2023 23:19:52 GMT, John Jiang wrote:
> It looks the `else-if` and `else` clauses in method
> `ArraysSupport::hugeLength` could be simplified by `Math::max`.
This change would make the code shorter, but in my opinion, it obscures what's
going on. This code tries to be very
On Sat, 9 Dec 2023 23:19:52 GMT, John Jiang wrote:
> It looks the `else-if` and `else` clauses in method
> `ArraysSupport::hugeLength` could be simplified by `Math::max`.
Could this simple PR be reviewed?
-
PR Comment:
On Sun, 10 Dec 2023 03:57:00 GMT, Jie Fu wrote:
>> It looks the `else-if` and `else` clauses in method
>> `ArraysSupport::hugeLength` could be simplified by `Math::max`.
>
> The JBS should be an enhancement, not a bug, right?
@DamonFool
> The JBS should be an enhancement, not a bug, right?
On Sat, 9 Dec 2023 23:19:52 GMT, John Jiang wrote:
> It looks the `else-if` and `else` clauses in method
> `ArraysSupport::hugeLength` could be simplified by `Math::max`.
The JBS should be an enhancement, not a bug, right?
-
PR Comment:
It looks the `else-if` and `else` clauses in method `ArraysSupport::hugeLength`
could be simplified by `Math::max`.
-
Commit messages:
- 8321637: Simplify if statement in ArraysSupport::hugeLength
Changes: https://git.openjdk.org/jdk/pull/17043/files
Webrev:
