Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-13 Thread Michael Hall
I was thinking of zip api’s other than java’s. The field needs to be at a fixed place in the file format whatever the name? Unless a significant api change has been made. A couple of links from googling on “zip extra field chaining" https://libzip.org/specifications/extrafld.txt

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-13 Thread Alan Bateman
On Sun, 12 May 2024 21:44:56 GMT, Alan Snyder wrote: > I was not using the Zip file system. I was processing a Zip file. They are equivalent, the suggestion to look at the sym link support in the zip file system provider is that it's a much better fit for this extension. It already has

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread -
Hi Mike, I think this particular field has been renamed a few times; and ZipEntry only exposes part of the ZIP format's fields. So most likely there isn't sufficient information for most 3rd-party ZIP processing libraries. I personally don't really use ZipFile so am not quite sure of the recent

Fwd: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Alan Snyder
> > I’m not an expert on ZIp files, but from your description it would seem best > to create a new field. > > I agree that the version made by field is also needed. > > >> On May 12, 2024, at 1:56 PM, - wrote: >> >> Hi Alan Snyder, >> Currently, JDK ZipEntry populates that extraAttributes

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread -
Hi Alan Snyder, Currently, JDK ZipEntry populates that extraAttributes (proposed to rename to externalFileAttributes in JDK-8321274, PR #16952) only if the high byte of the "version made by" field is 3 (indicating Linux compatibility) and only records the most significant 2 bytes for the copied

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Alan Snyder
> It might be interesting to explore that in the context of the zip file system > provider, less sure about the java.util.zip APIs. I was not using the Zip file system. I was processing a Zip file. Alan > On May 12, 2024, at 7:32 AM, Chen Liang wrote: > > On Sun, 12 May 2024 02:48:31

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Chen Liang
On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan wrote: > Add API to access ZipEntry.extraAttributes Also see #16952, another patch that renames this field, which is planning for an integration soon; this PR will be out-of-date when that one is integrated. - PR Comment:

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Alan Bateman
On Sun, 12 May 2024 09:48:42 GMT, xiaotaonan wrote: > This issue was reported by a person named Alan Snyder, I don't have his or > her contact information, how to create a CSR in this situation. He came to core-libs-dev in Dec 2023 [1] to discuss this. The context at the time was symbolic

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Chen Liang
On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan wrote: > Add API to access ZipEntry.extraAttributes For example, with a quick check, you can find that this field itself is not a good candidate for direct setter exposure: 1. For context, this is part of [the central directory file

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Chen Liang
On Sun, 12 May 2024 09:48:42 GMT, xiaotaonan wrote: >> Add API to access ZipEntry.extraAttributes > >> /csr > @AlanBateman > > This issue was reported by a person named Alan Snyder, I don't have his or > her contact information, how to create a CSR in this situation. @xiaotaonan Since you

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread xiaotaonan
On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan wrote: > Add API to access ZipEntry.extraAttributes > /csr @AlanBateman This issue was reported by a person named Alan Snyder, I don't have his or her contact information, how to create a CSR in this situation. - PR Comment:

Re: RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-12 Thread Alan Bateman
On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan wrote: > Add API to access ZipEntry.extraAttributes I think this will require discussion on core libs before proposing APIs in this area. I think a starting point would be explain how you might use this, esp. with file permissions and sym links.

RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-11 Thread xiaotaonan
Add API to access ZipEntry.extraAttributes - Commit messages: - Add API to access ZipEntry.extraAttributes Changes: https://git.openjdk.org/jdk/pull/19204/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19204=00 Issue: https://bugs.openjdk.org/browse/JDK-8322332 Stats: 17

RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-11 Thread xiaotaonan
Add API to access ZipEntry.extraAttributes - Commit messages: - Add API to access ZipEntry.extraAttributes Changes: https://git.openjdk.org/jdk/pull/19202/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19202=00 Issue: https://bugs.openjdk.org/browse/JDK-8322332 Stats: 16