Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

2024-04-08 Thread Maurizio Cimadamore
On Fri, 5 Apr 2024 18:28:58 GMT, Jan Lahoda wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 4443: >> >>> 4441: } >>> 4442: >>> 4443: @Override >> >> As usual, I suggest to add some brief comment with the shape of the >> generated code. > > Done here:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

2024-04-05 Thread Jan Lahoda
On Fri, 5 Apr 2024 13:09:56 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JavaCompiler cleanup > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2117: > >> 2115:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

2024-04-05 Thread Maurizio Cimadamore
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >> The

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

2024-04-05 Thread Maurizio Cimadamore
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >> The

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

2024-04-05 Thread Maurizio Cimadamore
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >> The

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

2024-04-05 Thread Jan Lahoda
> This is a patch for javac, that adds the Derived Record Creation expressions. > The current draft specification for the feature is: > https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html > > The current CSR is here: >