> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
Dan Lutker has updated the pull request incrementally with one additional
commit since the last revision:
Fix
On Tue, 13 Feb 2024 22:02:15 GMT, Roger Riggs wrote:
>> Any reason not to use
>> [exesanity_SimpleNativeLauncher](https://github.com/openjdk/jdk/blob/628cd8a489fd54db18204c3bbaf4339d7ab5e9d6/test/jdk/native_sanity/simplenativelauncher/exesanity_SimpleNativeLauncher.c)
>> or
>>
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
Dan Lutker has updated the pull request incrementally with two additional
commits since the last revision:
-
On Tue, 13 Feb 2024 18:03:14 GMT, Dan Lutker wrote:
>> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
>> package and no coreutils executable as well as AmazonLinux 2023 that uses
>> `--enable-single-binary`
>
> Dan Lutker has updated the pull request incrementally
On Tue, 13 Feb 2024 21:23:29 GMT, Dan Lutker wrote:
>> At the time `sleep` seemed ubiquitous and was native so it ran quickly.
>> (Much quicker than running java).
>> Running another program would be fine. For example ,selecting an executable
>> based on the OS type and giving the expected
On Tue, 13 Feb 2024 19:23:50 GMT, Roger Riggs wrote:
>>> what's the output for `coreutils --help` for a single executable binary?
>>
>>
>> # coreutils --help
>> Usage: coreutils --coreutils-prog=PROGRAM_NAME [PARAMETERS]...
>> Execute the PROGRAM_NAME built-in program with the given
On Tue, 13 Feb 2024 18:24:10 GMT, Dan Lutker wrote:
>> To be fair, this looks similar to what `isMusl()` does: searching for
>> strings in outputs. But I do wonder if `--help` would include "sleep" for
>> some innocuous description somewhere, and this code would accidentally
>> match.
On Tue, 13 Feb 2024 18:19:48 GMT, Aleksey Shipilev wrote:
> what's the output for `coreutils --help` for a single executable binary?
# coreutils --help
Usage: coreutils --coreutils-prog=PROGRAM_NAME [PARAMETERS]...
Execute the PROGRAM_NAME built-in program with the given PARAMETERS.
On Tue, 13 Feb 2024 18:15:59 GMT, Dan Lutker wrote:
>> Just ignore the binary name and only check for argv1 is imho enough.
>
> I couldn't think if a better way to detect what the host system had and
> adding this seemed inline with the busybox check.
>
> The choice of running `sleep` seems
On Tue, 13 Feb 2024 18:08:03 GMT, Bernd wrote:
>> test/lib/jdk/test/lib/Platform.java line 145:
>>
>>> 143: }
>>> 144:
>>> 145: public static boolean isOSX() {
>>
>> This seems like a real hack. Is there really no better way to identity how
>> sleep is implemented.
>> I'd probably
On Tue, 13 Feb 2024 17:54:43 GMT, Roger Riggs wrote:
>> Dan Lutker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary var.
>
> test/lib/jdk/test/lib/Platform.java line 145:
>
>> 143: }
>> 144:
>> 145: public
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
Dan Lutker has updated the pull request incrementally with one additional
commit since the last revision:
Remove
On Fri, 9 Feb 2024 23:40:00 GMT, Dan Lutker wrote:
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
test/lib/jdk/test/lib/Platform.java line 145:
> 143: }
>
On Tue, 13 Feb 2024 10:11:36 GMT, Aleksey Shipilev wrote:
>> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
>> package and no coreutils executable as well as AmazonLinux 2023 that uses
>> `--enable-single-binary`
>
> test/jdk/java/lang/ProcessHandle/InfoTest.java line
On Fri, 9 Feb 2024 23:40:00 GMT, Dan Lutker wrote:
> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
> package and no coreutils executable as well as AmazonLinux 2023 that uses
> `--enable-single-binary`
test/jdk/java/lang/ProcessHandle/InfoTest.java line 321:
> 319:
15 matches
Mail list logo
