On Tue, 12 Mar 2024 18:42:48 GMT, Erik Joelsson wrote:
>> Chad Rakoczy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code cleanup
>
> I'm fine with just using VERSION_FEATURE. I think it's a simple and
> straightforward enough
On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>>
On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>>
On Mon, 11 Mar 2024 20:04:48 GMT, Roger Riggs wrote:
>> Chad Rakoczy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code cleanup
>
> make/modules/java.base/Launcher.gmk line 85:
>
>> 83: -DVERSION_INTERIM=$(VERSION_INTERIM)
On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>>
On Mon, 11 Mar 2024 18:36:57 GMT, Aleksey Shipilev wrote:
> > If you really want to require an exact match for jspawnhelper, then these 4
> > numbers aren't necessarily enough, but a rather arbitrarily chosen
> > approximation.
>
> I think for our purposes, a version number quadruplet is
On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>>
> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>
> Updates jspawnhelper to check that JDK version and jspawnhelper version are
> the same. Updates test to include check for version. Also tested manually by
> replacing jspawnhelper with incorrect version to confirm that check
