Re: RFR: 8326941: Remove StringUTF16::isBigEndian

2024-03-19 Thread Per Minborg
On Mon, 18 Mar 2024 22:51:55 GMT, Claes Redestad wrote: >> This PR proposes to remove the native method `StringUTF16::isBigEndian` and >> its corresponding C implementation and instead rely on the >> `jdk.internal.misc.Unsafe::isBigEndian` method. >> >> This PR passes tier1-3 tests. > >>

Re: RFR: 8326941: Remove StringUTF16::isBigEndian

2024-03-18 Thread Claes Redestad
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote: > This PR proposes to remove the native method `StringUTF16::isBigEndian` and > its corresponding C implementation and instead rely on the > `jdk.internal.misc.Unsafe::isBigEndian` method. > > This PR passes tier1-3 tests. > Initialization

Re: RFR: 8326941: Remove StringUTF16::isBigEndian

2024-03-18 Thread Per Minborg
On Mon, 18 Mar 2024 14:35:06 GMT, Claes Redestad wrote: > Does this change how early `Unsafe` is initialized, and does it in turn have > dependencies on `StringUTF16`? `StringUTF16` is loaded very early, especially > if `-XX:-CompactStrings` is supplied and I would assume the only reason this

Re: RFR: 8326941: Remove StringUTF16::isBigEndian

2024-03-18 Thread Claes Redestad
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote: > This PR proposes to remove the native method `StringUTF16::isBigEndian` and > its corresponding C implementation and instead rely on the > `jdk.internal.misc.Unsafe::isBigEndian` method. Does this change how early `Unsafe` is initialized,

Re: RFR: 8326941: Remove StringUTF16::isBigEndian

2024-03-18 Thread Roger Riggs
On Mon, 18 Mar 2024 14:09:09 GMT, Per Minborg wrote: > This PR proposes to remove the native method `StringUTF16::isBigEndian` and > its corresponding C implementation and instead rely on the > `jdk.internal.misc.Unsafe::isBigEndian` method. Nice Cleanup. - Marked as reviewed by

RFR: 8326941: Remove StringUTF16::isBigEndian

2024-03-18 Thread Per Minborg
This PR proposes to remove the native method `StringUTF16::isBigEndian` and its corresponding C implementation and instead rely on the `jdk.internal.misc.Unsafe::isBigEndian` method. - Commit messages: - Update copyright years - Remove native method Changes: