Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]

2024-04-08 Thread SendaoYan
On Mon, 11 Mar 2024 15:15:39 GMT, Naoto Sato wrote: > LGTM @naotoj Thanks for the review. - PR Comment: https://git.openjdk.org/jdk/pull/18155#issuecomment-2043989340

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]

2024-04-08 Thread SendaoYan
On Sat, 9 Mar 2024 13:18:14 GMT, SendaoYan wrote: >> Date.toString() uses Locale.US explicitly for printing the time zone, so >> replace Locale.ROOT to Locale.US in this testcase for fix the test failure. >> >> This testcase fixed has been verified. >> >> Only change the testcase, risk is

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]

2024-03-11 Thread Naoto Sato
On Sat, 9 Mar 2024 13:18:14 GMT, SendaoYan wrote: >> Date.toString() uses Locale.US explicitly for printing the time zone, so >> replace Locale.ROOT to Locale.US in this testcase for fix the test failure. >> >> This testcase fixed has been verified. >> >> Only change the testcase, risk is

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]

2024-03-09 Thread SendaoYan
> Date.toString() uses Locale.US explicitly for printing the time zone, so > replace Locale.ROOT to Locale.US in this testcase for fix the test failure. > > This testcase fixed has been verified. > > Only change the testcase, risk is low. SendaoYan has updated the pull request incrementally

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v3]

2024-03-09 Thread SendaoYan
On Fri, 8 Mar 2024 17:29:09 GMT, Naoto Sato wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the Locale.US code comment >> >> Signed-off-by: sendaoYan > >

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]

2024-03-08 Thread Naoto Sato
On Fri, 8 Mar 2024 02: 41: 06 GMT, SendaoYan wrote: >> Date. toString() uses Locale. US explicitly for printing the time zone, so replace Locale. ROOT to Locale. US in this testcase for fix the test failure. >> ZjQcmQRYFpfptBannerStart This Message Is From an External

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]

2024-03-07 Thread SendaoYan
On Thu, 7 Mar 2024 21:07:12 GMT, Naoto Sato wrote: > Thanks for the fix. Although setting `Locale.US` to acquire the formatter is > correct, the reasoning is not. The real reason is that `Date.toString()` uses > `Locale.US` explicitly for printing the time zone > >

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]

2024-03-07 Thread SendaoYan
On Fri, 8 Mar 2024 02:41:06 GMT, SendaoYan wrote: >> Date.toString() uses Locale.US explicitly for printing the time zone, so >> replace Locale.ROOT to Locale.US in this testcase for fix the test failure. >> >> This testcase fixed has been verified. >> >> Only change the testcase, risk is

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269 [v2]

2024-03-07 Thread SendaoYan
> The DATE_FORMAT_PATTERN is set to "EEE MMM dd HH:mm:ss zzz ", is the time > format of US. So, creates a formatter should using Locale.US, rather than > Locale.ROOT, which means empty. SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269

2024-03-07 Thread Naoto Sato
On Thu, 7 Mar 2024 16:47:01 GMT, SendaoYan wrote: > The DATE_FORMAT_PATTERN is set to "EEE MMM dd HH:mm:ss zzz ", is the time > format of US. So, creates a formatter should using Locale.US, rather than > Locale.ROOT, which means empty. Thanks for the fix. Although setting `Locale.US` to

RFR: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269

2024-03-07 Thread SendaoYan
The DATE_FORMAT_PATTERN is set to "EEE MMM dd HH:mm:ss zzz ", is the time format of US. So, creates a formatter should using Locale.US, rather than Locale.ROOT, which means empty. - Commit messages: - 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx'