On Wed, 13 Mar 2024 14:23:01 GMT, Raffaello Giulietti
wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Generate large strings in parameter generator methods
>
> I was thinking more something like
>
>
On Wed, 13 Mar 2024 21:07:54 GMT, Christoph Langer wrote:
>> 4f336085d1098e7fba7b58f0a73c028179a2a13d
>> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
>> cases to test java/util/Formatter/Padding.java with huge Strings as
>> arguments. Since all possible argument
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument combinations for the test are stored
> in one array, nothing can
On Wed, 13 Mar 2024 14:23:01 GMT, Raffaello Giulietti
wrote:
> Can you please add the bug id to `@bug` and correct the typo, as suggested
> [here](https://github.com/openjdk/jdk/pull/18264#issuecomment-1994382507)?
Done.
I kept the tenMillion... handling.
-
PR Comment:
On Wed, 13 Mar 2024 14:10:29 GMT, Christoph Langer wrote:
>> 4f336085d1098e7fba7b58f0a73c028179a2a13d
>> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
>> cases to test java/util/Formatter/Padding.java with huge Strings as
>> arguments. Since all possible argument
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument combinations for the test are stored
> in one array, nothing can
On Wed, 13 Mar 2024 09:42:34 GMT, Raffaello Giulietti
wrote:
> What about factoring out the 4 invocations of `tenMillionBlanks()` in each
> source method in a local var?
OK, I inlined the generation of the ten million character strings into the
parameter generator methods. I looked a bit at
On Wed, 13 Mar 2024 07:53:30 GMT, Christoph Langer wrote:
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument
On Wed, 13 Mar 2024 07:53:30 GMT, Christoph Langer wrote:
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument
4f336085d1098e7fba7b58f0a73c028179a2a13d
([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few cases
to test java/util/Formatter/Padding.java with huge Strings as arguments. Since
all possible argument combinations for the test are stored in one array,
nothing can be garbage
10 matches
Mail list logo