Re: RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

2024-03-18 Thread Magnus Ihse Bursie
On Sat, 16 Mar 2024 00:08:04 GMT, Sandhya Viswanathan wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make all ALIGN/.align aligned > > Looks good to me. Thanks @sviswa7! - PR Comment:

Re: RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

2024-03-16 Thread Sandhya Viswanathan
On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie wrote: >> As part of the ongoing effort to enable jcheck whitespace checking to all >> text files, it is now time to address assembly (.S) files. The hotspot >> assembly files were fixed as part of the hotspot mapfile removal, so only a >>

Re: RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

2024-03-15 Thread Magnus Ihse Bursie
On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie wrote: >> As part of the ongoing effort to enable jcheck whitespace checking to all >> text files, it is now time to address assembly (.S) files. The hotspot >> assembly files were fixed as part of the hotspot mapfile removal, so only a >>

Re: RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

2024-03-13 Thread Erik Joelsson
On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie wrote: >> As part of the ongoing effort to enable jcheck whitespace checking to all >> text files, it is now time to address assembly (.S) files. The hotspot >> assembly files were fixed as part of the hotspot mapfile removal, so only a >>

Re: RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

2024-03-13 Thread Magnus Ihse Bursie
> As part of the ongoing effort to enable jcheck whitespace checking to all > text files, it is now time to address assembly (.S) files. The hotspot > assembly files were fixed as part of the hotspot mapfile removal, so only a > single incorrect jdk library remains. > > The main issue with