Re: RFR: 8328995: Launcher can't open jar files where the offset of the manifest is >4GB [v6]

2024-05-30 Thread Liam Miller-Cushon
On Thu, 4 Apr 2024 16:57:40 GMT, Liam Miller-Cushon wrote: >> This change fixes a zip64 bug in the launcher that is prevent it from >> reading the manifest of jars where the 'relative offset of local header' >> field in the central directory entry is >4GB. As described in APPNOTE.TXT >>

Re: RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v6]

2024-05-02 Thread Alan Bateman
On Thu, 2 May 2024 17:17:54 GMT, Liam Miller-Cushon wrote: > Please keep this open, assistance on progressing this pull request is welcome ACK. There was a lengthy bug tail when zip64 support was added. We've got away without needing this for executable JAR files for a long time so it's great

Re: RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v6]

2024-05-02 Thread Liam Miller-Cushon
On Thu, 4 Apr 2024 16:57:40 GMT, Liam Miller-Cushon wrote: >> This change fixes a zip64 bug in the launcher that is prevent it from >> reading the manifest of jars where the 'relative offset of local header' >> field in the central directory entry is >4GB. As described in APPNOTE.TXT >>

Re: RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v6]

2024-04-04 Thread Liam Miller-Cushon
> This change fixes a zip64 bug in the launcher that is prevent it from reading > the manifest of jars where the 'relative offset of local header' field in the > central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the > offset is too large to be stored in the central directory