Re: RFR: 8329948: Remove string template feature [v4]

2024-04-11 Thread Maurizio Cimadamore
On Thu, 11 Apr 2024 09:12:06 GMT, Jan Lahoda wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix issues in digit classes > > test/langtools/jdk/jshell/CompletionSuggestionTest.java line 327: > >> 325:

Re: RFR: 8329948: Remove string template feature [v4]

2024-04-11 Thread Jan Lahoda
On Wed, 10 Apr 2024 10:59:25 GMT, Maurizio Cimadamore wrote: >> This PR removes support for the string template feature from the Java >> compiler and the Java SE API, as discussed here: >> >> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html > > Maurizio Cimadamore

Re: RFR: 8329948: Remove string template feature [v4]

2024-04-10 Thread Maurizio Cimadamore
On Wed, 10 Apr 2024 15:17:19 GMT, Jan Lahoda wrote: >> Good catch. Since this was tweaked to be a public API as part of the string >> template feature, I've reverted this code to what it was prior to string >> template. That is, now this is a private static final constant, with >> initializer

Re: RFR: 8329948: Remove string template feature [v4]

2024-04-10 Thread Jan Lahoda
On Wed, 10 Apr 2024 10:44:13 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line >> 120: >> >>> 118: * @since 21 >>> 119: */ >>> 120: public static final int MAX_INDY_CONCAT_ARG_SLOTS; >> >> May this value change in the

Re: RFR: 8329948: Remove string template feature [v4]

2024-04-10 Thread Maurizio Cimadamore
> This PR removes support for the string template feature from the Java > compiler and the Java SE API, as discussed here: > > https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html Maurizio Cimadamore has updated the pull request incrementally with one additional commit