Re: RFR: 8330276: Console methods with explicit Locale [v7]

2024-05-16 Thread Naoto Sato
On Wed, 15 May 2024 17:05:17 GMT, Naoto Sato wrote: >> Proposing new overloaded methods in `java.io.Console` class that explicitly >> take a `Locale` argument. Existing methods rely on the default locale, so >> the users won't be able to format their prompts/outputs in a certain locale >>

Re: RFR: 8330276: Console methods with explicit Locale [v7]

2024-05-15 Thread Jan Lahoda
On Wed, 15 May 2024 17:05:17 GMT, Naoto Sato wrote: >> Proposing new overloaded methods in `java.io.Console` class that explicitly >> take a `Locale` argument. Existing methods rely on the default locale, so >> the users won't be able to format their prompts/outputs in a certain locale >>

Re: RFR: 8330276: Console methods with explicit Locale [v7]

2024-05-15 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request

Re: RFR: 8330276: Console methods with explicit Locale [v6]

2024-05-15 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request

Re: RFR: 8330276: Console methods with explicit Locale [v5]

2024-05-14 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request with a

Re: RFR: 8330276: Console methods with explicit Locale [v4]

2024-05-08 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request

Re: RFR: 8330276: Console methods with explicit Locale [v3]

2024-05-06 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request with a

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-05-03 Thread Roger Riggs
On Mon, 29 Apr 2024 23:22:21 GMT, Naoto Sato wrote: >> Proposing new overloaded methods in `java.io.Console` class that explicitly >> take a `Locale` argument. Existing methods rely on the default locale, so >> the users won't be able to format their prompts/outputs in a certain locale >>

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-05-01 Thread Naoto Sato
On Wed, 1 May 2024 17:10:53 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > src/java.base/share/classes/java/io/ProxyingConsole.java line 89: > >> 87: @Override >>

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-05-01 Thread Roger Riggs
On Mon, 29 Apr 2024 23:22:21 GMT, Naoto Sato wrote: >> Proposing new overloaded methods in `java.io.Console` class that explicitly >> take a `Locale` argument. Existing methods rely on the default locale, so >> the users won't be able to format their prompts/outputs in a certain locale >>

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-04-29 Thread Joe Wang
On Mon, 29 Apr 2024 23:22:21 GMT, Naoto Sato wrote: >> Proposing new overloaded methods in `java.io.Console` class that explicitly >> take a `Locale` argument. Existing methods rely on the default locale, so >> the users won't be able to format their prompts/outputs in a certain locale >>

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-04-29 Thread Naoto Sato
On Mon, 29 Apr 2024 21:54:55 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > src/java.base/share/classes/java/io/Console.java line 193: > >> 191: * {@code locale}.

Re: RFR: 8330276: Console methods with explicit Locale

2024-04-29 Thread Naoto Sato
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote: > Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale >

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-04-29 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request

Re: RFR: 8330276: Console methods with explicit Locale

2024-04-29 Thread Joe Wang
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote: > Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale >

RFR: 8330276: Console methods with explicit Locale

2024-04-24 Thread Naoto Sato
Proposing new overloaded methods in `java.io.Console` class that explicitly take a `Locale` argument. Existing methods rely on the default locale, so the users won't be able to format their prompts/outputs in a certain locale explicitly. - Commit messages: - Not using System.err