> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are needed for some overriding methods for the purpose
> of
On Mon, 13 May 2024 18:00:27 GMT, Chen Liang wrote:
>> I don't want to merge or rebase on an active PR. It should get fixed once
>> this is integrated.
>
> Sure, this comment serves as a note to reviewers that these 2 header changes
> have been committed in other changes and thus can be safely
On Mon, 13 May 2024 17:52:23 GMT, Chen Liang wrote:
>> Nizar Benalla has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - (C)
>> - (C)
>
> src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java line
> 2:
>
>> 1: /*
>>
On Mon, 13 May 2024 17:57:42 GMT, Nizar Benalla wrote:
>> src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java line
>> 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 1998, 2023, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> This diff is redundant but no-op. You
On Mon, 13 May 2024 17:44:52 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are needed for some overriding methods for the purpose
> of
While `@since` might not be considered a normative part of the
specification, (it's effectively a cache of derived meta-data) it is
part of the generated documentation, and as such deserves to be correct.
-- Jon
On 5/5/24 4:33 PM, Pavel Rappo wrote:
On Mon, 29 Apr 2024 17:46:24 GMT, Nizar
On Mon, 6 May 2024 15:20:08 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are needed for some overriding methods for the purpose
> of
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are
On Fri, 26 Apr 2024 09:30:23 GMT, Nizar Benalla wrote:
> We will effectively enforce javadoc comment for some method overrides with
> the checker
Those overriding methods don't even appear on the javadoc output. If you go to
search for `CompletableFuture.resultNow` on
On Mon, 29 Apr 2024 17:26:53 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 345:
>>
>>> 343: * @throwsIllegalArgumentException {@inheritDoc}
>>> 344: * @throwsIOException {@inheritDoc}
>>> 345: * @throwsOutOfMemoryError
On Mon, 29 Apr 2024 16:07:14 GMT, Pavel Rappo wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Mon, 29 Apr 2024 17:46:24 GMT, Nizar Benalla wrote:
> Pavel, can I simply change the PR/issue title to be more descriptive? As I
> want to include the the inherit doc because of the unchecked exceptions,
> rather than clean this up in a different PR
I suggest dropping all the changes that
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are
On Mon, 29 Apr 2024 22:54:47 GMT, Chen Liang wrote:
> would be nice if you can share more about these (also about the behaviors of
> inheriting `@throws` etc.
I hope this document explains it well; if it doesn't, we should fix it:
On Mon, 29 Apr 2024 20:02:32 GMT, Pavel Rappo wrote:
>>> > We will effectively enforce javadoc comment for some method overrides
>>> > with the checker
>>>
>>> Those overriding methods don't even appear on the javadoc output. If you go
>>> to search for `CompletableFuture.resultNow` on
>>>
On Fri, 26 Apr 2024 14:52:08 GMT, Chen Liang wrote:
> > We will effectively enforce javadoc comment for some method overrides with
> > the checker
>
> Those overriding methods don't even appear on the javadoc output. If you go
> to search for `CompletableFuture.resultNow` on
>
On Sat, 27 Apr 2024 10:33:42 GMT, Nizar Benalla wrote:
> Also have you looked at the output documentation? Without the `@inheritDoc`
> tags the content will only have a since tag, which is definitely wrong.
This is not how I remember it. Unless written around, `{@inheritDoc}` in a main
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are
Please review this PR that aims to add all the remaining needed `@since` tags
in `java.base`, and group them into a single fix.
This is related to #18934 and my work around the `@since` checker feature.
Explicit `@since` tags are needed for some overriding methods for the purpose
of the checker.
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are
On Thu, 25 Apr 2024 16:43:50 GMT, Chen Liang wrote:
> I think your changes mostly group in these categories:
>
> 1. New API methods provided in superclasses/superinterfaces, this class
> provides a more concrete implementation:
>Examples being `CompletableFuture`, `FileInputStream`,
24 matches
Mail list logo
