Re: RFR: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent [v2]

2024-05-06 Thread Justin Lu
On Sun, 5 May 2024 20:51:10 GMT, Axel Hauschulte wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - correct other test comment >> - reflect review > > Hello, I filed

Re: RFR: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent [v2]

2024-05-05 Thread Axel Hauschulte
On Fri, 3 May 2024 18:29:23 GMT, Justin Lu wrote: >> Please review this PR which corrects an edge case bug for >> java.text.DecimalFormat that causes incorrect parsing results for strings >> with very large exponent values. >> >> When parsing values with large exponents, if the value of the

Re: RFR: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent [v2]

2024-05-03 Thread Naoto Sato
On Fri, 3 May 2024 18:29:23 GMT, Justin Lu wrote: >> Please review this PR which corrects an edge case bug for >> java.text.DecimalFormat that causes incorrect parsing results for strings >> with very large exponent values. >> >> When parsing values with large exponents, if the value of the

Re: RFR: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent [v2]

2024-05-03 Thread Justin Lu
On Fri, 3 May 2024 18:24:31 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/DecimalFormat.java line 2596: >> >>> 2594: exponent = -exponent; >>> 2595: } >>> 2596: sawExponent = true; >> >> I see you

Re: RFR: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent [v2]

2024-05-03 Thread Justin Lu
On Fri, 3 May 2024 18:02:05 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - correct other test comment >> - reflect review > > src/java.base/share/classes/java/text/DecimalFormat.java line 2596: >

Re: RFR: 8331485: Odd Results when Parsing Scientific Notation with Large Exponent [v2]

2024-05-03 Thread Justin Lu
> Please review this PR which corrects an edge case bug for > java.text.DecimalFormat that causes incorrect parsing results for strings > with very large exponent values. > > When parsing values with large exponents, if the value of the exponent > exceeds `Integer.MAX_VALUE`, the parsed value