On Fri, 10 May 2024 15:32:07 GMT, Jan Lahoda wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
On Fri, 10 May 2024 11:00:55 GMT, Jan Lahoda wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
On Tue, 7 May 2024 07:13:23 GMT, Jan Lahoda wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not print
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
On Mon, 6 May 2024 16:59:40 GMT, Naoto Sato wrote:
> For the latter, since you are already at it, I just reassigned the bug to you
>
@lahodaj, since a test for 8331681 is added to this PR, I'd suggest you do
this: `/issue add 8331681`.
-
PR Review Comment:
On Mon, 6 May 2024 16:09:19 GMT, Jan Lahoda wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not print
On Mon, 6 May 2024 16:05:58 GMT, Jan Lahoda wrote:
>>> We have a test that checks if `System.console()` returns the correct
>>> Console (or null) from the expected module
>>> (`test/jdk/java/io/Console/ModuleSelectionTest.java`)
>>>
>>
>> Good; then here we should indeed specify
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
On Fri, 3 May 2024 21:59:40 GMT, Pavel Rappo wrote:
>>> Ideally, we should have separate tests that make sure that jdk.internal.le
>>> is the default impl.
>>
>> We have a test that checks if `System.console()` returns the correct Console
>> (or null) from the expected module
>>
On Fri, 3 May 2024 11:20:52 GMT, Pavel Rappo wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
>
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
On Fri, 3 May 2024 19:02:41 GMT, Naoto Sato wrote:
> We have a test that checks if `System.console()` returns the correct Console
> (or null) from the expected module
> (`test/jdk/java/io/Console/ModuleSelectionTest.java`)
>
Good; then here we should indeed specify
On Fri, 3 May 2024 18:52:12 GMT, Pavel Rappo wrote:
> Ideally, we should have separate tests that make sure that jdk.internal.le is
> the default impl.
We have a test that checks if `System.console()` returns the correct Console
(or null) from the expected module
On Fri, 3 May 2024 17:07:59 GMT, Naoto Sato wrote:
> Or maybe we could explicitly specify `-Djdk.console=jdk.internal.le` to the
> test.
We could do that, or we could replace `jdk.internal.le` with "default" in the
summary.
Ideally, we should have separate tests that make sure that
On Fri, 3 May 2024 11:12:48 GMT, Pavel Rappo wrote:
>> When JLine reads a line, there may be a prompt provided. However, JLine will
>> not interpret the prompt literally, it will handle `%` specially. As a
>> consequence, doing:
>>
>> System.console().readLine("%%s");
>>
>>
>> will not
On Fri, 3 May 2024 10:11:02 GMT, Jan Lahoda wrote:
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`,
When JLine reads a line, there may be a prompt provided. However, JLine will
not interpret the prompt literally, it will handle `%` specially. As a
consequence, doing:
System.console().readLine("%%s");
will not print `%s`, as first `String.format` is used, which will convert `%%s`
to `%s`,
19 matches
Mail list logo
