Re: RFR: 8331724: Refactor j.l.constant implementation to internal package [v4]

2024-05-07 Thread Chen Liang
On Tue, 7 May 2024 16:40:08 GMT, ExE Boss wrote: >> `currentDepth` must be 0 in this case, so `rank` or `netRank` doesn't >> matter. Overriding in `PrimitiveClassDescImpl` sounds reasonable, but then >> perhaps default method should be removed, too, since it would look strange >> to have the

Re: RFR: 8331724: Refactor j.l.constant implementation to internal package [v4]

2024-05-07 Thread ExE Boss
On Mon, 6 May 2024 15:18:17 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 222: >> >>> 220: } >>> 221: if (desc.length() == 1 && desc.charAt(0) == 'V') { >>> 222: throw new IllegalArgumentException(String.format("not

Re: RFR: 8331724: Refactor j.l.constant implementation to internal package [v4]

2024-05-07 Thread Chen Liang
On Tue, 7 May 2024 14:59:21 GMT, Claes Redestad wrote: >> This PR suggests refactoring the implementation classes of >> java.lang.constant into a new package jdk.internal.constant to enable >> sharing some trusted static factory methods with users elsewhere in >> java.base, such as

Re: RFR: 8331724: Refactor j.l.constant implementation to internal package [v4]

2024-05-07 Thread Claes Redestad
> This PR suggests refactoring the implementation classes of java.lang.constant > into a new package jdk.internal.constant to enable sharing some trusted > static factory methods with users elsewhere in java.base, such as > java.lang.invoke and java.lang.classfile. The refactoring also adds