Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-11-16 Thread Srinivas Vamsi Parasa
On Thu, 16 Nov 2023 17:33:02 GMT, Vladimir Yaroslavskiy wrote: >> Hello Vladimir (@iaroslavski) >> >> Will provide the performance data using AVX512 sort as baseline by early >> next week. >> (Friday is a holiday for us due to Veterans Day) >> >> Thanks, >> Vamsi > > Hello Vamsi

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-11-16 Thread Srinivas Vamsi Parasa
On Thu, 9 Nov 2023 18:12:36 GMT, Srinivas Vamsi Parasa wrote: >> Hello @PaulSandoz and @AlanBateman ! >> >> Did you have time to look at the latest benchmarking? > > Hello Vladimir (@iaroslavski) > > Will provide the performance data using AVX512 sort as baseline by early next > week. >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-11-16 Thread Vladimir Yaroslavskiy
On Thu, 9 Nov 2023 18:12:36 GMT, Srinivas Vamsi Parasa wrote: >> Hello @PaulSandoz and @AlanBateman ! >> >> Did you have time to look at the latest benchmarking? > > Hello Vladimir (@iaroslavski) > > Will provide the performance data using AVX512 sort as baseline by early next > week. >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-11-09 Thread Vladimir Yaroslavskiy
On Fri, 27 Oct 2023 13:26:33 GMT, Vladimir Yaroslavskiy wrote: >>> Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with >>> Radix sort in parallel case only? >> >> I think its definitely a better fit, but another aspect of my previous >> comment was wondering if we need

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-11-09 Thread Srinivas Vamsi Parasa
On Fri, 27 Oct 2023 13:26:33 GMT, Vladimir Yaroslavskiy wrote: >>> Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with >>> Radix sort in parallel case only? >> >> I think its definitely a better fit, but another aspect of my previous >> comment was wondering if we need

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-10-27 Thread null
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote: >>> > Alan, you mentioned that DualPivotQuicksort will need detailed review. >>> > Can we go ahead and start reviewing? Laurent checked performance, JMH >>> > results look fine. >>> >>> As before, I think the main question with this change

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-10-24 Thread iaroslavski
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote: >>> > Alan, you mentioned that DualPivotQuicksort will need detailed review. >>> > Can we go ahead and start reviewing? Laurent checked performance, JMH >>> > results look fine. >>> >>> As before, I think the main question with this change

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-10-22 Thread iaroslavski
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote: > > Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with > > Radix sort in parallel case only? > > I think its definitely a better fit, but another aspect of my previous > comment was wondering if we need a radix sort

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-23 Thread iaroslavski
On Thu, 21 Sep 2023 23:40:25 GMT, Srinivas Vamsi Parasa wrote: >>> Hi Vladimir, >>> >>> Just trying to understand: is there a reason to use >>> `DualPivotQuicksort_RadixForParallel.java` and >>> `DualPivotQuicksort_RadixForAll.java`? >>> >>> Would it not be sufficient to do the following

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-21 Thread Srinivas Vamsi Parasa
On Thu, 21 Sep 2023 07:43:47 GMT, iaroslavski wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated comments (v23.08) > >> Hi Vladimir, >> >> Just trying to understand: is there a reason to use >>

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-21 Thread iaroslavski
On Wed, 30 Aug 2023 10:55:48 GMT, Laurent Bourgès wrote: >> * improved mixed insertion sort (makes whole sorting faster) >> * introduced Radix which sort shows several times boost of performance and >> has linear complexity instead of n*ln(n) >> * improved merging sort for almost sorted data

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-20 Thread iaroslavski
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote: > I think its definitely a better fit, but another aspect of my previous > comment was wondering if we need a radix sort if the vectorized quicksort > implementation is fast enough. IMO we need to compare performance results > with the

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-20 Thread Paul Sandoz
On Fri, 15 Sep 2023 20:17:17 GMT, Paul Sandoz wrote: >>> Alan, you mentioned that DualPivotQuicksort will need detailed review. Can >>> we go ahead and start reviewing? Laurent checked performance, JMH results >>> look fine. >> >> As before, I think the main question with this change is

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-20 Thread iaroslavski
On Fri, 15 Sep 2023 20:17:17 GMT, Paul Sandoz wrote: >>> Alan, you mentioned that DualPivotQuicksort will need detailed review. Can >>> we go ahead and start reviewing? Laurent checked performance, JMH results >>> look fine. >> >> As before, I think the main question with this change is

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-16 Thread iaroslavski
On Fri, 15 Sep 2023 20:17:17 GMT, Paul Sandoz wrote: > > > Alan, you mentioned that DualPivotQuicksort will need detailed review. > > > Can we go ahead and start reviewing? Laurent checked performance, JMH > > > results look fine. > > > > As before, I think the main question with this change

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-15 Thread Paul Sandoz
On Fri, 1 Sep 2023 06:12:57 GMT, Alan Bateman wrote: > > Alan, you mentioned that DualPivotQuicksort will need detailed review. Can > > we go ahead and start reviewing? Laurent checked performance, JMH results > > look fine. > > As before, I think the main question with this change is whether

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-15 Thread iaroslavski
On Wed, 30 Aug 2023 10:55:48 GMT, Laurent Bourgès wrote: >> * improved mixed insertion sort (makes whole sorting faster) >> * introduced Radix which sort shows several times boost of performance and >> has linear complexity instead of n*ln(n) >> * improved merging sort for almost sorted data

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-08 Thread iaroslavski
On Fri, 1 Sep 2023 06:12:57 GMT, Alan Bateman wrote: >> Hi team, >> @AlanBateman, @rose00, @mbreinhold >> >> There are a big efforts now to improve sorting with x86_64 AVX512 >> https://github.com/openjdk/jdk/pull/14227, no changes of >> Dual-Pivot Quicksort logic. >> >> But at the same time

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-01 Thread Alan Bateman
On Thu, 31 Aug 2023 14:29:41 GMT, iaroslavski wrote: > Alan, you mentioned that DualPivotQuicksort will need detailed review. Can we > go ahead and start reviewing? Laurent checked performance, JMH results look > fine. As before, I think the main question with this change is whether adding

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-08-31 Thread iaroslavski
On Wed, 30 Aug 2023 10:55:48 GMT, Laurent Bourgès wrote: >> * improved mixed insertion sort (makes whole sorting faster) >> * introduced Radix which sort shows several times boost of performance and >> has linear complexity instead of n*ln(n) >> * improved merging sort for almost sorted data

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-08-30 Thread Laurent Bourgès
> * improved mixed insertion sort (makes whole sorting faster) > * introduced Radix which sort shows several times boost of performance and > has linear complexity instead of n*ln(n) > * improved merging sort for almost sorted data > * optimized parallel sorting > * improved step for pivot