Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-12-21 Thread Rajan Halade
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote: >> Are you saying that we don't need to run the ExtDir2.policy and >> ExtDir3.policy? > > Its fine, ignore my previous comment. you can add multiple run tags under same test tag, no need to repeat tag, bug, and summary tags.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-19 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-19 Thread Mahendra Chhipa
On Tue, 18 Oct 2022 22:11:57 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: >> >>> 2: permission javax.crypto.CryptoAllPermission; >>> 3: permission javax.crypto.CryptoPermission "DES", 64; >>> 4: } >> >> please remove extra line. > > I

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Bill Huang
On Tue, 18 Oct 2022 19:53:50 GMT, Mahendra Chhipa wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AssertThrows an exception in InconsistentEntries test. > >

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-17 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java >