Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-27 Thread Matthias Baesken
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-26 Thread Alexander Matveev
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-26 Thread Logan Abernathy
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-26 Thread Alexey Semenyuk
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-26 Thread Christian Stein
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-26 Thread Jaikiran Pai
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v3]

2023-09-26 Thread Matthias Baesken
> AIX currently does not have the jdk.jpackage system module. We have to take > this into account for these jpackage tests. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove added blank lines - Changes: -

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547

2023-09-26 Thread Matthias Baesken
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote: > AIX currently does not have the jdk.jpackage system module. We have to take > this into account for these jpackage tests. Thanks for the hint, adding the module info to TEST.properties works too. - PR Comment:

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547 [v2]

2023-09-26 Thread Matthias Baesken
> AIX currently does not have the jdk.jpackage system module. We have to take > this into account for these jpackage tests. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: move module info to TEST.properties -

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547

2023-09-26 Thread Jaikiran Pai
On Tue, 26 Sep 2023 09:53:08 GMT, Jaikiran Pai wrote: >> AIX currently does not have the jdk.jpackage system module. We have to take >> this into account for these jpackage tests. > > test/jdk/tools/jpackage/junit/jdk.jpackage/jdk/jpackage/internal/AppImageFileTest.java > line 26: > >> 24: /*

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547

2023-09-26 Thread Christian Stein
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote: > AIX currently does not have the jdk.jpackage system module. We have to take > this into account for these jpackage tests. Instead of adding those directives to all 11 files, can you please try adding `modules = ...` line to the

Re: RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547

2023-09-26 Thread Jaikiran Pai
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote: > AIX currently does not have the jdk.jpackage system module. We have to take > this into account for these jpackage tests. test/jdk/tools/jpackage/junit/jdk.jpackage/jdk/jpackage/internal/AppImageFileTest.java line 26: > 24: /* > 25:

RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547

2023-09-26 Thread Matthias Baesken
AIX currently does not have the jdk.jpackage system module. We have to take this into account for these jpackage tests. - Commit messages: - JDK-8316897 Changes: https://git.openjdk.org/jdk/pull/15916/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15916=00 Issue: