Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2 [v2]

2023-11-01 Thread Jie Fu
On Thu, 2 Nov 2023 02:02:18 GMT, Joe Darcy wrote: >> Due to their longer-than-typical running time and because the vector API is >> not (yet) in the base module, move the vector API tests in tier 1 to tier 2. > > Joe Darcy has updated the pull request incrementally with one additional > commit

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-11-01 Thread Joe Darcy
On Wed, 1 Nov 2023 20:36:38 GMT, Joe Darcy wrote: >> I would suggest to determine the set of tests which run "at most 10 seconds >> total" and run only them in tier1. >> Also taking into account API coverage. > >> I would suggest to determine the set of tests which run "at most 10 seconds >>

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2 [v2]

2023-11-01 Thread Joe Darcy
> Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback.

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-11-01 Thread Vladimir Kozlov
On Wed, 1 Nov 2023 20:36:38 GMT, Joe Darcy wrote: >> I would suggest to determine the set of tests which run "at most 10 seconds >> total" and run only them in tier1. >> Also taking into account API coverage. > >> I would suggest to determine the set of tests which run "at most 10 seconds >>

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-11-01 Thread Joe Darcy
On Wed, 1 Nov 2023 19:11:28 GMT, Vladimir Kozlov wrote: > I would suggest to determine the set of tests which run "at most 10 seconds > total" and run only them in tier1. Also taking into account API coverage. Okay; I think preserving a handful of tests to check for a dead-on-arrival vector

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-11-01 Thread Vladimir Kozlov
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. I would suggest to determine the set of tests which run "at most 10 seconds total"

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-11-01 Thread Vladimir Kozlov
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. jdk_vector_sanity was added to tier1 to catch issues early in GHA. See #10879 and

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-10-31 Thread Jie Fu
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. Okay. If 2min testing time is not acceptable in tier1 for vector api, I agree with

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-10-31 Thread Joe Darcy
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. > May I ask how long it will take to run jdk_vector_sanity? > > My testing in

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-10-31 Thread Jie Fu
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. May I ask how long it will take to run jdk_vector_sanity? My testing in JDK-8295970

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-10-31 Thread Alan Bateman
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. jdk_vector_sanity was added by JDK-8295970 to get some coverage in tier1. That

RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-10-31 Thread Joe Darcy
Due to their longer-than-typical running time and because the vector API is not (yet) in the base module, move the vector API tests in tier 1 to tier 2. - Commit messages: - JDK-8319195: Move tier 1 vector API regression tests to tier 2 Changes:

Re: RFR: JDK-8319195: Move tier 1 vector API regression tests to tier 2

2023-10-31 Thread Joe Darcy
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. As a check on the semantics of the change, `jtreg -l ...` output for tier 1 and tier